Re: [Xen-Devel] Enabling IRQ Crossbar (Secondary Interrupt Controller) Support

[Julien Grall <julien.grall@citrix.com>]

On 21/07/2015 00:17, Brandon Perez wrote:
> Hello All,

Hi Brandon,

We use to send one mail by patch rather than sending them as an 
attachment of a single email. It's easier for reviewing the patches.
You also need to add you Signed-off-by on each patch and CC all the 
relevant maintainers. Please see [1] for all the guidelines to submit a 
patch to Xen.

A couple of comments I about this series:
	- Patch #2: You are allowing any guest to do smc which, unless you 
trust all the guest, is unsecure. There was some discussion about 
different solution to handle SMC back in 2013 [2]. So far I didn't see 
any more update on it. It may be worth to send a separate thread about 
how to handle SMC.
	- Patch #3, I can't find any documentation or implementation of the 
property "default-mapping" in Linux. Can you provide a link about it?

I will comment more when you will resend the patches inline.

Regards,

[1] http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches
[2] http://lists.xen.org/archives/html/xen-devel/2013-07/msg02779.html

-- 
Julien Grall