Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]

On 07/07/2015 06:08 AM, Stefan Hajnoczi wrote:
> From: Peter Lieven <pl@kamp.de>
> 
> upcoming libnfs versions will support logging debug messages. Add
> support for it in qemu through a per-drive option.
> 
> Examples:
>  qemu -drive if=virtio,file=nfs://...,file.debug=2
>  qemu-img create -o debug=2 nfs://... 10G
> 
> Signed-off-by: Peter Lieven <pl@kamp.de>
> Reviewed-by: Fam Zheng <famz@redhat.com>
> Message-id: 1436251847-16875-1-git-send-email-pl@kamp.de
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  block/nfs.c          | 28 ++++++++++++++++++++++++----
>  qapi/block-core.json | 20 ++++++++++++++++----
>  2 files changed, 40 insertions(+), 8 deletions(-)
> 

> +++ b/qapi/block-core.json
> @@ -1381,9 +1381,9 @@
>  { 'enum': 'BlockdevDriver',
>    'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
>              'dmg', 'file', 'ftp', 'ftps', 'host_cdrom', 'host_device',
> -            'host_floppy', 'http', 'https', 'null-aio', 'null-co', 'parallels',
> -            'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp', 'vdi', 'vhdx',
> -            'vmdk', 'vpc', 'vvfat' ] }
> +            'host_floppy', 'http', 'https', 'nfs', 'null-aio', 'null-co',
> +            'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp',
> +            'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }

Probably also ought to document the docs for BlockDeviceInfo.drv, to
mention that 'nfs' was added in 2.4.

[may be moot for now, since this patch was dropped when the pull request
was resent; or even mean you want "2.5" when you DO add and document it]

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]