All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level
Date: Tue, 21 Jul 2015 16:38:35 -0600	[thread overview]
Message-ID: <55AEC9EB.7050008@redhat.com> (raw)
In-Reply-To: <20150707134557.GG14035@noname.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

On 07/07/2015 07:45 AM, Kevin Wolf wrote:

>>> Kevin has pointed out at the QAPI portion of this patch isn't ready
>>> for prime time yet, so I will revert the patch and resend the pull
>>> request.
>>
>> Yes please, I was not aware that adding the QAPI part
>> has such an impact. I would appreciate if someone who has
>> more experience with the QAPI stuff would look at this and
>> make a proposal how to handle the NFS (and also the iSCSI)
>> case. I'm happy to look at the implementation then.
> 
> We should definitely come to a conclusion on this for 2.5. The same
> problem doesn't only apply for NFS, but for all network protocols, and
> this is one of the major reasons why blockdev-add isn't ready yet.
> 
> We'll need Eric for this discussion, though, and he'll only return from
> vacation next Monday.

I'm back now (obviously), but we should probably discuss in a separate
thread rather than dangling off this pull request ;)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2015-07-21 22:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07 12:08 [Qemu-devel] [PULL for-2.4 0/7] Block patches Stefan Hajnoczi
2015-07-07 12:08 ` [Qemu-devel] [PULL for-2.4 1/7] qcow2: remove unnecessary check Stefan Hajnoczi
2015-07-07 12:08 ` [Qemu-devel] [PULL for-2.4 2/7] block: update bdrv_drain_all()/bdrv_drain() comments Stefan Hajnoczi
2015-07-07 12:08 ` [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level Stefan Hajnoczi
2015-07-07 12:50   ` Peter Lieven
2015-07-07 13:13     ` Stefan Hajnoczi
2015-07-07 13:40       ` Kevin Wolf
2015-07-08 17:48         ` Max Reitz
2015-07-07 13:24   ` Stefan Hajnoczi
2015-07-07 13:41     ` Peter Lieven
2015-07-07 13:45       ` Kevin Wolf
2015-07-21 22:38         ` Eric Blake [this message]
2015-07-21 22:37   ` Eric Blake
2015-07-07 12:08 ` [Qemu-devel] [PULL for-2.4 4/7] block: Initialize local_err in bdrv_append_temp_snapshot Stefan Hajnoczi
2015-07-07 12:08 ` [Qemu-devel] [PULL for-2.4 5/7] block: Use bdrv_drain to replace uncessary bdrv_drain_all Stefan Hajnoczi
2015-07-07 12:08 ` [Qemu-devel] [PULL for-2.4 6/7] block/raw-posix: Don't think /dev/fd/<NN> is a floppy drive Stefan Hajnoczi
2015-07-07 12:08 ` [Qemu-devel] [PULL for-2.4 7/7] blockjob: add block_job_release function Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AEC9EB.7050008@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.