From: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mporter-OWPKS81ov/FWk0Htik3J/w@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers
Date: Wed, 22 Jul 2015 08:26:36 +0100 [thread overview]
Message-ID: <55AF45AC.9040003@linaro.org> (raw)
In-Reply-To: <1590184041.70825.1437495942088.JavaMail.open-xchange-0SF9iQWekqLc2Cnrm9MUdsgmgJlYmuWJ@public.gmane.org>
Thanks Stefan,
On 21/07/15 17:25, Stefan Wahren wrote:
>> +
>> >+ addr = of_get_property(cell_np, "reg", &len);
>> >+ if (!addr || (len < 2 * sizeof(int))) {
> I'm not sure, but shouldn't be sizeof(u32) more portable?
>
yes it makes sense, I will change it.
>> >[...]
>> >+
>> >+ addr = of_get_property(cell_np, "bits", &len);
>> >+ if (addr && len == (2 * sizeof(int))) {
> dito
yep.
--srini
WARNING: multiple messages have this Message-ID (diff)
From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers
Date: Wed, 22 Jul 2015 08:26:36 +0100 [thread overview]
Message-ID: <55AF45AC.9040003@linaro.org> (raw)
In-Reply-To: <1590184041.70825.1437495942088.JavaMail.open-xchange@oxbsltgw08.schlund.de>
Thanks Stefan,
On 21/07/15 17:25, Stefan Wahren wrote:
>> +
>> >+ addr = of_get_property(cell_np, "reg", &len);
>> >+ if (!addr || (len < 2 * sizeof(int))) {
> I'm not sure, but shouldn't be sizeof(u32) more portable?
>
yes it makes sense, I will change it.
>> >[...]
>> >+
>> >+ addr = of_get_property(cell_np, "bits", &len);
>> >+ if (addr && len == (2 * sizeof(int))) {
> dito
yep.
--srini
WARNING: multiple messages have this Message-ID (diff)
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org
Cc: wxt@rock-chips.com, linux-api@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
sboyd@codeaurora.org, arnd@arndb.de, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org, mporter@konsulko.com,
linux-arm-msm@vger.kernel.org,
Maxime Ripard <maxime.ripard@free-electrons.com>,
pantelis.antoniou@konsulko.com, Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers
Date: Wed, 22 Jul 2015 08:26:36 +0100 [thread overview]
Message-ID: <55AF45AC.9040003@linaro.org> (raw)
In-Reply-To: <1590184041.70825.1437495942088.JavaMail.open-xchange@oxbsltgw08.schlund.de>
Thanks Stefan,
On 21/07/15 17:25, Stefan Wahren wrote:
>> +
>> >+ addr = of_get_property(cell_np, "reg", &len);
>> >+ if (!addr || (len < 2 * sizeof(int))) {
> I'm not sure, but shouldn't be sizeof(u32) more portable?
>
yes it makes sense, I will change it.
>> >[...]
>> >+
>> >+ addr = of_get_property(cell_np, "bits", &len);
>> >+ if (addr && len == (2 * sizeof(int))) {
> dito
yep.
--srini
next prev parent reply other threads:[~2015-07-22 7:26 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 14:42 [PATCH v8 0/9] Add simple NVMEM Framework via regmap Srinivas Kandagatla
2015-07-20 14:42 ` Srinivas Kandagatla
2015-07-20 14:43 ` [PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers Srinivas Kandagatla
2015-07-20 14:43 ` Srinivas Kandagatla
2015-07-21 16:25 ` Stefan Wahren
2015-07-21 16:25 ` Stefan Wahren
[not found] ` <1590184041.70825.1437495942088.JavaMail.open-xchange-0SF9iQWekqLc2Cnrm9MUdsgmgJlYmuWJ@public.gmane.org>
2015-07-22 7:26 ` Srinivas Kandagatla [this message]
2015-07-22 7:26 ` Srinivas Kandagatla
2015-07-22 7:26 ` Srinivas Kandagatla
2015-07-20 14:43 ` [PATCH v8 3/9] nvmem: Add nvmem_device based consumer apis Srinivas Kandagatla
2015-07-20 14:43 ` Srinivas Kandagatla
[not found] ` <1437403352-4091-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-20 14:43 ` [PATCH v8 1/9] nvmem: Add a simple NVMEM framework for nvmem providers Srinivas Kandagatla
2015-07-20 14:43 ` Srinivas Kandagatla
2015-07-20 14:43 ` Srinivas Kandagatla
[not found] ` <1437403392-4136-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-20 21:11 ` Stephen Boyd
2015-07-20 21:11 ` Stephen Boyd
2015-07-20 21:11 ` Stephen Boyd
2015-07-21 9:41 ` Srinivas Kandagatla
2015-07-21 9:41 ` Srinivas Kandagatla
[not found] ` <55AE13D8.6020301-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-21 9:54 ` Stefan Wahren
2015-07-21 9:54 ` Stefan Wahren
2015-07-21 9:54 ` Stefan Wahren
[not found] ` <55AE16BB.9090201-eS4NqCHxEME@public.gmane.org>
2015-07-21 10:31 ` Srinivas Kandagatla
2015-07-21 10:31 ` Srinivas Kandagatla
2015-07-21 10:31 ` Srinivas Kandagatla
2015-07-21 17:59 ` Stephen Boyd
2015-07-21 17:59 ` Stephen Boyd
[not found] ` <55AE8864.6020608-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-07-21 18:40 ` Srinivas Kandagatla
2015-07-21 18:40 ` Srinivas Kandagatla
2015-07-21 18:40 ` Srinivas Kandagatla
2015-07-21 18:51 ` Srinivas Kandagatla
2015-07-21 18:51 ` Srinivas Kandagatla
2015-07-23 15:26 ` Stefan Wahren
2015-07-23 15:26 ` Stefan Wahren
2015-07-23 15:50 ` Srinivas Kandagatla
2015-07-23 15:50 ` Srinivas Kandagatla
2015-07-20 14:43 ` [PATCH v8 4/9] nvmem: Add bindings for simple nvmem framework Srinivas Kandagatla
2015-07-20 14:43 ` Srinivas Kandagatla
2015-07-20 14:43 ` Srinivas Kandagatla
2015-07-20 14:44 ` [PATCH v8 8/9] nvmem: sunxi: Move the SID driver to the " Srinivas Kandagatla
2015-07-20 14:44 ` Srinivas Kandagatla
2015-07-20 14:44 ` Srinivas Kandagatla
[not found] ` <1437403462-4432-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-21 16:38 ` Stefan Wahren
2015-07-21 16:38 ` Stefan Wahren
2015-07-21 16:38 ` Stefan Wahren
[not found] ` <2114639619.71276.1437496724946.JavaMail.open-xchange-0SF9iQWekqLc2Cnrm9MUdsgmgJlYmuWJ@public.gmane.org>
2015-07-23 15:48 ` Srinivas Kandagatla
2015-07-23 15:48 ` Srinivas Kandagatla
2015-07-23 15:48 ` Srinivas Kandagatla
2015-07-23 15:18 ` Stefan Wahren
2015-07-23 15:18 ` Stefan Wahren
2015-07-23 15:18 ` Stefan Wahren
[not found] ` <55B105B6.7000502-eS4NqCHxEME@public.gmane.org>
2015-07-23 15:48 ` Srinivas Kandagatla
2015-07-23 15:48 ` Srinivas Kandagatla
2015-07-23 15:48 ` Srinivas Kandagatla
2015-07-20 14:43 ` [PATCH v8 5/9] Documentation: nvmem: add nvmem api level and how-to doc Srinivas Kandagatla
2015-07-20 14:43 ` Srinivas Kandagatla
2015-07-20 14:44 ` [PATCH v8 6/9] nvmem: qfprom: Add Qualcomm QFPROM support Srinivas Kandagatla
2015-07-20 14:44 ` Srinivas Kandagatla
[not found] ` <1437403445-4348-1-git-send-email-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-07-20 21:20 ` Stephen Boyd
2015-07-20 21:20 ` Stephen Boyd
2015-07-20 21:20 ` Stephen Boyd
2015-07-21 9:42 ` Srinivas Kandagatla
2015-07-21 9:42 ` Srinivas Kandagatla
2015-07-20 14:44 ` [PATCH v8 7/9] nvmem: qfprom: Add bindings for qfprom Srinivas Kandagatla
2015-07-20 14:44 ` Srinivas Kandagatla
2015-07-20 14:44 ` [PATCH v8 9/9] nvmem: Add to MAINTAINERS for nvmem framework Srinivas Kandagatla
2015-07-20 14:44 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AF45AC.9040003@linaro.org \
--to=srinivas.kandagatla-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=mporter-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=stefan.wahren-eS4NqCHxEME@public.gmane.org \
--cc=wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.