All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: mtk.manpages@gmail.com, Hugh Dickins <hughd@google.com>,
	Davide Libenzi <davidel@xmailserver.org>,
	Eric B Munson <emunson@akamai.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-man@vger.kernel.org
Subject: Re: [patch] mmap.2: document the munmap exception for underlying page size
Date: Wed, 22 Jul 2015 19:16:57 +0200	[thread overview]
Message-ID: <55AFD009.6080706@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1507211736300.24133@chino.kir.corp.google.com>

Hi David,

On 07/22/2015 02:41 AM, David Rientjes wrote:
> munmap(2) will fail with an errno of EINVAL for hugetlb memory if the 
> length is not a multiple of the underlying page size.
> 
> Documentation/vm/hugetlbpage.txt was updated to specify this behavior 
> since Linux 4.1 in commit 80d6b94bd69a ("mm, doc: cleanup and clarify 
> munmap behavior for hugetlb memory").
> 
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  man2/mmap.2 | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/man2/mmap.2 b/man2/mmap.2
> --- a/man2/mmap.2
> +++ b/man2/mmap.2
> @@ -383,6 +383,10 @@ All pages containing a part
>  of the indicated range are unmapped, and subsequent references
>  to these pages will generate
>  .BR SIGSEGV .
> +An exception is when the underlying memory is not of the native page
> +size, such as hugetlb page sizes, whereas
> +.I length
> +must be a multiple of the underlying page size.
>  It is not an error if the
>  indicated range does not contain any mapped pages.
>  .SS Timestamps changes for file-backed mappings

I'm struggling a bit to understand your text. Is the point this:

    If we have a hugetlb area, then the munmap() length
    must be a multiple of the page size.

?

Are there any requirements about 'addr'? Must it also me huge-page-aligned?

Thanks,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: mtk.manpages@gmail.com, Hugh Dickins <hughd@google.com>,
	Davide Libenzi <davidel@xmailserver.org>,
	Eric B Munson <emunson@akamai.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-man@vger.kernel.org
Subject: Re: [patch] mmap.2: document the munmap exception for underlying page size
Date: Wed, 22 Jul 2015 19:16:57 +0200	[thread overview]
Message-ID: <55AFD009.6080706@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1507211736300.24133@chino.kir.corp.google.com>

Hi David,

On 07/22/2015 02:41 AM, David Rientjes wrote:
> munmap(2) will fail with an errno of EINVAL for hugetlb memory if the 
> length is not a multiple of the underlying page size.
> 
> Documentation/vm/hugetlbpage.txt was updated to specify this behavior 
> since Linux 4.1 in commit 80d6b94bd69a ("mm, doc: cleanup and clarify 
> munmap behavior for hugetlb memory").
> 
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  man2/mmap.2 | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/man2/mmap.2 b/man2/mmap.2
> --- a/man2/mmap.2
> +++ b/man2/mmap.2
> @@ -383,6 +383,10 @@ All pages containing a part
>  of the indicated range are unmapped, and subsequent references
>  to these pages will generate
>  .BR SIGSEGV .
> +An exception is when the underlying memory is not of the native page
> +size, such as hugetlb page sizes, whereas
> +.I length
> +must be a multiple of the underlying page size.
>  It is not an error if the
>  indicated range does not contain any mapped pages.
>  .SS Timestamps changes for file-backed mappings

I'm struggling a bit to understand your text. Is the point this:

    If we have a hugetlb area, then the munmap() length
    must be a multiple of the page size.

?

Are there any requirements about 'addr'? Must it also me huge-page-aligned?

Thanks,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

  reply	other threads:[~2015-07-22 17:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22  0:41 [patch] mmap.2: document the munmap exception for underlying page size David Rientjes
2015-07-22  0:41 ` David Rientjes
2015-07-22 17:16 ` Michael Kerrisk (man-pages) [this message]
2015-07-22 17:16   ` Michael Kerrisk (man-pages)
2015-07-22 22:03   ` David Rientjes
2015-07-22 22:03     ` David Rientjes
2015-07-23 13:05     ` Michael Kerrisk (man-pages)
2015-07-23 13:05       ` Michael Kerrisk (man-pages)
     [not found] ` <alpine.DEB.2.10.1507211736300.24133-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2015-07-22 23:31   ` Mike Kravetz
2015-07-22 23:31     ` Mike Kravetz
2015-07-22 23:31     ` Mike Kravetz
     [not found]     ` <55B027D3.4020608-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-07-22 23:49       ` David Rientjes
2015-07-22 23:49         ` David Rientjes
2015-07-22 23:49         ` David Rientjes
     [not found]         ` <alpine.DEB.2.10.1507221646100.14953-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2015-07-23 13:15           ` Michael Kerrisk (man-pages)
2015-07-23 13:15             ` Michael Kerrisk (man-pages)
2015-07-23 13:15             ` Michael Kerrisk (man-pages)
2015-07-23 20:52             ` David Rientjes
2015-07-23 20:52               ` David Rientjes
     [not found]               ` <alpine.DEB.2.10.1507231349080.31024-X6Q0R45D7oAcqpCFd4KODRPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2015-07-24  6:57                 ` Michael Kerrisk (man-pages)
2015-07-24  6:57                   ` Michael Kerrisk (man-pages)
2015-07-24  6:57                   ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AFD009.6080706@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=davidel@xmailserver.org \
    --cc=emunson@akamai.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.