From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>, Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v5 7/7] x86/PCI: intercept all PV Dom0 MMCFG writes
Date: Wed, 22 Jul 2015 18:55:03 +0100 [thread overview]
Message-ID: <55AFD8F7.20402@citrix.com> (raw)
In-Reply-To: <55AD208802000078000932C1@mail.emea.novell.com>
On 20/07/15 15:23, Jan Beulich wrote:
> ... to hook up pci_conf_write_intercept() even for Dom0 not using
> method 1 accesses for the base part of PCI device config space.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Not entirely sure whether the complicated logging logic in x86/mm.c is
> actually worth it.
There is a behavioural change insofar that 64bit access will no longer
function, but I am not sure this matters too much, as such an access to
config space is almost certainly buggy.
The rest however looks sane, so
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
prev parent reply other threads:[~2015-07-22 17:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 14:14 [PATCH v5 0/7] x86/MSI: XSA-120, 126, 128-131 follow-up Jan Beulich
2015-07-20 14:18 ` [PATCH v5 1/7] x86/PCI: add config space abstract write intercept logic Jan Beulich
2015-07-20 14:19 ` [PATCH v5 2/7] x86/MSI-X: track host and guest mask-all requests separately Jan Beulich
2015-07-20 14:19 ` [PATCH v5 3/7] x86/MSI-X: be more careful during teardown Jan Beulich
2015-07-20 14:20 ` [PATCH v5 4/7] x86/MSI-X: access MSI-X table only after having enabled MSI-X Jan Beulich
2015-07-20 14:22 ` [PATCH v5 5/7] x86/MSI-X: reduce fiddling with control register during restore Jan Beulich
2015-07-20 14:22 ` [PATCH v5 6/7] x86/MSI: properly track guest masking requests Jan Beulich
2015-07-22 17:31 ` Andrew Cooper
2015-07-20 14:23 ` [PATCH v5 7/7] x86/PCI: intercept all PV Dom0 MMCFG writes Jan Beulich
2015-07-22 17:55 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AFD8F7.20402@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.