All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] i2c: tegra: Build warning fixes for 64-bit
@ 2015-07-22 21:33 Stephen Warren
  2015-07-22 22:04 ` Stephen Warren
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Stephen Warren @ 2015-07-22 21:33 UTC (permalink / raw)
  To: u-boot

From: Thierry Reding <treding@nvidia.com>

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Tom Warren <twarren@nvidia.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 drivers/i2c/tegra_i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/tegra_i2c.c b/drivers/i2c/tegra_i2c.c
index fc9564699489..a4289788a65c 100644
--- a/drivers/i2c/tegra_i2c.c
+++ b/drivers/i2c/tegra_i2c.c
@@ -235,7 +235,7 @@ static int send_recv_packets(struct i2c_bus *i2c_bus,
 			if ((words == 1) && last_bytes) {
 				local = 0;
 				memcpy(&local, dptr, last_bytes);
-			} else if ((unsigned)dptr & 3) {
+			} else if ((unsigned long)dptr & 3) {
 				memcpy(&local, dptr, sizeof(u32));
 			} else {
 				local = *wptr;
@@ -258,7 +258,7 @@ static int send_recv_packets(struct i2c_bus *i2c_bus,
 			local = readl(&control->rx_fifo);
 			if ((words == 1) && last_bytes)
 				memcpy(dptr, (char *)&local, last_bytes);
-			else if ((unsigned)dptr & 3)
+			else if ((unsigned long)dptr & 3)
 				memcpy(dptr, &local, sizeof(u32));
 			else
 				*wptr = local;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] i2c: tegra: Build warning fixes for 64-bit
  2015-07-22 21:33 [U-Boot] [PATCH] i2c: tegra: Build warning fixes for 64-bit Stephen Warren
@ 2015-07-22 22:04 ` Stephen Warren
  2015-07-22 22:11 ` Tom Rini
  2015-07-23 20:18 ` Simon Glass
  2 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2015-07-22 22:04 UTC (permalink / raw)
  To: u-boot

On 07/22/2015 03:33 PM, Stephen Warren wrote:

Apparently Heiko is out-of-the-office until Aug 10th.

Tom Rini, perhaps you could apply this directly to u-boot.git, or ack it 
so that Tom Warren can apply it to the Tegra tree? The basic Tegra210 
SoC patches will rely on these warnings being fixed, and I'd rather not 
hold off getting the SoC patches applied until mid-August.

>   drivers/i2c/tegra_i2c.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/tegra_i2c.c b/drivers/i2c/tegra_i2c.c
> index fc9564699489..a4289788a65c 100644
> --- a/drivers/i2c/tegra_i2c.c
> +++ b/drivers/i2c/tegra_i2c.c
> @@ -235,7 +235,7 @@ static int send_recv_packets(struct i2c_bus *i2c_bus,
>   			if ((words == 1) && last_bytes) {
>   				local = 0;
>   				memcpy(&local, dptr, last_bytes);
> -			} else if ((unsigned)dptr & 3) {
> +			} else if ((unsigned long)dptr & 3) {
>   				memcpy(&local, dptr, sizeof(u32));
>   			} else {
>   				local = *wptr;
> @@ -258,7 +258,7 @@ static int send_recv_packets(struct i2c_bus *i2c_bus,
>   			local = readl(&control->rx_fifo);
>   			if ((words == 1) && last_bytes)
>   				memcpy(dptr, (char *)&local, last_bytes);
> -			else if ((unsigned)dptr & 3)
> +			else if ((unsigned long)dptr & 3)
>   				memcpy(dptr, &local, sizeof(u32));
>   			else
>   				*wptr = local;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] i2c: tegra: Build warning fixes for 64-bit
  2015-07-22 21:33 [U-Boot] [PATCH] i2c: tegra: Build warning fixes for 64-bit Stephen Warren
  2015-07-22 22:04 ` Stephen Warren
@ 2015-07-22 22:11 ` Tom Rini
  2015-07-23 20:18 ` Simon Glass
  2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2015-07-22 22:11 UTC (permalink / raw)
  To: u-boot

On Wed, Jul 22, 2015 at 03:33:22PM -0600, Stephen Warren wrote:

> From: Thierry Reding <treding@nvidia.com>
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Acked-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150722/f5c65cba/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] i2c: tegra: Build warning fixes for 64-bit
  2015-07-22 21:33 [U-Boot] [PATCH] i2c: tegra: Build warning fixes for 64-bit Stephen Warren
  2015-07-22 22:04 ` Stephen Warren
  2015-07-22 22:11 ` Tom Rini
@ 2015-07-23 20:18 ` Simon Glass
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2015-07-23 20:18 UTC (permalink / raw)
  To: u-boot

On 22 July 2015 at 15:33, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  drivers/i2c/tegra_i2c.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-07-23 20:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-22 21:33 [U-Boot] [PATCH] i2c: tegra: Build warning fixes for 64-bit Stephen Warren
2015-07-22 22:04 ` Stephen Warren
2015-07-22 22:11 ` Tom Rini
2015-07-23 20:18 ` Simon Glass

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.