From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Rientjes <rientjes@google.com>,
Hugh Dickins <hughd@google.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Christoph Hellwig <hch@infradead.org>,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate()
Date: Wed, 22 Jul 2015 15:23:42 -0700 [thread overview]
Message-ID: <55B017EE.5020203@oracle.com> (raw)
In-Reply-To: <20150722150345.f8d5b0042cfa7112bd95d9ef@linux-foundation.org>
On 07/22/2015 03:03 PM, Andrew Morton wrote:
> On Tue, 21 Jul 2015 11:09:43 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
...
>> +
>> + if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE))
>> + return -EOPNOTSUPP;
>
> EOPNOTSUPP is a networking thing. It's inappropriate here.
>
> The problem is that if this error is ever returned to userspace, the
> user will be sitting looking at "Operation not supported on transport
> endpoint" and wondering what went wrong in the networking stack.
Trying to follow FALLOCATE(2) man page:
"EOPNOTSUPP
The filesystem containing the file referred to by fd does not
support this operation; or the mode is not supported by the
filesystem containing the file referred to by fd."
--
Mike Kravetz
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Rientjes <rientjes@google.com>,
Hugh Dickins <hughd@google.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Aneesh Kumar <aneesh.kumar@linux.vnet.ibm.com>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Christoph Hellwig <hch@infradead.org>,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate()
Date: Wed, 22 Jul 2015 15:23:42 -0700 [thread overview]
Message-ID: <55B017EE.5020203@oracle.com> (raw)
In-Reply-To: <20150722150345.f8d5b0042cfa7112bd95d9ef@linux-foundation.org>
On 07/22/2015 03:03 PM, Andrew Morton wrote:
> On Tue, 21 Jul 2015 11:09:43 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
...
>> +
>> + if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE))
>> + return -EOPNOTSUPP;
>
> EOPNOTSUPP is a networking thing. It's inappropriate here.
>
> The problem is that if this error is ever returned to userspace, the
> user will be sitting looking at "Operation not supported on transport
> endpoint" and wondering what went wrong in the networking stack.
Trying to follow FALLOCATE(2) man page:
"EOPNOTSUPP
The filesystem containing the file referred to by fd does not
support this operation; or the mode is not supported by the
filesystem containing the file referred to by fd."
--
Mike Kravetz
next prev parent reply other threads:[~2015-07-22 22:23 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 18:09 [PATCH v4 00/10] hugetlbfs: add fallocate support Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
2015-07-21 18:09 ` [PATCH v4 01/10] mm/hugetlb: add cache of descriptors to resv_map for region_add Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
2015-07-22 22:03 ` Andrew Morton
2015-07-22 22:03 ` Andrew Morton
2015-07-21 18:09 ` [PATCH v4 02/10] mm/hugetlb: add region_del() to delete a specific range of entries Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
2015-07-21 18:09 ` [PATCH v4 03/10] mm/hugetlb: expose hugetlb fault mutex for use by fallocate Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
2015-07-22 22:03 ` Andrew Morton
2015-07-22 22:03 ` Andrew Morton
2015-07-21 18:09 ` [PATCH v4 04/10] hugetlbfs: hugetlb_vmtruncate_list() needs to take a range to delete Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
2015-07-21 18:09 ` [PATCH v4 05/10] hugetlbfs: truncate_hugepages() takes a range of pages Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
2015-07-21 18:09 ` [PATCH v4 06/10] mm/hugetlb: vma_has_reserves() needs to handle fallocate hole punch Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
2015-07-21 18:09 ` [PATCH v4 07/10] mm/hugetlb: alloc_huge_page handle areas hole punched by fallocate Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
2015-07-21 18:09 ` [PATCH v4 08/10] hugetlbfs: New huge_add_to_page_cache helper routine Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
2015-07-21 18:09 ` [PATCH v4 09/10] hugetlbfs: add hugetlbfs_fallocate() Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
[not found] ` <1437502184-14269-10-git-send-email-mike.kravetz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-07-22 22:03 ` Andrew Morton
2015-07-22 22:03 ` Andrew Morton
2015-07-22 22:03 ` Andrew Morton
2015-07-22 22:23 ` Mike Kravetz [this message]
2015-07-22 22:23 ` Mike Kravetz
[not found] ` <55B017EE.5020203-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-07-22 22:30 ` Andrew Morton
2015-07-22 22:30 ` Andrew Morton
2015-07-22 22:30 ` Andrew Morton
2015-07-21 18:09 ` [PATCH v4 10/10] mm: madvise allow remove operation for hugetlbfs Mike Kravetz
2015-07-21 18:09 ` Mike Kravetz
2015-07-22 22:03 ` [PATCH v4 00/10] hugetlbfs: add fallocate support Andrew Morton
2015-07-22 22:03 ` Andrew Morton
[not found] ` <1437502184-14269-1-git-send-email-mike.kravetz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-07-22 22:06 ` Andrew Morton
2015-07-22 22:06 ` Andrew Morton
2015-07-22 22:06 ` Andrew Morton
[not found] ` <20150722150647.2597c7e5be9ee1eecc438b6f-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2015-07-22 22:19 ` Davidlohr Bueso
2015-07-22 22:19 ` Davidlohr Bueso
2015-07-22 22:19 ` Davidlohr Bueso
[not found] ` <1437603594.3298.5.camel-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org>
2015-07-22 22:30 ` Andrew Morton
2015-07-22 22:30 ` Andrew Morton
2015-07-22 22:30 ` Andrew Morton
[not found] ` <20150722153023.e8f15eb4e490f79cc029c8cd-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2015-07-22 22:34 ` Davidlohr Bueso
2015-07-22 22:34 ` Davidlohr Bueso
2015-07-22 22:34 ` Davidlohr Bueso
[not found] ` <1437604474.3298.7.camel-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org>
2015-07-22 22:37 ` Andrew Morton
2015-07-22 22:37 ` Andrew Morton
2015-07-22 22:37 ` Andrew Morton
2015-07-22 22:50 ` Davidlohr Bueso
2015-07-22 22:50 ` Davidlohr Bueso
2015-07-22 22:54 ` Davidlohr Bueso
2015-07-22 22:54 ` Davidlohr Bueso
2015-07-22 23:18 ` Mike Kravetz
2015-07-22 23:18 ` Mike Kravetz
2015-07-22 23:54 ` Davidlohr Bueso
2015-07-22 23:54 ` Davidlohr Bueso
2015-07-23 0:05 ` David Rientjes
2015-07-23 0:05 ` David Rientjes
2015-07-23 15:17 ` Eric B Munson
2015-07-23 17:05 ` Mike Kravetz
2015-07-23 17:05 ` Mike Kravetz
[not found] ` <55B11EEF.1070605-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-07-23 17:17 ` Eric B Munson
2015-07-23 17:17 ` Eric B Munson
2015-07-23 17:29 ` Mike Kravetz
2015-07-23 17:29 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B017EE.5020203@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=hch@infradead.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=hughd@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.