From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>,
linux-arm-kernel@lists.infradead.org
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"open list:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS"
<linux-kernel@vger.kernel.org>,
"open list:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS"
<linux-samsung-soc@vger.kernel.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] clk: s2mps11: Use kcalloc instead of kzalloc for array allocation
Date: Thu, 23 Jul 2015 09:38:21 +0900 [thread overview]
Message-ID: <55B0377D.10908@samsung.com> (raw)
In-Reply-To: <1437557693-29433-1-git-send-email-vaibhav.hiremath@linaro.org>
On 22.07.2015 18:34, Vaibhav Hiremath wrote:
> This patch cleans up the driver for,
>
> - Use devm_kcalloc varient instead of devm_kzalloc for array
> allocation.
> - clk_prepare/unprepare, remove "ret" variable as it is not required
> - use __exit for cleanup function
>
> As I am referring this driver as a reference for my 88pm800 clk driver,
> applying same changes here as well.
>
> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
> ---
> Since I do not have platform to test, it would be helpful if someone
> tests it for me.
> I have build tested it.
>
> drivers/clk/clk-s2mps11.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
Looks good, simplifies the code and fixes the __init/__exit.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: s2mps11: Use kcalloc instead of kzalloc for array allocation
Date: Thu, 23 Jul 2015 09:38:21 +0900 [thread overview]
Message-ID: <55B0377D.10908@samsung.com> (raw)
In-Reply-To: <1437557693-29433-1-git-send-email-vaibhav.hiremath@linaro.org>
On 22.07.2015 18:34, Vaibhav Hiremath wrote:
> This patch cleans up the driver for,
>
> - Use devm_kcalloc varient instead of devm_kzalloc for array
> allocation.
> - clk_prepare/unprepare, remove "ret" variable as it is not required
> - use __exit for cleanup function
>
> As I am referring this driver as a reference for my 88pm800 clk driver,
> applying same changes here as well.
>
> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
> ---
> Since I do not have platform to test, it would be helpful if someone
> tests it for me.
> I have build tested it.
>
> drivers/clk/clk-s2mps11.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
Looks good, simplifies the code and fixes the __init/__exit.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-07-23 0:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 9:34 [PATCH] clk: s2mps11: Use kcalloc instead of kzalloc for array allocation Vaibhav Hiremath
2015-07-22 9:34 ` Vaibhav Hiremath
2015-07-22 9:34 ` Vaibhav Hiremath
2015-07-22 11:39 ` Anand Moon
2015-07-22 11:39 ` Anand Moon
2015-07-22 12:02 ` Vaibhav Hiremath
2015-07-23 0:38 ` Krzysztof Kozlowski [this message]
2015-07-23 0:38 ` Krzysztof Kozlowski
2015-07-24 21:39 ` Stephen Boyd
2015-07-24 21:39 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0377D.10908@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sbkim73@samsung.com \
--cc=sboyd@codeaurora.org \
--cc=vaibhav.hiremath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.