* [Qemu-trivial] [PATCH for-2.4] vl: Fix compiler warning for builds without VLC
@ 2015-07-22 17:53 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2015-07-22 17:53 UTC (permalink / raw)
To: QEMU Trivial, Paolo Bonzini, Markus Armbruster
Cc: Peter Maydell, QEMU Developer, Stefan Weil
This regression was caused by commit 70b94331.
CC vl.o
vl.c: In function ‘select_display’:
vl.c:2064:12: error: unused variable ‘err’ [-Werror=unused-variable]
Error *err = NULL;
^
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 5856396..0adbbd6 100644
--- a/vl.c
+++ b/vl.c
@@ -2061,7 +2061,6 @@ static void select_vgahw (const char *p)
static DisplayType select_display(const char *p)
{
- Error *err = NULL;
const char *opts;
DisplayType display = DT_DEFAULT;
@@ -2130,6 +2129,7 @@ static DisplayType select_display(const char *p)
} else if (strstart(p, "vnc", &opts)) {
#ifdef CONFIG_VNC
if (*opts == '=') {
+ Error *err = NULL;
if (vnc_parse(opts + 1, &err) == NULL) {
error_report_err(err);
exit(1);
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH for-2.4] vl: Fix compiler warning for builds without VLC
@ 2015-07-22 17:53 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2015-07-22 17:53 UTC (permalink / raw)
To: QEMU Trivial, Paolo Bonzini, Markus Armbruster
Cc: Peter Maydell, QEMU Developer, Stefan Weil
This regression was caused by commit 70b94331.
CC vl.o
vl.c: In function ‘select_display’:
vl.c:2064:12: error: unused variable ‘err’ [-Werror=unused-variable]
Error *err = NULL;
^
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 5856396..0adbbd6 100644
--- a/vl.c
+++ b/vl.c
@@ -2061,7 +2061,6 @@ static void select_vgahw (const char *p)
static DisplayType select_display(const char *p)
{
- Error *err = NULL;
const char *opts;
DisplayType display = DT_DEFAULT;
@@ -2130,6 +2129,7 @@ static DisplayType select_display(const char *p)
} else if (strstart(p, "vnc", &opts)) {
#ifdef CONFIG_VNC
if (*opts == '=') {
+ Error *err = NULL;
if (vnc_parse(opts + 1, &err) == NULL) {
error_report_err(err);
exit(1);
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.4] vl: Fix compiler warning for builds without VLC
2015-07-22 17:53 ` [Qemu-devel] " Stefan Weil
@ 2015-07-23 1:43 ` Wen Congyang
-1 siblings, 0 replies; 6+ messages in thread
From: Wen Congyang @ 2015-07-23 1:43 UTC (permalink / raw)
To: Stefan Weil, QEMU Trivial, Paolo Bonzini, Markus Armbruster
Cc: Peter Maydell, QEMU Developer
On 07/23/2015 01:53 AM, Stefan Weil wrote:
> This regression was caused by commit 70b94331.
vnc, not vlc in the title.
Reviewed-by: Wen Congyang <wency@cn.fujitsu.com>
>
> CC vl.o
> vl.c: In function ‘select_display’:
> vl.c:2064:12: error: unused variable ‘err’ [-Werror=unused-variable]
> Error *err = NULL;
> ^
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 5856396..0adbbd6 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2061,7 +2061,6 @@ static void select_vgahw (const char *p)
>
> static DisplayType select_display(const char *p)
> {
> - Error *err = NULL;
> const char *opts;
> DisplayType display = DT_DEFAULT;
>
> @@ -2130,6 +2129,7 @@ static DisplayType select_display(const char *p)
> } else if (strstart(p, "vnc", &opts)) {
> #ifdef CONFIG_VNC
> if (*opts == '=') {
> + Error *err = NULL;
> if (vnc_parse(opts + 1, &err) == NULL) {
> error_report_err(err);
> exit(1);
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH for-2.4] vl: Fix compiler warning for builds without VLC
@ 2015-07-23 1:43 ` Wen Congyang
0 siblings, 0 replies; 6+ messages in thread
From: Wen Congyang @ 2015-07-23 1:43 UTC (permalink / raw)
To: Stefan Weil, QEMU Trivial, Paolo Bonzini, Markus Armbruster
Cc: Peter Maydell, QEMU Developer
On 07/23/2015 01:53 AM, Stefan Weil wrote:
> This regression was caused by commit 70b94331.
vnc, not vlc in the title.
Reviewed-by: Wen Congyang <wency@cn.fujitsu.com>
>
> CC vl.o
> vl.c: In function ‘select_display’:
> vl.c:2064:12: error: unused variable ‘err’ [-Werror=unused-variable]
> Error *err = NULL;
> ^
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 5856396..0adbbd6 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2061,7 +2061,6 @@ static void select_vgahw (const char *p)
>
> static DisplayType select_display(const char *p)
> {
> - Error *err = NULL;
> const char *opts;
> DisplayType display = DT_DEFAULT;
>
> @@ -2130,6 +2129,7 @@ static DisplayType select_display(const char *p)
> } else if (strstart(p, "vnc", &opts)) {
> #ifdef CONFIG_VNC
> if (*opts == '=') {
> + Error *err = NULL;
> if (vnc_parse(opts + 1, &err) == NULL) {
> error_report_err(err);
> exit(1);
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [PATCH for-2.4] vl: Fix compiler warning for builds without VLC
2015-07-23 1:43 ` Wen Congyang
@ 2015-07-23 5:37 ` Paolo Bonzini
-1 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2015-07-23 5:37 UTC (permalink / raw)
To: Wen Congyang, Stefan Weil, QEMU Trivial, Markus Armbruster
Cc: Peter Maydell, QEMU Developer
On 23/07/2015 03:43, Wen Congyang wrote:
> On 07/23/2015 01:53 AM, Stefan Weil wrote:
>> > This regression was caused by commit 70b94331.
> vnc, not vlc in the title.
>
> Reviewed-by: Wen Congyang <wency@cn.fujitsu.com>
>
Thanks, queued for 2.4.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-23 5:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-22 17:53 [Qemu-trivial] [PATCH for-2.4] vl: Fix compiler warning for builds without VLC Stefan Weil
2015-07-22 17:53 ` [Qemu-devel] " Stefan Weil
2015-07-23 1:43 ` [Qemu-trivial] " Wen Congyang
2015-07-23 1:43 ` Wen Congyang
2015-07-23 5:37 ` [Qemu-trivial] " Paolo Bonzini
2015-07-23 5:37 ` [Qemu-devel] " Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.