* [GIT PULL] policycoreutils: fix PEP8 issues
@ 2015-07-17 14:28 Jason Zaman
2015-07-22 13:15 ` Stephen Smalley
0 siblings, 1 reply; 10+ messages in thread
From: Jason Zaman @ 2015-07-17 14:28 UTC (permalink / raw)
To: selinux
The following changes since commit 2202a68d5ac2ac4c8fe05cdea829435efd2ba8e6:
Updated sepolgen ChangeLog. (2015-07-16 13:11:14 -0400)
are available in the git repository at:
https://github.com/perfinion/selinux.git reformat
for you to fetch changes up to 78c977e34c85ff97e236434d90ee9be5ed8ce1d0:
policycoreutils: Fix PEP8 issues (2015-07-17 17:55:28 +0400)
Commit message:
policycoreutils: Fix PEP8 issues
When trying to get policycoreutils working in python3, I kept running
into TabErrors:
Traceback (most recent call last):
File "/usr/lib/python-exec/python3.3/semanage", line 27, in <module>
import seobject
File "/usr/lib64/python3.3/site-packages/seobject.py", line 154
context = "%s%s" % (filler, raw)
^
TabError: inconsistent use of tabs and spaces in indentation
Python3 is a lot stricter than python2 regarding whitespace and looks like
previous commits mixed the two. When fixing this, I took the chance to fix
other PEP8 style issues at the same time.
This commit was made using:
$ file $(find . -type f) | grep -i python > pyfiles
$ autopep8 --in-place --ignore=E501,E265 $(cat pyfiles)
The ignore E501 is long lines since there are many that would be wrapped
otherwise, and E265 is block comments that start with ## instead of just #.
---- ------------------------------------------------------------
Jason Zaman (1):
policycoreutils: Fix PEP8 issues
policycoreutils/audit2allow/audit2allow | 112 ++--
policycoreutils/audit2allow/audit2why | 104 ++--
policycoreutils/audit2allow/sepolgen-ifgen | 14 +-
policycoreutils/audit2allow/test_audit2allow.py | 15 +-
policycoreutils/gui/booleansPage.py | 69 ++-
policycoreutils/gui/domainsPage.py | 24 +-
policycoreutils/gui/fcontextPage.py | 83 +--
policycoreutils/gui/html_util.py | 19 +-
policycoreutils/gui/loginsPage.py | 45 +-
policycoreutils/gui/mappingsPage.py | 6 +-
policycoreutils/gui/modulesPage.py | 33 +-
policycoreutils/gui/polgengui.py | 201 +++----
policycoreutils/gui/portsPage.py | 48 +-
policycoreutils/gui/semanagePage.py | 29 +-
policycoreutils/gui/statusPage.py | 40 +-
policycoreutils/gui/system-config-selinux.py | 33 +-
policycoreutils/gui/usersPage.py | 30 +-
policycoreutils/mcstrans/share/util/mlscolor-test | 18 +-
policycoreutils/mcstrans/share/util/mlstrans-test | 27 +-
policycoreutils/sandbox/sandbox | 592 +++++++++---------
policycoreutils/sandbox/start | 8 +-
policycoreutils/sandbox/test_sandbox.py | 27 +-
policycoreutils/scripts/chcat | 129 ++--
policycoreutils/semanage/semanage | 238 +++++---
policycoreutils/semanage/seobject.py | 4316 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------
policycoreutils/semanage/test-semanage.py | 291 ++++-----
policycoreutils/sepolicy/selinux_client.py | 19 +-
policycoreutils/sepolicy/selinux_server.py | 29 +-
policycoreutils/sepolicy/sepolicy.py | 220 ++++---
policycoreutils/sepolicy/sepolicy/__init__.py | 487 ++++++++-------
policycoreutils/sepolicy/sepolicy/booleans.py | 19 +-
policycoreutils/sepolicy/sepolicy/communicate.py | 21 +-
policycoreutils/sepolicy/sepolicy/generate.py | 2168 +++++++++++++++++++++++++++++++++---------------------------------
policycoreutils/sepolicy/sepolicy/gui.py | 527 ++++++++--------
policycoreutils/sepolicy/sepolicy/interface.py | 49 +-
policycoreutils/sepolicy/sepolicy/manpage.py | 1174 ++++++++++++++++++------------------
policycoreutils/sepolicy/sepolicy/network.py | 33 +-
policycoreutils/sepolicy/sepolicy/sedbus.py | 30 +-
policycoreutils/sepolicy/sepolicy/transition.py | 35 +-
policycoreutils/sepolicy/setup.py | 8 +-
policycoreutils/sepolicy/test_sepolicy.py | 39 +-
41 files changed, 5907 insertions(+), 5502 deletions(-)
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [GIT PULL] policycoreutils: fix PEP8 issues
2015-07-17 14:28 [GIT PULL] policycoreutils: fix PEP8 issues Jason Zaman
@ 2015-07-22 13:15 ` Stephen Smalley
2015-07-22 14:31 ` Jason Zaman
0 siblings, 1 reply; 10+ messages in thread
From: Stephen Smalley @ 2015-07-22 13:15 UTC (permalink / raw)
To: Jason Zaman, selinux, Steve Lawrence
On 07/17/2015 10:28 AM, Jason Zaman wrote:
> The following changes since commit 2202a68d5ac2ac4c8fe05cdea829435efd2ba8e6:
>
> Updated sepolgen ChangeLog. (2015-07-16 13:11:14 -0400)
>
> are available in the git repository at:
>
> https://github.com/perfinion/selinux.git reformat
>
> for you to fetch changes up to 78c977e34c85ff97e236434d90ee9be5ed8ce1d0:
>
> policycoreutils: Fix PEP8 issues (2015-07-17 17:55:28 +0400)
>
> Commit message:
>
> policycoreutils: Fix PEP8 issues
>
> When trying to get policycoreutils working in python3, I kept running
> into TabErrors:
>
> Traceback (most recent call last):
> File "/usr/lib/python-exec/python3.3/semanage", line 27, in <module>
> import seobject
> File "/usr/lib64/python3.3/site-packages/seobject.py", line 154
> context = "%s%s" % (filler, raw)
> ^
> TabError: inconsistent use of tabs and spaces in indentation
>
> Python3 is a lot stricter than python2 regarding whitespace and looks like
> previous commits mixed the two. When fixing this, I took the chance to fix
> other PEP8 style issues at the same time.
>
> This commit was made using:
> $ file $(find . -type f) | grep -i python > pyfiles
> $ autopep8 --in-place --ignore=E501,E265 $(cat pyfiles)
>
> The ignore E501 is long lines since there are many that would be wrapped
> otherwise, and E265 is block comments that start with ## instead of just #.
If this was generated entirely via autopep8, I'd prefer to take this
other patch series first:
http://marc.info/?l=selinux&m=143743932419386&w=2
as it will be easier to redo the autopep8 on top than the other way around.
>
> ---- ------------------------------------------------------------
> Jason Zaman (1):
> policycoreutils: Fix PEP8 issues
>
> policycoreutils/audit2allow/audit2allow | 112 ++--
> policycoreutils/audit2allow/audit2why | 104 ++--
> policycoreutils/audit2allow/sepolgen-ifgen | 14 +-
> policycoreutils/audit2allow/test_audit2allow.py | 15 +-
> policycoreutils/gui/booleansPage.py | 69 ++-
> policycoreutils/gui/domainsPage.py | 24 +-
> policycoreutils/gui/fcontextPage.py | 83 +--
> policycoreutils/gui/html_util.py | 19 +-
> policycoreutils/gui/loginsPage.py | 45 +-
> policycoreutils/gui/mappingsPage.py | 6 +-
> policycoreutils/gui/modulesPage.py | 33 +-
> policycoreutils/gui/polgengui.py | 201 +++----
> policycoreutils/gui/portsPage.py | 48 +-
> policycoreutils/gui/semanagePage.py | 29 +-
> policycoreutils/gui/statusPage.py | 40 +-
> policycoreutils/gui/system-config-selinux.py | 33 +-
> policycoreutils/gui/usersPage.py | 30 +-
> policycoreutils/mcstrans/share/util/mlscolor-test | 18 +-
> policycoreutils/mcstrans/share/util/mlstrans-test | 27 +-
> policycoreutils/sandbox/sandbox | 592 +++++++++---------
> policycoreutils/sandbox/start | 8 +-
> policycoreutils/sandbox/test_sandbox.py | 27 +-
> policycoreutils/scripts/chcat | 129 ++--
> policycoreutils/semanage/semanage | 238 +++++---
> policycoreutils/semanage/seobject.py | 4316 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------
> policycoreutils/semanage/test-semanage.py | 291 ++++-----
> policycoreutils/sepolicy/selinux_client.py | 19 +-
> policycoreutils/sepolicy/selinux_server.py | 29 +-
> policycoreutils/sepolicy/sepolicy.py | 220 ++++---
> policycoreutils/sepolicy/sepolicy/__init__.py | 487 ++++++++-------
> policycoreutils/sepolicy/sepolicy/booleans.py | 19 +-
> policycoreutils/sepolicy/sepolicy/communicate.py | 21 +-
> policycoreutils/sepolicy/sepolicy/generate.py | 2168 +++++++++++++++++++++++++++++++++---------------------------------
> policycoreutils/sepolicy/sepolicy/gui.py | 527 ++++++++--------
> policycoreutils/sepolicy/sepolicy/interface.py | 49 +-
> policycoreutils/sepolicy/sepolicy/manpage.py | 1174 ++++++++++++++++++------------------
> policycoreutils/sepolicy/sepolicy/network.py | 33 +-
> policycoreutils/sepolicy/sepolicy/sedbus.py | 30 +-
> policycoreutils/sepolicy/sepolicy/transition.py | 35 +-
> policycoreutils/sepolicy/setup.py | 8 +-
> policycoreutils/sepolicy/test_sepolicy.py | 39 +-
> 41 files changed, 5907 insertions(+), 5502 deletions(-)
>
> _______________________________________________
> Selinux mailing list
> Selinux@tycho.nsa.gov
> To unsubscribe, send email to Selinux-leave@tycho.nsa.gov.
> To get help, send an email containing "help" to Selinux-request@tycho.nsa.gov.
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] policycoreutils: fix PEP8 issues
2015-07-22 13:15 ` Stephen Smalley
@ 2015-07-22 14:31 ` Jason Zaman
2015-07-22 14:38 ` Stephen Smalley
0 siblings, 1 reply; 10+ messages in thread
From: Jason Zaman @ 2015-07-22 14:31 UTC (permalink / raw)
To: Stephen Smalley; +Cc: selinux
On Wed, Jul 22, 2015 at 09:15:40AM -0400, Stephen Smalley wrote:
> On 07/17/2015 10:28 AM, Jason Zaman wrote:
> > Commit message:
> >
> > policycoreutils: Fix PEP8 issues
> >
> > When trying to get policycoreutils working in python3, I kept running
> > into TabErrors:
> >
> > Traceback (most recent call last):
> > File "/usr/lib/python-exec/python3.3/semanage", line 27, in <module>
> > import seobject
> > File "/usr/lib64/python3.3/site-packages/seobject.py", line 154
> > context = "%s%s" % (filler, raw)
> > ^
> > TabError: inconsistent use of tabs and spaces in indentation
> >
> > Python3 is a lot stricter than python2 regarding whitespace and looks like
> > previous commits mixed the two. When fixing this, I took the chance to fix
> > other PEP8 style issues at the same time.
> >
> > This commit was made using:
> > $ file $(find . -type f) | grep -i python > pyfiles
> > $ autopep8 --in-place --ignore=E501,E265 $(cat pyfiles)
> >
> > The ignore E501 is long lines since there are many that would be wrapped
> > otherwise, and E265 is block comments that start with ## instead of just #.
>
> If this was generated entirely via autopep8, I'd prefer to take this
> other patch series first:
> http://marc.info/?l=selinux&m=143743932419386&w=2
> as it will be easier to redo the autopep8 on top than the other way around.
Yes it was 100% automated, I can re-generate it now that those have been
applied or I can wait till a bit later once the semanage.py fixes are in
or you could just run it yourself and commit it. which would you prefer?
The important part will be to make sure that all commits afterwards are
also following pep8.
-- Jason
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] policycoreutils: fix PEP8 issues
2015-07-22 14:31 ` Jason Zaman
@ 2015-07-22 14:38 ` Stephen Smalley
2015-07-23 7:14 ` Petr Lautrbach
0 siblings, 1 reply; 10+ messages in thread
From: Stephen Smalley @ 2015-07-22 14:38 UTC (permalink / raw)
To: Jason Zaman; +Cc: selinux
On 07/22/2015 10:31 AM, Jason Zaman wrote:
> On Wed, Jul 22, 2015 at 09:15:40AM -0400, Stephen Smalley wrote:
>> On 07/17/2015 10:28 AM, Jason Zaman wrote:
>>> Commit message:
>>>
>>> policycoreutils: Fix PEP8 issues
>>>
>>> When trying to get policycoreutils working in python3, I kept running
>>> into TabErrors:
>>>
>>> Traceback (most recent call last):
>>> File "/usr/lib/python-exec/python3.3/semanage", line 27, in <module>
>>> import seobject
>>> File "/usr/lib64/python3.3/site-packages/seobject.py", line 154
>>> context = "%s%s" % (filler, raw)
>>> ^
>>> TabError: inconsistent use of tabs and spaces in indentation
>>>
>>> Python3 is a lot stricter than python2 regarding whitespace and looks like
>>> previous commits mixed the two. When fixing this, I took the chance to fix
>>> other PEP8 style issues at the same time.
>>>
>>> This commit was made using:
>>> $ file $(find . -type f) | grep -i python > pyfiles
>>> $ autopep8 --in-place --ignore=E501,E265 $(cat pyfiles)
>>>
>>> The ignore E501 is long lines since there are many that would be wrapped
>>> otherwise, and E265 is block comments that start with ## instead of just #.
>>
>> If this was generated entirely via autopep8, I'd prefer to take this
>> other patch series first:
>> http://marc.info/?l=selinux&m=143743932419386&w=2
>> as it will be easier to redo the autopep8 on top than the other way around.
>
> Yes it was 100% automated, I can re-generate it now that those have been
> applied or I can wait till a bit later once the semanage.py fixes are in
> or you could just run it yourself and commit it. which would you prefer?
>
> The important part will be to make sure that all commits afterwards are
> also following pep8.
I'll ask if Red Hat has any other patches they care to submit for
policycoreutils python code before performing the conversion.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] policycoreutils: fix PEP8 issues
2015-07-22 14:38 ` Stephen Smalley
@ 2015-07-23 7:14 ` Petr Lautrbach
2015-07-24 7:43 ` Petr Lautrbach
0 siblings, 1 reply; 10+ messages in thread
From: Petr Lautrbach @ 2015-07-23 7:14 UTC (permalink / raw)
To: selinux
[-- Attachment #1: Type: text/plain, Size: 2523 bytes --]
On 07/22/2015 04:38 PM, Stephen Smalley wrote:
> On 07/22/2015 10:31 AM, Jason Zaman wrote:
>> On Wed, Jul 22, 2015 at 09:15:40AM -0400, Stephen Smalley wrote:
>>> On 07/17/2015 10:28 AM, Jason Zaman wrote:
>>>> Commit message:
>>>>
>>>> policycoreutils: Fix PEP8 issues
>>>>
>>>> When trying to get policycoreutils working in python3, I kept running
>>>> into TabErrors:
>>>>
>>>> Traceback (most recent call last):
>>>> File "/usr/lib/python-exec/python3.3/semanage", line 27, in <module>
>>>> import seobject
>>>> File "/usr/lib64/python3.3/site-packages/seobject.py", line 154
>>>> context = "%s%s" % (filler, raw)
>>>> ^
>>>> TabError: inconsistent use of tabs and spaces in indentation
>>>>
>>>> Python3 is a lot stricter than python2 regarding whitespace and looks like
>>>> previous commits mixed the two. When fixing this, I took the chance to fix
>>>> other PEP8 style issues at the same time.
>>>>
>>>> This commit was made using:
>>>> $ file $(find . -type f) | grep -i python > pyfiles
>>>> $ autopep8 --in-place --ignore=E501,E265 $(cat pyfiles)
>>>>
>>>> The ignore E501 is long lines since there are many that would be wrapped
>>>> otherwise, and E265 is block comments that start with ## instead of just #.
>>>
>>> If this was generated entirely via autopep8, I'd prefer to take this
>>> other patch series first:
>>> http://marc.info/?l=selinux&m=143743932419386&w=2
>>> as it will be easier to redo the autopep8 on top than the other way around.
>>
>> Yes it was 100% automated, I can re-generate it now that those have been
>> applied or I can wait till a bit later once the semanage.py fixes are in
>> or you could just run it yourself and commit it. which would you prefer?
>>
>> The important part will be to make sure that all commits afterwards are
>> also following pep8.
>
> I'll ask if Red Hat has any other patches they care to submit for
> policycoreutils python code before performing the conversion.
>
>
I'm just looking into it.
From the top of my head there should be only one other patch in Fedora
which makes a python module seobject/__init__.py from seobject.py for
python3. Other changes are either indentation fixes or should be already
covered by patches sent by my colleagues few days ago.
I hope I'll provide a relevant patch set today.
Petr
--
Petr Lautrbach
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] policycoreutils: fix PEP8 issues
2015-07-23 7:14 ` Petr Lautrbach
@ 2015-07-24 7:43 ` Petr Lautrbach
2015-07-24 8:13 ` Jason Zaman
0 siblings, 1 reply; 10+ messages in thread
From: Petr Lautrbach @ 2015-07-24 7:43 UTC (permalink / raw)
To: selinux
[-- Attachment #1: Type: text/plain, Size: 2858 bytes --]
On 07/23/2015 09:14 AM, Petr Lautrbach wrote:
> On 07/22/2015 04:38 PM, Stephen Smalley wrote:
>> On 07/22/2015 10:31 AM, Jason Zaman wrote:
>>> On Wed, Jul 22, 2015 at 09:15:40AM -0400, Stephen Smalley wrote:
>>>> On 07/17/2015 10:28 AM, Jason Zaman wrote:
>>>>> Commit message:
>>>>>
>>>>> policycoreutils: Fix PEP8 issues
>>>>>
>>>>> When trying to get policycoreutils working in python3, I kept running
>>>>> into TabErrors:
>>>>>
>>>>> Traceback (most recent call last):
>>>>> File "/usr/lib/python-exec/python3.3/semanage", line 27, in <module>
>>>>> import seobject
>>>>> File "/usr/lib64/python3.3/site-packages/seobject.py", line 154
>>>>> context = "%s%s" % (filler, raw)
>>>>> ^
>>>>> TabError: inconsistent use of tabs and spaces in indentation
>>>>>
>>>>> Python3 is a lot stricter than python2 regarding whitespace and looks like
>>>>> previous commits mixed the two. When fixing this, I took the chance to fix
>>>>> other PEP8 style issues at the same time.
>>>>>
>>>>> This commit was made using:
>>>>> $ file $(find . -type f) | grep -i python > pyfiles
>>>>> $ autopep8 --in-place --ignore=E501,E265 $(cat pyfiles)
>>>>>
>>>>> The ignore E501 is long lines since there are many that would be wrapped
>>>>> otherwise, and E265 is block comments that start with ## instead of just #.
>>>>
>>>> If this was generated entirely via autopep8, I'd prefer to take this
>>>> other patch series first:
>>>> http://marc.info/?l=selinux&m=143743932419386&w=2
>>>> as it will be easier to redo the autopep8 on top than the other way around.
>>>
>>> Yes it was 100% automated, I can re-generate it now that those have been
>>> applied or I can wait till a bit later once the semanage.py fixes are in
>>> or you could just run it yourself and commit it. which would you prefer?
>>>
>>> The important part will be to make sure that all commits afterwards are
>>> also following pep8.
>>
>> I'll ask if Red Hat has any other patches they care to submit for
>> policycoreutils python code before performing the conversion.
>>
>>
>
> I'm just looking into it.
>
> From the top of my head there should be only one other patch in Fedora
> which makes a python module seobject/__init__.py from seobject.py for
> python3. Other changes are either indentation fixes or should be already
> covered by patches sent by my colleagues few days ago.
>
> I hope I'll provide a relevant patch set today.
It seems that there's only seobject.py which needs to be ported to
python 3. I would start with the indent conversion as it's needed anyway
and then we could provide a patch with python 3 support based on this
conversion.
Petr
--
Petr Lautrbach
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] policycoreutils: fix PEP8 issues
2015-07-24 7:43 ` Petr Lautrbach
@ 2015-07-24 8:13 ` Jason Zaman
2015-07-24 8:35 ` Jason Zaman
2015-07-24 13:06 ` Stephen Smalley
0 siblings, 2 replies; 10+ messages in thread
From: Jason Zaman @ 2015-07-24 8:13 UTC (permalink / raw)
To: Petr Lautrbach, Stephen Smalley; +Cc: selinux
On Fri, Jul 24, 2015 at 09:43:42AM +0200, Petr Lautrbach wrote:
> It seems that there's only seobject.py which needs to be ported to
> python 3. I would start with the indent conversion as it's needed anyway
> and then we could provide a patch with python 3 support based on this
> conversion.
The following changes since commit d19cda0c80524b57464b3bb74dce1297d017b4b1:
Updated libsepol ChangeLog (2015-07-22 11:02:32 -0400)
are available in the git repository at:
https://github.com/perfinion/selinux.git reformat
for you to fetch changes up to 789d0ebbf9fa448b09917ccd0adff91d72e9f5c1:
policycoreutils: Fix PEP8 issues (2015-07-24 16:07:13 +0800)
----------------------------------------------------------------
Jason Zaman (1):
policycoreutils: Fix PEP8 issues
I re-did the changes on top of the current master and updated that
branch. this is the new commit to pull.
All the files now follow PEP8 style (ie tabs are 4 spaces) so future
commits should follow that too.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [GIT PULL] policycoreutils: fix PEP8 issues
2015-07-24 8:13 ` Jason Zaman
@ 2015-07-24 8:35 ` Jason Zaman
2015-07-24 13:09 ` Stephen Smalley
2015-07-24 13:06 ` Stephen Smalley
1 sibling, 1 reply; 10+ messages in thread
From: Jason Zaman @ 2015-07-24 8:35 UTC (permalink / raw)
To: Petr Lautrbach; +Cc: selinux
On Fri, Jul 24, 2015 at 04:13:44PM +0800, Jason Zaman wrote:
> On Fri, Jul 24, 2015 at 09:43:42AM +0200, Petr Lautrbach wrote:
> > It seems that there's only seobject.py which needs to be ported to
> > python 3. I would start with the indent conversion as it's needed anyway
> > and then we could provide a patch with python 3 support based on this
> > conversion.
>
> The following changes since commit d19cda0c80524b57464b3bb74dce1297d017b4b1:
>
> Updated libsepol ChangeLog (2015-07-22 11:02:32 -0400)
>
> are available in the git repository at:
>
> https://github.com/perfinion/selinux.git reformat
>
> for you to fetch changes up to 789d0ebbf9fa448b09917ccd0adff91d72e9f5c1:
>
> policycoreutils: Fix PEP8 issues (2015-07-24 16:07:13 +0800)
>
> ----------------------------------------------------------------
> Jason Zaman (1):
> policycoreutils: Fix PEP8 issues
>
>
> I re-did the changes on top of the current master and updated that
> branch. this is the new commit to pull.
>
> All the files now follow PEP8 style (ie tabs are 4 spaces) so future
> commits should follow that too.
After seobject.py is converted, I see a few issues with
policycoreutils/sepolicy/sepolicy/*.
The easy stuff 2to3 handles, but it looks like there will need to be
some changes to the C module, I've got it building by adding some
#defines for PyInt_AsLong and the like. I am not that familiar with the
C-Python stuff so it might not be done the right way.
-- Jason
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] policycoreutils: fix PEP8 issues
2015-07-24 8:35 ` Jason Zaman
@ 2015-07-24 13:09 ` Stephen Smalley
0 siblings, 0 replies; 10+ messages in thread
From: Stephen Smalley @ 2015-07-24 13:09 UTC (permalink / raw)
To: Jason Zaman, Petr Lautrbach; +Cc: selinux
On 07/24/2015 04:35 AM, Jason Zaman wrote:
> On Fri, Jul 24, 2015 at 04:13:44PM +0800, Jason Zaman wrote:
>> On Fri, Jul 24, 2015 at 09:43:42AM +0200, Petr Lautrbach wrote:
>>> It seems that there's only seobject.py which needs to be ported to
>>> python 3. I would start with the indent conversion as it's needed anyway
>>> and then we could provide a patch with python 3 support based on this
>>> conversion.
>>
>> The following changes since commit d19cda0c80524b57464b3bb74dce1297d017b4b1:
>>
>> Updated libsepol ChangeLog (2015-07-22 11:02:32 -0400)
>>
>> are available in the git repository at:
>>
>> https://github.com/perfinion/selinux.git reformat
>>
>> for you to fetch changes up to 789d0ebbf9fa448b09917ccd0adff91d72e9f5c1:
>>
>> policycoreutils: Fix PEP8 issues (2015-07-24 16:07:13 +0800)
>>
>> ----------------------------------------------------------------
>> Jason Zaman (1):
>> policycoreutils: Fix PEP8 issues
>>
>>
>> I re-did the changes on top of the current master and updated that
>> branch. this is the new commit to pull.
>>
>> All the files now follow PEP8 style (ie tabs are 4 spaces) so future
>> commits should follow that too.
>
> After seobject.py is converted, I see a few issues with
> policycoreutils/sepolicy/sepolicy/*.
>
> The easy stuff 2to3 handles, but it looks like there will need to be
> some changes to the C module, I've got it building by adding some
> #defines for PyInt_AsLong and the like. I am not that familiar with the
> C-Python stuff so it might not be done the right way.
On this, we would prefer to see policycoreutils/sepolicy converted to
use setools4, which directly provides python interfaces, no C extension
required. setools3 is no longer maintained.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [GIT PULL] policycoreutils: fix PEP8 issues
2015-07-24 8:13 ` Jason Zaman
2015-07-24 8:35 ` Jason Zaman
@ 2015-07-24 13:06 ` Stephen Smalley
1 sibling, 0 replies; 10+ messages in thread
From: Stephen Smalley @ 2015-07-24 13:06 UTC (permalink / raw)
To: Jason Zaman, Petr Lautrbach; +Cc: selinux
On 07/24/2015 04:13 AM, Jason Zaman wrote:
> On Fri, Jul 24, 2015 at 09:43:42AM +0200, Petr Lautrbach wrote:
>> It seems that there's only seobject.py which needs to be ported to
>> python 3. I would start with the indent conversion as it's needed anyway
>> and then we could provide a patch with python 3 support based on this
>> conversion.
>
> The following changes since commit d19cda0c80524b57464b3bb74dce1297d017b4b1:
>
> Updated libsepol ChangeLog (2015-07-22 11:02:32 -0400)
>
> are available in the git repository at:
>
> https://github.com/perfinion/selinux.git reformat
>
> for you to fetch changes up to 789d0ebbf9fa448b09917ccd0adff91d72e9f5c1:
>
> policycoreutils: Fix PEP8 issues (2015-07-24 16:07:13 +0800)
>
> ----------------------------------------------------------------
> Jason Zaman (1):
> policycoreutils: Fix PEP8 issues
>
>
> I re-did the changes on top of the current master and updated that
> branch. this is the new commit to pull.
>
> All the files now follow PEP8 style (ie tabs are 4 spaces) so future
> commits should follow that too.
Thanks, pulled.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-07-24 13:09 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-17 14:28 [GIT PULL] policycoreutils: fix PEP8 issues Jason Zaman
2015-07-22 13:15 ` Stephen Smalley
2015-07-22 14:31 ` Jason Zaman
2015-07-22 14:38 ` Stephen Smalley
2015-07-23 7:14 ` Petr Lautrbach
2015-07-24 7:43 ` Petr Lautrbach
2015-07-24 8:13 ` Jason Zaman
2015-07-24 8:35 ` Jason Zaman
2015-07-24 13:09 ` Stephen Smalley
2015-07-24 13:06 ` Stephen Smalley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.