All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Harini Katakam <harini.katakam@xilinx.com>,
	davem@davemloft.net, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, boris.brezillon@free-electrons.com,
	alexandre.belloni@free-electrons.com,
	harinikatakamlinux@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, harinik@xilinx.com,
	punnaia@xilinx.com, michals@xilinx.com
Subject: Re: [NET-NEXT PATCH] net: macb: Change capability mask for jumbo support
Date: Thu, 23 Jul 2015 14:34:55 +0200	[thread overview]
Message-ID: <55B0DF6F.9050002@atmel.com> (raw)
In-Reply-To: <1437646465-6462-1-git-send-email-harinik@xilinx.com>

Le 23/07/2015 12:14, Harini Katakam a écrit :
> JUMBO and NO_GIGABIT_HALF have the same capability masks.
> Change one of them.
> 
> Signed-off-by: Harini Katakam <harinik@xilinx.com>

Yes, indeed:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
>  drivers/net/ethernet/cadence/macb.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
> index d746559..8fb80b2 100644
> --- a/drivers/net/ethernet/cadence/macb.h
> +++ b/drivers/net/ethernet/cadence/macb.h
> @@ -399,7 +399,7 @@
>  #define MACB_CAPS_GIGABIT_MODE_AVAILABLE	0x20000000
>  #define MACB_CAPS_SG_DISABLED			0x40000000
>  #define MACB_CAPS_MACB_IS_GEM			0x80000000
> -#define MACB_CAPS_JUMBO				0x00000008
> +#define MACB_CAPS_JUMBO				0x00000010
>  
>  /* Bit manipulation macros */
>  #define MACB_BIT(name)					\
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Harini Katakam <harini.katakam@xilinx.com>, <davem@davemloft.net>,
	<robh+dt@kernel.org>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<galak@codeaurora.org>, <boris.brezillon@free-electrons.com>,
	<alexandre.belloni@free-electrons.com>,
	<harinikatakamlinux@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <harinik@xilinx.com>,
	<punnaia@xilinx.com>, <michals@xilinx.com>
Subject: Re: [NET-NEXT PATCH] net: macb: Change capability mask for jumbo support
Date: Thu, 23 Jul 2015 14:34:55 +0200	[thread overview]
Message-ID: <55B0DF6F.9050002@atmel.com> (raw)
In-Reply-To: <1437646465-6462-1-git-send-email-harinik@xilinx.com>

Le 23/07/2015 12:14, Harini Katakam a écrit :
> JUMBO and NO_GIGABIT_HALF have the same capability masks.
> Change one of them.
> 
> Signed-off-by: Harini Katakam <harinik@xilinx.com>

Yes, indeed:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
>  drivers/net/ethernet/cadence/macb.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
> index d746559..8fb80b2 100644
> --- a/drivers/net/ethernet/cadence/macb.h
> +++ b/drivers/net/ethernet/cadence/macb.h
> @@ -399,7 +399,7 @@
>  #define MACB_CAPS_GIGABIT_MODE_AVAILABLE	0x20000000
>  #define MACB_CAPS_SG_DISABLED			0x40000000
>  #define MACB_CAPS_MACB_IS_GEM			0x80000000
> -#define MACB_CAPS_JUMBO				0x00000008
> +#define MACB_CAPS_JUMBO				0x00000010
>  
>  /* Bit manipulation macros */
>  #define MACB_BIT(name)					\
> 


-- 
Nicolas Ferre

  reply	other threads:[~2015-07-23 12:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 10:14 [NET-NEXT PATCH] net: macb: Change capability mask for jumbo support Harini Katakam
2015-07-23 10:14 ` Harini Katakam
2015-07-23 12:34 ` Nicolas Ferre [this message]
2015-07-23 12:34   ` Nicolas Ferre
2015-07-23 12:42 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B0DF6F.9050002@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=harini.katakam@xilinx.com \
    --cc=harinik@xilinx.com \
    --cc=harinikatakamlinux@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michals@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=punnaia@xilinx.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.