From: labbott@redhat.com (Laura Abbott)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] arm64:use set_fixmap_offset to make it more clear
Date: Thu, 23 Jul 2015 08:29:14 -0700 [thread overview]
Message-ID: <55B1084A.5020303@redhat.com> (raw)
In-Reply-To: <A5D61263-B664-469F-9F49-160D6E17F432@gmail.com>
On 07/23/2015 04:45 AM, yalin wang wrote:
> A little change to patch_map() function,
> use set_fixmap_offset() to make code more clear.
>
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
> arch/arm64/kernel/insn.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c
> index dd9671c..7dafd5a 100644
> --- a/arch/arm64/kernel/insn.c
> +++ b/arch/arm64/kernel/insn.c
> @@ -101,9 +101,8 @@ static void __kprobes *patch_map(void *addr, int fixmap)
> return addr;
>
> BUG_ON(!page);
> - set_fixmap(fixmap, page_to_phys(page));
> -
> - return (void *) (__fix_to_virt(fixmap) + (uintaddr & ~PAGE_MASK));
> + return (void *)set_fixmap_offset(fixmap, page_to_phys(page) +
> + (addr & ~PAGE_MASK));
> }
>
> static void __kprobes patch_unmap(int fixmap)
>
Reviewed-by: Laura Abbott <labbott@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Laura Abbott <labbott@redhat.com>
To: yalin wang <yalin.wang2010@gmail.com>,
catalin.marinas@arm.com, will.deacon@arm.com, zlim.lnx@gmail.com,
punit.agrawal@arm.com, marc.zyngier@arm.com,
lauraa@codeaurora.org, wcohen@redhat.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] arm64:use set_fixmap_offset to make it more clear
Date: Thu, 23 Jul 2015 08:29:14 -0700 [thread overview]
Message-ID: <55B1084A.5020303@redhat.com> (raw)
In-Reply-To: <A5D61263-B664-469F-9F49-160D6E17F432@gmail.com>
On 07/23/2015 04:45 AM, yalin wang wrote:
> A little change to patch_map() function,
> use set_fixmap_offset() to make code more clear.
>
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
> arch/arm64/kernel/insn.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c
> index dd9671c..7dafd5a 100644
> --- a/arch/arm64/kernel/insn.c
> +++ b/arch/arm64/kernel/insn.c
> @@ -101,9 +101,8 @@ static void __kprobes *patch_map(void *addr, int fixmap)
> return addr;
>
> BUG_ON(!page);
> - set_fixmap(fixmap, page_to_phys(page));
> -
> - return (void *) (__fix_to_virt(fixmap) + (uintaddr & ~PAGE_MASK));
> + return (void *)set_fixmap_offset(fixmap, page_to_phys(page) +
> + (addr & ~PAGE_MASK));
> }
>
> static void __kprobes patch_unmap(int fixmap)
>
Reviewed-by: Laura Abbott <labbott@redhat.com>
next prev parent reply other threads:[~2015-07-23 15:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 11:45 [RFC] arm64:use set_fixmap_offset to make it more clear yalin wang
2015-07-23 11:45 ` yalin wang
2015-07-23 13:03 ` Catalin Marinas
2015-07-23 13:03 ` Catalin Marinas
2015-07-24 3:56 ` yalin wang
2015-07-24 3:56 ` yalin wang
2015-07-24 9:56 ` Mark Rutland
2015-07-24 9:56 ` Mark Rutland
2015-07-24 10:07 ` Mark Rutland
2015-07-24 10:07 ` Mark Rutland
2015-07-24 11:53 ` yalin wang
2015-07-24 11:53 ` yalin wang
2015-07-23 15:29 ` Laura Abbott [this message]
2015-07-23 15:29 ` Laura Abbott
2015-07-24 11:52 ` [RFC V2] " yalin wang
2015-07-28 6:31 ` yalin wang
2015-07-28 6:31 ` yalin wang
2015-07-28 8:47 ` Will Deacon
2015-07-28 8:47 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B1084A.5020303@redhat.com \
--to=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.