[PATCH] tools: iio: make scale and offset files optional

[PATCH] tools: iio: make scale and offset files optional

[Joo Aun Saw]

From: Joo Aun Saw <jasaw@dius.com.au>

Make scale and offset optional by adding -ENOENT check as not all
drivers implement them.

Signed-off-by: Joo Aun Saw <jasaw@dius.com.au>
---
 tools/iio/iio_utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/iio/iio_utils.c b/tools/iio/iio_utils.c
index c3f9e37..1dcdf03 100644
--- a/tools/iio/iio_utils.c
+++ b/tools/iio/iio_utils.c
@@ -487,7 +487,7 @@ int build_channel_array(const char *device_dir,
 						       device_dir,
 						       current->name,
 						       current->generic_name);
-			if (ret < 0)
+			if ((ret < 0) && (ret != -ENOENT))
 				goto error_cleanup_array;
 
 			ret = iioutils_get_param_float(&current->offset,
@@ -495,7 +495,7 @@ int build_channel_array(const char *device_dir,
 						       device_dir,
 						       current->name,
 						       current->generic_name);
-			if (ret < 0)
+			if ((ret < 0) && (ret != -ENOENT))
 				goto error_cleanup_array;
 
 			ret = iioutils_get_type(&current->is_signed,
-- 
1.9.1

Re: [PATCH] tools: iio: make scale and offset files optional

[Hartmut Knaack]

Joo Aun Saw schrieb am 23.07.2015 um 04:53:
> From: Joo Aun Saw <jasaw@dius.com.au>
> 
> Make scale and offset optional by adding -ENOENT check as not all
> drivers implement them.
> 
> Signed-off-by: Joo Aun Saw <jasaw@dius.com.au>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>
> ---
>  tools/iio/iio_utils.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/iio/iio_utils.c b/tools/iio/iio_utils.c
> index c3f9e37..1dcdf03 100644
> --- a/tools/iio/iio_utils.c
> +++ b/tools/iio/iio_utils.c
> @@ -487,7 +487,7 @@ int build_channel_array(const char *device_dir,
>  						       device_dir,
>  						       current->name,
>  						       current->generic_name);
> -			if (ret < 0)
> +			if ((ret < 0) && (ret != -ENOENT))
>  				goto error_cleanup_array;
>  
>  			ret = iioutils_get_param_float(&current->offset,
> @@ -495,7 +495,7 @@ int build_channel_array(const char *device_dir,
>  						       device_dir,
>  						       current->name,
>  						       current->generic_name);
> -			if (ret < 0)
> +			if ((ret < 0) && (ret != -ENOENT))
>  				goto error_cleanup_array;
>  
>  			ret = iioutils_get_type(&current->is_signed,
> 

Re: [PATCH] tools: iio: make scale and offset files optional

[Jonathan Cameron]

On 23/07/15 20:28, Hartmut Knaack wrote:
> Joo Aun Saw schrieb am 23.07.2015 um 04:53:
>> From: Joo Aun Saw <jasaw@dius.com.au>
>>
>> Make scale and offset optional by adding -ENOENT check as not all
>> drivers implement them.
>>
>> Signed-off-by: Joo Aun Saw <jasaw@dius.com.au>
> Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Thanks.  Applied to the togreg branch of iio.git - initially
pushed out as testing (in this case to be completely ignored
- I think - but there we are ;)

Jonathan
>> ---
>>  tools/iio/iio_utils.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/iio/iio_utils.c b/tools/iio/iio_utils.c
>> index c3f9e37..1dcdf03 100644
>> --- a/tools/iio/iio_utils.c
>> +++ b/tools/iio/iio_utils.c
>> @@ -487,7 +487,7 @@ int build_channel_array(const char *device_dir,
>>  						       device_dir,
>>  						       current->name,
>>  						       current->generic_name);
>> -			if (ret < 0)
>> +			if ((ret < 0) && (ret != -ENOENT))
>>  				goto error_cleanup_array;
>>  
>>  			ret = iioutils_get_param_float(&current->offset,
>> @@ -495,7 +495,7 @@ int build_channel_array(const char *device_dir,
>>  						       device_dir,
>>  						       current->name,
>>  						       current->generic_name);
>> -			if (ret < 0)
>> +			if ((ret < 0) && (ret != -ENOENT))
>>  				goto error_cleanup_array;
>>  
>>  			ret = iioutils_get_type(&current->is_signed,
>>
>