From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 1/3] docs: dts: Added documentation for Xilinx Zynq PL Reset bindings.
Date: Fri, 24 Jul 2015 09:27:53 +0200 [thread overview]
Message-ID: <55B1E8F9.6060704@xilinx.com> (raw)
In-Reply-To: <1437722723.3834.3.camel@pengutronix.de>
On 07/24/2015 09:25 AM, Philipp Zabel wrote:
> Am Donnerstag, den 23.07.2015, 15:51 -0700 schrieb Moritz Fischer:
>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
>> ---
>> Documentation/devicetree/bindings/reset/zynq-reset-pl.txt | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
>>
>> diff --git a/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
>> new file mode 100644
>> index 0000000..ac4499e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
>> @@ -0,0 +1,13 @@
>> +Xilinx Zynq PL Reset Manager
>> +
>> +Required properties:
>> +- compatible: "xlnx,zynq-reset-pl"
>> +- syscon <&slcr>;
>> +- #reset-cells: 1
>> +
>> +Example:
>> + rstc: rstc at 240 {
>> + #reset-cells = <1>;
>> + compatible = "xlnx,zynq-reset-pl";
>> + syscon = <&slcr>;
>> + };
>
> Instead of the syscon property, why not specify that the rstc node must
> be a child of the slcr node?
FYI: It is already a child node of SLCR if you look at location in DTS.
Thanks,
Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Moritz Fischer <moritz.fischer@ettus.com>
Cc: <michal.simek@xilinx.com>, <soren.brinkmann@xilinx.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC 1/3] docs: dts: Added documentation for Xilinx Zynq PL Reset bindings.
Date: Fri, 24 Jul 2015 09:27:53 +0200 [thread overview]
Message-ID: <55B1E8F9.6060704@xilinx.com> (raw)
In-Reply-To: <1437722723.3834.3.camel@pengutronix.de>
On 07/24/2015 09:25 AM, Philipp Zabel wrote:
> Am Donnerstag, den 23.07.2015, 15:51 -0700 schrieb Moritz Fischer:
>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
>> ---
>> Documentation/devicetree/bindings/reset/zynq-reset-pl.txt | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
>>
>> diff --git a/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
>> new file mode 100644
>> index 0000000..ac4499e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/reset/zynq-reset-pl.txt
>> @@ -0,0 +1,13 @@
>> +Xilinx Zynq PL Reset Manager
>> +
>> +Required properties:
>> +- compatible: "xlnx,zynq-reset-pl"
>> +- syscon <&slcr>;
>> +- #reset-cells: 1
>> +
>> +Example:
>> + rstc: rstc@240 {
>> + #reset-cells = <1>;
>> + compatible = "xlnx,zynq-reset-pl";
>> + syscon = <&slcr>;
>> + };
>
> Instead of the syscon property, why not specify that the rstc node must
> be a child of the slcr node?
FYI: It is already a child node of SLCR if you look at location in DTS.
Thanks,
Michal
next prev parent reply other threads:[~2015-07-24 7:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 22:50 [RFC 0/3] Adding support for Zynq PL reset controller Moritz Fischer
2015-07-23 22:50 ` Moritz Fischer
2015-07-23 22:51 ` [RFC 1/3] docs: dts: Added documentation for Xilinx Zynq PL Reset bindings Moritz Fischer
2015-07-23 22:51 ` Moritz Fischer
2015-07-24 4:40 ` Michal Simek
2015-07-24 4:40 ` Michal Simek
2015-07-24 14:50 ` Sören Brinkmann
2015-07-24 14:50 ` Sören Brinkmann
2015-07-24 20:29 ` Moritz Fischer
2015-07-24 20:29 ` Moritz Fischer
2015-07-24 7:25 ` Philipp Zabel
2015-07-24 7:25 ` Philipp Zabel
2015-07-24 7:27 ` Michal Simek [this message]
2015-07-24 7:27 ` Michal Simek
2015-07-23 22:51 ` [RFC 2/3] dts: zynq: Add devicetree entry for PL reset controller Moritz Fischer
2015-07-23 22:51 ` Moritz Fischer
2015-07-23 22:51 ` [RFC 3/3] reset: reset-zynq-pl: Adding support for Xilinx Zynq PL reset Moritz Fischer
2015-07-23 22:51 ` Moritz Fischer
2015-07-24 16:19 ` Sören Brinkmann
2015-07-24 16:19 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B1E8F9.6060704@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.