* [Qemu-trivial] [PATCH] gdbstub: Set current CPU on interruptions
@ 2015-07-24 16:52 ` Jan Kiszka
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2015-07-24 16:52 UTC (permalink / raw)
To: qemu-trivial; +Cc: qemu-devel
gdb expects that the thread ID for c and g-class operations is set to
the CPU we provide when reporting VM stop conditions. If the stub is
still tuned to a different CPU, the wrong information is delivered to
the gdb frontend.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
gdbstub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdbstub.c b/gdbstub.c
index 92b2f81..ffe7e6e 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1285,6 +1285,7 @@ static void gdb_vm_state_change(void *opaque, int running, RunState state)
ret = GDB_SIGNAL_UNKNOWN;
break;
}
+ gdb_set_stop_cpu(cpu);
snprintf(buf, sizeof(buf), "T%02xthread:%02x;", ret, cpu_index(cpu));
send_packet:
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] gdbstub: Set current CPU on interruptions
@ 2015-07-24 16:52 ` Jan Kiszka
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2015-07-24 16:52 UTC (permalink / raw)
To: qemu-trivial; +Cc: qemu-devel
gdb expects that the thread ID for c and g-class operations is set to
the CPU we provide when reporting VM stop conditions. If the stub is
still tuned to a different CPU, the wrong information is delivered to
the gdb frontend.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
gdbstub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdbstub.c b/gdbstub.c
index 92b2f81..ffe7e6e 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1285,6 +1285,7 @@ static void gdb_vm_state_change(void *opaque, int running, RunState state)
ret = GDB_SIGNAL_UNKNOWN;
break;
}
+ gdb_set_stop_cpu(cpu);
snprintf(buf, sizeof(buf), "T%02xthread:%02x;", ret, cpu_index(cpu));
send_packet:
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [PATCH] gdbstub: Set current CPU on interruptions
2015-07-24 16:52 ` [Qemu-devel] " Jan Kiszka
@ 2015-07-27 19:46 ` Michael Tokarev
-1 siblings, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2015-07-27 19:46 UTC (permalink / raw)
To: Jan Kiszka, qemu-trivial; +Cc: qemu-devel
24.07.2015 19:52, Jan Kiszka wrote:
> gdb expects that the thread ID for c and g-class operations is set to
> the CPU we provide when reporting VM stop conditions. If the stub is
> still tuned to a different CPU, the wrong information is delivered to
> the gdb frontend.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-27 19:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-24 16:52 [Qemu-trivial] [PATCH] gdbstub: Set current CPU on interruptions Jan Kiszka
2015-07-24 16:52 ` [Qemu-devel] " Jan Kiszka
2015-07-27 19:46 ` [Qemu-trivial] " Michael Tokarev
2015-07-27 19:46 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.