From: "long.wanglong" <long.wanglong@huawei.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
peifeiyue@huawei.com, wanglong@laoqinren.net
Subject: Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn
Date: Mon, 27 Jul 2015 09:47:56 +0800 [thread overview]
Message-ID: <55B58DCC.6080208@huawei.com> (raw)
In-Reply-To: <CAL_JsqKQ5y_iNezoTOty3ogC9Gmv4728Vf-BfoufN58u10vW7Q@mail.gmail.com>
On 2015/7/27 4:39, Rob Herring wrote:
> On Fri, Jul 24, 2015 at 7:57 PM, long.wanglong <long.wanglong@huawei.com> wrote:
>> On 2015/7/25 3:00, Rob Herring wrote:
>>> On Tue, Jul 21, 2015 at 3:01 AM, Wang Long <long.wanglong@huawei.com> wrote:
>>>> Update the last pr_warning callsite in drivers/of.
>>>
>>> That is obvious in the diff, but can you tell me why?
>>
>> Hi Rob,
>>
>> When we use script "./scripts/checkpatch.pl" to check a patch, using pr_warning
>> will produce WARNING:
>>
>> WARNING: Prefer pr_warn(... to pr_warning(...
>> #22: FILE: drivers/of/fdt.c:428:
>> + pr_warning("End of tree marker overwritten: %08x\n",
>>
>> So,we should convert pr_warning to pr_warn.
>
> Okay, but don't explain to me. Explain this in the commit message.
>
> Rob
>
>
OK, i will send another patch and explain this in the commit message.
Wang Long
WARNING: multiple messages have this Message-ID (diff)
From: "long.wanglong" <long.wanglong@huawei.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<peifeiyue@huawei.com>, <wanglong@laoqinren.net>
Subject: Re: [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn
Date: Mon, 27 Jul 2015 09:47:56 +0800 [thread overview]
Message-ID: <55B58DCC.6080208@huawei.com> (raw)
In-Reply-To: <CAL_JsqKQ5y_iNezoTOty3ogC9Gmv4728Vf-BfoufN58u10vW7Q@mail.gmail.com>
On 2015/7/27 4:39, Rob Herring wrote:
> On Fri, Jul 24, 2015 at 7:57 PM, long.wanglong <long.wanglong@huawei.com> wrote:
>> On 2015/7/25 3:00, Rob Herring wrote:
>>> On Tue, Jul 21, 2015 at 3:01 AM, Wang Long <long.wanglong@huawei.com> wrote:
>>>> Update the last pr_warning callsite in drivers/of.
>>>
>>> That is obvious in the diff, but can you tell me why?
>>
>> Hi Rob,
>>
>> When we use script "./scripts/checkpatch.pl" to check a patch, using pr_warning
>> will produce WARNING:
>>
>> WARNING: Prefer pr_warn(... to pr_warning(...
>> #22: FILE: drivers/of/fdt.c:428:
>> + pr_warning("End of tree marker overwritten: %08x\n",
>>
>> So,we should convert pr_warning to pr_warn.
>
> Okay, but don't explain to me. Explain this in the commit message.
>
> Rob
>
>
OK, i will send another patch and explain this in the commit message.
Wang Long
next prev parent reply other threads:[~2015-07-27 1:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 8:01 [PATCH] drivers/of/fdt.c: replace pr_warning by pr_warn Wang Long
2015-07-21 8:01 ` Wang Long
2015-07-24 19:00 ` Rob Herring
2015-07-25 0:57 ` long.wanglong
2015-07-25 0:57 ` long.wanglong
[not found] ` <55B2DEE2.8080509-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-07-26 20:39 ` Rob Herring
2015-07-26 20:39 ` Rob Herring
2015-07-27 1:47 ` long.wanglong [this message]
2015-07-27 1:47 ` long.wanglong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B58DCC.6080208@huawei.com \
--to=long.wanglong@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peifeiyue@huawei.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=wanglong@laoqinren.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.