All of lore.kernel.org
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi
Date: Mon, 27 Jul 2015 14:43:20 +0200	[thread overview]
Message-ID: <55B62768.6040403@redhat.com> (raw)
In-Reply-To: <20150727120918.191F76C82FB4@dd34104.kasserver.com>

Hi,

On 27-07-15 14:09, public_timo.s at silentcreek.de wrote:
> Hi,
>
> Hans de Goede schrieb am 27.07.2015 10:07:
>
>> I've a simular patch here:
>>
>> https://github.com/jwrdegoede/linux-sunxi/commit/6a30b7d5be6012b81e5e1439a444e41c0ac1afc1
>>
>> I did not submit this upstream yet as it is part of a series to enable the otg
>> controller on the bananapi which needs axp-usb-power-supply support for which
>> the actual powersupply driver changes are still pending.
> Oops, I see. Are you planning to submit this for 4.3 or later?

I plan to submit this for 4.3.

>> As you can see other then you adding the cpu operating points are patches are
>> identical, which is good :)
> Yep, that and you chose a slightly higher maximum voltage for the CPU.
>
>> IMHO we should just stick with the standard operating points unless we know
>> that there are stability issues with them (such as e.g. on the A10 OlinuxIno
>> Lime).
> I'd be fine with that as I don't have any stability issues with the lower
> voltages. What about the 1008MHz operating point that I "reintroduced"? It was
> dropped here [1]  because there was no regulator support.

That is in essence an overclocked setting, the max CPU voltage officially is
1.4V, I do not think that we should provide any overclocked settings in the
official dts files. If people really want to overclock they will have to
modify there dts themselves IMHO.

 > Can this be reenabled
> on board level (which means overriding the defaults inherited from
> sun7i-a20.dtsi) or should this be done at SOC level for all boards (which
> means we have to add regulator nodes for all boards in the first place)?

Technically this is possible, but I do not think that it is a good idea.

Regards,

Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: public_timo.s-fWgRPtSzPNU3WX+qO2AYSQ@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Cc: wens-jdAy2FN1RRM@public.gmane.org
Subject: Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi
Date: Mon, 27 Jul 2015 14:43:20 +0200	[thread overview]
Message-ID: <55B62768.6040403@redhat.com> (raw)
In-Reply-To: <20150727120918.191F76C82FB4-RzmsueL7+k6AvxNu/8lEInnhMCiq3JZZ@public.gmane.org>

Hi,

On 27-07-15 14:09, public_timo.s-fWgRPtSzPNU3WX+qO2AYSQ@public.gmane.org wrote:
> Hi,
>
> Hans de Goede schrieb am 27.07.2015 10:07:
>
>> I've a simular patch here:
>>
>> https://github.com/jwrdegoede/linux-sunxi/commit/6a30b7d5be6012b81e5e1439a444e41c0ac1afc1
>>
>> I did not submit this upstream yet as it is part of a series to enable the otg
>> controller on the bananapi which needs axp-usb-power-supply support for which
>> the actual powersupply driver changes are still pending.
> Oops, I see. Are you planning to submit this for 4.3 or later?

I plan to submit this for 4.3.

>> As you can see other then you adding the cpu operating points are patches are
>> identical, which is good :)
> Yep, that and you chose a slightly higher maximum voltage for the CPU.
>
>> IMHO we should just stick with the standard operating points unless we know
>> that there are stability issues with them (such as e.g. on the A10 OlinuxIno
>> Lime).
> I'd be fine with that as I don't have any stability issues with the lower
> voltages. What about the 1008MHz operating point that I "reintroduced"? It was
> dropped here [1]  because there was no regulator support.

That is in essence an overclocked setting, the max CPU voltage officially is
1.4V, I do not think that we should provide any overclocked settings in the
official dts files. If people really want to overclock they will have to
modify there dts themselves IMHO.

 > Can this be reenabled
> on board level (which means overriding the defaults inherited from
> sun7i-a20.dtsi) or should this be done at SOC level for all boards (which
> means we have to add regulator nodes for all boards in the first place)?

Technically this is possible, but I do not think that it is a good idea.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: public_timo.s@silentcreek.de, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linux@arm.linux.org.uk, maxime.ripard@free-electrons.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Cc: wens@csie.org
Subject: Re: [linux-sunxi] [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi
Date: Mon, 27 Jul 2015 14:43:20 +0200	[thread overview]
Message-ID: <55B62768.6040403@redhat.com> (raw)
In-Reply-To: <20150727120918.191F76C82FB4@dd34104.kasserver.com>

Hi,

On 27-07-15 14:09, public_timo.s@silentcreek.de wrote:
> Hi,
>
> Hans de Goede schrieb am 27.07.2015 10:07:
>
>> I've a simular patch here:
>>
>> https://github.com/jwrdegoede/linux-sunxi/commit/6a30b7d5be6012b81e5e1439a444e41c0ac1afc1
>>
>> I did not submit this upstream yet as it is part of a series to enable the otg
>> controller on the bananapi which needs axp-usb-power-supply support for which
>> the actual powersupply driver changes are still pending.
> Oops, I see. Are you planning to submit this for 4.3 or later?

I plan to submit this for 4.3.

>> As you can see other then you adding the cpu operating points are patches are
>> identical, which is good :)
> Yep, that and you chose a slightly higher maximum voltage for the CPU.
>
>> IMHO we should just stick with the standard operating points unless we know
>> that there are stability issues with them (such as e.g. on the A10 OlinuxIno
>> Lime).
> I'd be fine with that as I don't have any stability issues with the lower
> voltages. What about the 1008MHz operating point that I "reintroduced"? It was
> dropped here [1]  because there was no regulator support.

That is in essence an overclocked setting, the max CPU voltage officially is
1.4V, I do not think that we should provide any overclocked settings in the
official dts files. If people really want to overclock they will have to
modify there dts themselves IMHO.

 > Can this be reenabled
> on board level (which means overriding the defaults inherited from
> sun7i-a20.dtsi) or should this be done at SOC level for all boards (which
> means we have to add regulator nodes for all boards in the first place)?

Technically this is possible, but I do not think that it is a good idea.

Regards,

Hans

  reply	other threads:[~2015-07-27 12:43 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27  1:28 [RFC] ARM: dts: sunxi: Add regulators and board-specific operating points for LeMaker BananaPi Timo Sigurdsson
2015-07-27  1:28 ` Timo Sigurdsson
2015-07-27  1:28 ` Timo Sigurdsson
2015-07-27  8:07 ` [linux-sunxi] " Hans de Goede
2015-07-27  8:07   ` Hans de Goede
2015-07-27  8:07   ` Hans de Goede
2015-07-27 12:09   ` [linux-sunxi] " public_timo.s at silentcreek.de
2015-07-27 12:09     ` public_timo.s
2015-07-27 12:09     ` public_timo.s-fWgRPtSzPNU3WX+qO2AYSQ
2015-07-27 12:43     ` Hans de Goede [this message]
2015-07-27 12:43       ` Hans de Goede
2015-07-27 12:43       ` Hans de Goede
2015-07-28  9:02       ` Timo Sigurdsson
2015-07-28  9:02         ` Timo Sigurdsson
2015-07-28  9:02         ` Timo Sigurdsson
2015-07-28 12:55         ` [linux-sunxi] " Maxime Ripard
2015-07-28 12:55           ` Maxime Ripard
2015-07-28 12:55           ` Maxime Ripard
2015-07-28 14:57           ` [linux-sunxi] " Timo Sigurdsson
2015-07-28 14:57             ` Timo Sigurdsson
2015-07-28 14:57             ` Timo Sigurdsson
2015-07-28 12:49       ` [linux-sunxi] " Maxime Ripard
2015-07-28 12:49         ` Maxime Ripard
2015-07-28 12:49         ` Maxime Ripard
2015-07-28 14:24         ` Hans de Goede
2015-07-28 14:24           ` Hans de Goede
2015-07-28 14:24           ` Hans de Goede
2015-07-28 15:09           ` [linux-sunxi] " Timo Sigurdsson
2015-07-28 15:09             ` Timo Sigurdsson
2015-07-28 15:09             ` Timo Sigurdsson
2015-07-28 15:29             ` [linux-sunxi] " Hans de Goede
2015-07-28 15:29               ` Hans de Goede
2015-07-28 15:29               ` Hans de Goede
2015-08-02 22:00               ` Timo Sigurdsson
2015-08-02 22:00                 ` Timo Sigurdsson
2015-08-02 22:00                 ` Timo Sigurdsson
2015-07-28 14:45         ` [linux-sunxi] " Timo Sigurdsson
2015-07-28 14:45           ` Timo Sigurdsson
2015-07-28 14:45           ` Timo Sigurdsson
2015-07-27 12:36   ` [linux-sunxi] " public_timo.s at silentcreek.de
2015-07-27 12:36     ` public_timo.s
2015-07-27 12:36     ` public_timo.s-fWgRPtSzPNU3WX+qO2AYSQ
2015-07-27 12:54     ` [linux-sunxi] " Hans de Goede
2015-07-27 12:54       ` Hans de Goede
2015-07-27 12:54       ` Hans de Goede
     [not found]       ` <55B62A1B.6030601-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-27 13:14         ` Chen-Yu Tsai
2015-07-28  9:02           ` [linux-sunxi] " Timo Sigurdsson
2015-07-28  9:02             ` Timo Sigurdsson
2015-07-28  9:02             ` Timo Sigurdsson
2015-07-28 12:55             ` [linux-sunxi] " Maxime Ripard
2015-07-28 12:55               ` Maxime Ripard
2015-07-28 12:55               ` Maxime Ripard
2015-07-28 15:01               ` [linux-sunxi] " Timo Sigurdsson
2015-07-28 15:01                 ` Timo Sigurdsson
2015-07-28 15:01                 ` Timo Sigurdsson
2015-07-28 23:02             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B62768.6040403@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.