From: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
To: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Cc: Kalle Valo <kvalo@qca.qualcomm.com>, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: remove NULL ptr deref in variable init of ath10k_monitor_vdev_start
Date: Tue, 28 Jul 2015 10:41:11 +0530 [thread overview]
Message-ID: <55B70EEF.9070205@qti.qualcomm.com> (raw)
In-Reply-To: <1438024935-3946-1-git-send-email-linville@tuxdriver.com>
On Tuesday 28 July 2015 12:52 AM, John W. Linville wrote:
> In ath10k_monitor_vdev_start, chandef is initialized to NULL and then
> channel is immediately thereafter initialized to chandef->chan (i.e.
> NULL->chan). This appears to be some sort of cut-n-paste error, since
> the same assignment is done later (i.e. after chandef has been properly
> assigned to a non-NULL value). So, let's just remove this "brown paper
> bag" typo/thinko... :-)
>
> Coverity CID #1309505
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index c9a7d5b5dffc..2823222dea92 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -836,7 +836,7 @@ static inline int ath10k_vdev_setup_sync(struct ath10k *ar)
> static int ath10k_monitor_vdev_start(struct ath10k *ar, int vdev_id)
> {
> struct cfg80211_chan_def *chandef = NULL;
> - struct ieee80211_channel *channel = chandef->chan;
> + struct ieee80211_channel *channel;
> struct wmi_vdev_start_request_arg arg = {};
> int ret = 0;
>
There is a similar change integrated recently,
https://github.com/kvalo/ath/commit/19be9e9a7ac7e6050eab426283d2a87593cf6e82 .
Vasanth
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>
To: "John W. Linville" <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>
Cc: <ath10k@lists.infradead.org>, Kalle Valo <kvalo@qca.qualcomm.com>
Subject: Re: [PATCH] ath10k: remove NULL ptr deref in variable init of ath10k_monitor_vdev_start
Date: Tue, 28 Jul 2015 10:41:11 +0530 [thread overview]
Message-ID: <55B70EEF.9070205@qti.qualcomm.com> (raw)
In-Reply-To: <1438024935-3946-1-git-send-email-linville@tuxdriver.com>
On Tuesday 28 July 2015 12:52 AM, John W. Linville wrote:
> In ath10k_monitor_vdev_start, chandef is initialized to NULL and then
> channel is immediately thereafter initialized to chandef->chan (i.e.
> NULL->chan). This appears to be some sort of cut-n-paste error, since
> the same assignment is done later (i.e. after chandef has been properly
> assigned to a non-NULL value). So, let's just remove this "brown paper
> bag" typo/thinko... :-)
>
> Coverity CID #1309505
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index c9a7d5b5dffc..2823222dea92 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -836,7 +836,7 @@ static inline int ath10k_vdev_setup_sync(struct ath10k *ar)
> static int ath10k_monitor_vdev_start(struct ath10k *ar, int vdev_id)
> {
> struct cfg80211_chan_def *chandef = NULL;
> - struct ieee80211_channel *channel = chandef->chan;
> + struct ieee80211_channel *channel;
> struct wmi_vdev_start_request_arg arg = {};
> int ret = 0;
>
There is a similar change integrated recently,
https://github.com/kvalo/ath/commit/19be9e9a7ac7e6050eab426283d2a87593cf6e82 .
Vasanth
next prev parent reply other threads:[~2015-07-28 5:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 19:22 [PATCH] ath10k: remove NULL ptr deref in variable init of ath10k_monitor_vdev_start John W. Linville
2015-07-27 19:22 ` John W. Linville
2015-07-28 5:11 ` Vasanthakumar Thiagarajan [this message]
2015-07-28 5:11 ` Vasanthakumar Thiagarajan
2015-07-28 14:31 ` John W. Linville
2015-07-28 14:31 ` John W. Linville
2015-07-28 16:23 ` Kalle Valo
2015-07-28 16:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B70EEF.9070205@qti.qualcomm.com \
--to=vthiagar@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.