All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Vladimir Murzin <Vladimir.Murzin@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>
Subject: Re: [PATCH] arm64: KVM: remove remaining reference to vgic_sr_vectors
Date: Tue, 28 Jul 2015 10:52:22 +0100	[thread overview]
Message-ID: <55B750D6.30909@arm.com> (raw)
In-Reply-To: <1438076543-6768-1-git-send-email-vladimir.murzin@arm.com>

On 28/07/15 10:42, Vladimir Murzin wrote:
> Since commit 8a14849 (arm64: KVM: Switch vgic save/restore to
> alternative_insn) vgic_sr_vectors is not used anymore, so remove
> remaining leftovers and kill the structure.
> 
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>

Thanks Vladimir, I'll queue that up in -next.

Thanks,

	M.

> ---
>  arch/arm64/include/asm/kvm_host.h |    5 -----
>  arch/arm64/kernel/asm-offsets.c   |    2 --
>  2 files changed, 7 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index 2709db2..19f1182 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -216,11 +216,6 @@ static inline void __cpu_init_hyp_mode(phys_addr_t boot_pgd_ptr,
>  		     hyp_stack_ptr, vector_ptr);
>  }
>  
> -struct vgic_sr_vectors {
> -	void	*save_vgic;
> -	void	*restore_vgic;
> -};
> -
>  static inline void kvm_arch_hardware_disable(void) {}
>  static inline void kvm_arch_hardware_unsetup(void) {}
>  static inline void kvm_arch_sync_events(struct kvm *kvm) {}
> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
> index c99701a..f0c960d 100644
> --- a/arch/arm64/kernel/asm-offsets.c
> +++ b/arch/arm64/kernel/asm-offsets.c
> @@ -125,8 +125,6 @@ int main(void)
>    DEFINE(KVM_TIMER_ENABLED,	offsetof(struct kvm, arch.timer.enabled));
>    DEFINE(VCPU_KVM,		offsetof(struct kvm_vcpu, kvm));
>    DEFINE(VCPU_VGIC_CPU,		offsetof(struct kvm_vcpu, arch.vgic_cpu));
> -  DEFINE(VGIC_SAVE_FN,		offsetof(struct vgic_sr_vectors, save_vgic));
> -  DEFINE(VGIC_RESTORE_FN,	offsetof(struct vgic_sr_vectors, restore_vgic));
>    DEFINE(VGIC_V2_CPU_HCR,	offsetof(struct vgic_cpu, vgic_v2.vgic_hcr));
>    DEFINE(VGIC_V2_CPU_VMCR,	offsetof(struct vgic_cpu, vgic_v2.vgic_vmcr));
>    DEFINE(VGIC_V2_CPU_MISR,	offsetof(struct vgic_cpu, vgic_v2.vgic_misr));
> 


-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: KVM: remove remaining reference to vgic_sr_vectors
Date: Tue, 28 Jul 2015 10:52:22 +0100	[thread overview]
Message-ID: <55B750D6.30909@arm.com> (raw)
In-Reply-To: <1438076543-6768-1-git-send-email-vladimir.murzin@arm.com>

On 28/07/15 10:42, Vladimir Murzin wrote:
> Since commit 8a14849 (arm64: KVM: Switch vgic save/restore to
> alternative_insn) vgic_sr_vectors is not used anymore, so remove
> remaining leftovers and kill the structure.
> 
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>

Thanks Vladimir, I'll queue that up in -next.

Thanks,

	M.

> ---
>  arch/arm64/include/asm/kvm_host.h |    5 -----
>  arch/arm64/kernel/asm-offsets.c   |    2 --
>  2 files changed, 7 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index 2709db2..19f1182 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -216,11 +216,6 @@ static inline void __cpu_init_hyp_mode(phys_addr_t boot_pgd_ptr,
>  		     hyp_stack_ptr, vector_ptr);
>  }
>  
> -struct vgic_sr_vectors {
> -	void	*save_vgic;
> -	void	*restore_vgic;
> -};
> -
>  static inline void kvm_arch_hardware_disable(void) {}
>  static inline void kvm_arch_hardware_unsetup(void) {}
>  static inline void kvm_arch_sync_events(struct kvm *kvm) {}
> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
> index c99701a..f0c960d 100644
> --- a/arch/arm64/kernel/asm-offsets.c
> +++ b/arch/arm64/kernel/asm-offsets.c
> @@ -125,8 +125,6 @@ int main(void)
>    DEFINE(KVM_TIMER_ENABLED,	offsetof(struct kvm, arch.timer.enabled));
>    DEFINE(VCPU_KVM,		offsetof(struct kvm_vcpu, kvm));
>    DEFINE(VCPU_VGIC_CPU,		offsetof(struct kvm_vcpu, arch.vgic_cpu));
> -  DEFINE(VGIC_SAVE_FN,		offsetof(struct vgic_sr_vectors, save_vgic));
> -  DEFINE(VGIC_RESTORE_FN,	offsetof(struct vgic_sr_vectors, restore_vgic));
>    DEFINE(VGIC_V2_CPU_HCR,	offsetof(struct vgic_cpu, vgic_v2.vgic_hcr));
>    DEFINE(VGIC_V2_CPU_VMCR,	offsetof(struct vgic_cpu, vgic_v2.vgic_vmcr));
>    DEFINE(VGIC_V2_CPU_MISR,	offsetof(struct vgic_cpu, vgic_v2.vgic_misr));
> 


-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2015-07-28  9:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28  9:42 [PATCH] arm64: KVM: remove remaining reference to vgic_sr_vectors Vladimir Murzin
2015-07-28  9:42 ` Vladimir Murzin
2015-07-28  9:52 ` Marc Zyngier [this message]
2015-07-28  9:52   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B750D6.30909@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=Vladimir.Murzin@arm.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.