[review-request] adamian/20150727_tables

[review-request] adamian/20150727_tables

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 655 bytes --]

Hi,

This patch removes duplicates in the project compatible layers tables.

In effect, this patch computes, for each entry, its equivalence class in
the project context (based on the current project release), and selects
only the class leaders - the entries with the highest priority in their own
equivalence class.

This patch is important because the QuerySet here is the same one as one
would use to populate the future ProjectAvailableLayers table.

Please review and merge:

​
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20150727_tables
​

Cheers,
Alex

-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 1509 bytes --]

Re: [review-request] adamian/20150727_tables

[Barros Pena, Belen]

On 27/07/2015 17:43, "toaster-bounces@yoctoproject.org on behalf of
Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of
alexandru.damian@intel.com> wrote:

>Hi,
>
>
>This patch removes duplicates in the project compatible layers tables.
>
>
>In effect, this patch computes, for each entry, its equivalence class in
>the project context (based on the current project release), and selects
>only the class leaders - the entries with the highest
> priority in their own equivalence class.
>
>
>This patch is important because the QuerySet here is the same one as one
>would use to populate the future ProjectAvailableLayers table.
>
>
>
>Please review and merge:
>
>
>​http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/201
>50727_tables​

From the outside this seems to work. I now get only one openembedded-core
layer, with revision matching the project release, which makes sense to
me. 

Thanks

Belén

>
>
>Cheers,
>
>Alex
>
>
>-- 
>Alex Damian
>Yocto Project
>
>SSG / OTC 
>
>
>

Re: [review-request] adamian/20150727_tables

[Michael Wood]

On 28/07/15 11:40, Barros Pena, Belen wrote:
>
> On 27/07/2015 17:43, "toaster-bounces@yoctoproject.org on behalf of
> Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of
> alexandru.damian@intel.com> wrote:
>
>> Hi,
>>
>>
>> This patch removes duplicates in the project compatible layers tables.
>>
>>
>> In effect, this patch computes, for each entry, its equivalence class in
>> the project context (based on the current project release), and selects
>> only the class leaders - the entries with the highest
>> priority in their own equivalence class.
>>
>>
>> This patch is important because the QuerySet here is the same one as one
>> would use to populate the future ProjectAvailableLayers table.
>>
Wouldn't this be better in orm.project.compatible_layerversions ?

So that anyone using that function will no longer get duplicated entries.



>>
>> Please review and merge:
>>
>>
>> ​http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/201
>> 50727_tables​
>  From the outside this seems to work. I now get only one openembedded-core
> layer, with revision matching the project release, which makes sense to
> me.
>
> Thanks
>
> Belén
>
>>
>> Cheers,
>>
>> Alex
>>
>>
>> -- 
>> Alex Damian
>> Yocto Project
>>
>> SSG / OTC
>>
>>
>>

Re: [review-request] adamian/20150727_tables

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]

On Tue, Jul 28, 2015 at 11:50 AM, Michael Wood <michael.g.wood@intel.com>
wrote:

> On 28/07/15 11:40, Barros Pena, Belen wrote:
>
>>
>> On 27/07/2015 17:43, "toaster-bounces@yoctoproject.org on behalf of
>> Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of
>> alexandru.damian@intel.com> wrote:
>>
>>  Hi,
>>>
>>>
>>> This patch removes duplicates in the project compatible layers tables.
>>>
>>>
>>> In effect, this patch computes, for each entry, its equivalence class in
>>> the project context (based on the current project release), and selects
>>> only the class leaders - the entries with the highest
>>> priority in their own equivalence class.
>>>
>>>
>>> This patch is important because the QuerySet here is the same one as one
>>> would use to populate the future ProjectAvailableLayers table.
>>>
>>>  Wouldn't this be better in orm.project.compatible_layerversions ?
>
> So that anyone using that function will no longer get duplicated entries.
>
>
> ​I actually thought about this, but it would interfere with the recipe
selection - the recipes are selected from all compatible_layerversions, not
just from the group leaders; otherwise, we could not show OE-Core recipes
coming from LayerIndex when the group leader comes from the
toasterconf.json OE-Core version.



>
>
>>> Please review and merge:
>>>
>>>
>>> ​
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/201
>>> 50727_tables​
>>>
>>  From the outside this seems to work. I now get only one openembedded-core
>> layer, with revision matching the project release, which makes sense to
>> me.
>>
>> Thanks
>>
>> Belén
>>
>>
>>> Cheers,
>>>
>>> Alex
>>>
>>>
>>> --
>>> Alex Damian
>>> Yocto Project
>>>
>>> SSG / OTC
>>>
>>>
>>>
>>>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 3940 bytes --]