From: David Vrabel <david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
To: Julien Grall
<julien.grall-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org
Cc: x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
David Vrabel
<david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
Boris Ostrovsky
<boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [Xen-devel] [PATCH 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up
Date: Tue, 28 Jul 2015 18:19:09 +0100 [thread overview]
Message-ID: <55B7B98D.3050008@citrix.com> (raw)
In-Reply-To: <1438095769-2560-9-git-send-email-julien.grall-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
On 28/07/15 16:02, Julien Grall wrote:
> The privcmd code is mixing the usage of GFN and MFN within the same
> functions which make the code difficult to understand when you only work
> with auto-translated guests.
>
> The privcmd driver is only dealing with GFN so replace all the mention
> of MFN into GFN.
>
> The ioctl structure used to map foreign change has been left unchanged
> given that the userspace is using it. Nonetheless, add a comment to
> explain the expected value within the "mfn" field.
Reviewed-by: David Vrabel <david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
David
WARNING: multiple messages have this Message-ID (diff)
From: david.vrabel@citrix.com (David Vrabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [Xen-devel] [PATCH 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up
Date: Tue, 28 Jul 2015 18:19:09 +0100 [thread overview]
Message-ID: <55B7B98D.3050008@citrix.com> (raw)
In-Reply-To: <1438095769-2560-9-git-send-email-julien.grall@citrix.com>
On 28/07/15 16:02, Julien Grall wrote:
> The privcmd code is mixing the usage of GFN and MFN within the same
> functions which make the code difficult to understand when you only work
> with auto-translated guests.
>
> The privcmd driver is only dealing with GFN so replace all the mention
> of MFN into GFN.
>
> The ioctl structure used to map foreign change has been left unchanged
> given that the userspace is using it. Nonetheless, add a comment to
> explain the expected value within the "mfn" field.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, <xen-devel@lists.xenproject.org>
Cc: <x86@kernel.org>, Russell King <linux@arm.linux.org.uk>,
<ian.campbell@citrix.com>, <linux-api@vger.kernel.org>,
<stefano.stabellini@eu.citrix.com>,
<linux-kernel@vger.kernel.org>, "Ingo Molnar" <mingo@redhat.com>,
David Vrabel <david.vrabel@citrix.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Xen-devel] [PATCH 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up
Date: Tue, 28 Jul 2015 18:19:09 +0100 [thread overview]
Message-ID: <55B7B98D.3050008@citrix.com> (raw)
In-Reply-To: <1438095769-2560-9-git-send-email-julien.grall@citrix.com>
On 28/07/15 16:02, Julien Grall wrote:
> The privcmd code is mixing the usage of GFN and MFN within the same
> functions which make the code difficult to understand when you only work
> with auto-translated guests.
>
> The privcmd driver is only dealing with GFN so replace all the mention
> of MFN into GFN.
>
> The ioctl structure used to map foreign change has been left unchanged
> given that the userspace is using it. Nonetheless, add a comment to
> explain the expected value within the "mfn" field.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
next prev parent reply other threads:[~2015-07-28 17:19 UTC|newest]
Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 15:02 [PATCH 0/8] Use correctly the Xen memory terminologies in Linux Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` [PATCH 1/8] arm/xen: Remove helpers which are PV specific Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-31 10:44 ` Stefano Stabellini
2015-07-31 10:44 ` Stefano Stabellini
2015-07-31 10:44 ` Stefano Stabellini
2015-07-31 10:55 ` Ian Campbell
2015-07-31 10:55 ` Ian Campbell
2015-07-31 10:55 ` Ian Campbell
2015-08-04 16:36 ` [Xen-devel] " Julien Grall
2015-08-04 16:36 ` Julien Grall
2015-08-04 16:36 ` Julien Grall
2015-07-28 15:02 ` [PATCH 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:52 ` [Xen-devel] " David Vrabel
2015-07-28 15:52 ` David Vrabel
2015-07-28 16:06 ` Julien Grall
2015-07-28 16:06 ` [Xen-devel] " Julien Grall
2015-07-28 16:06 ` Julien Grall
2015-07-31 10:54 ` Stefano Stabellini
2015-07-31 10:54 ` [Xen-devel] " Stefano Stabellini
2015-07-31 10:54 ` Stefano Stabellini
2015-07-28 15:52 ` David Vrabel
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` [PATCH 3/8] arm/xen: implement correctly pfn_to_mfn Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` [PATCH 4/8] xen: Use the correctly the Xen memory terminologies Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 17:16 ` David Vrabel
2015-07-28 17:16 ` [Xen-devel] " David Vrabel
2015-07-28 17:16 ` David Vrabel
2015-07-28 17:16 ` David Vrabel
2015-07-28 17:16 ` David Vrabel
2015-07-28 17:16 ` David Vrabel
2015-07-29 11:06 ` Julien Grall
2015-07-29 11:06 ` Julien Grall
2015-07-29 11:06 ` Julien Grall
2015-07-29 11:06 ` Julien Grall
2015-07-29 11:06 ` Julien Grall
2015-07-29 11:06 ` Julien Grall
2015-07-28 19:12 ` Boris Ostrovsky
2015-07-28 19:12 ` Boris Ostrovsky
2015-07-28 19:12 ` Boris Ostrovsky
2015-07-28 19:12 ` Boris Ostrovsky
2015-07-29 11:25 ` Julien Grall
2015-07-29 11:25 ` Julien Grall
2015-07-29 11:25 ` Julien Grall
2015-07-29 11:25 ` Julien Grall
2015-07-29 11:25 ` Julien Grall
2015-07-29 11:25 ` Julien Grall
2015-07-29 14:14 ` Boris Ostrovsky
2015-07-29 14:14 ` Boris Ostrovsky
2015-07-29 14:14 ` Boris Ostrovsky
2015-07-29 14:14 ` Boris Ostrovsky
2015-07-29 14:14 ` Boris Ostrovsky
2015-07-29 14:23 ` Julien Grall
2015-07-29 14:23 ` Julien Grall
2015-07-29 14:23 ` Julien Grall
2015-07-29 14:23 ` Julien Grall
2015-07-29 14:23 ` Julien Grall
2015-07-29 14:51 ` Boris Ostrovsky
2015-07-29 14:51 ` Boris Ostrovsky
2015-07-29 14:51 ` Boris Ostrovsky
2015-07-29 14:51 ` Boris Ostrovsky
2015-07-29 14:51 ` Boris Ostrovsky
2015-07-29 14:23 ` Julien Grall
2015-07-28 19:12 ` Boris Ostrovsky
2015-07-28 19:39 ` [Xen-devel] " Chris (Christopher) Brand
2015-07-28 19:39 ` Chris (Christopher) Brand
2015-07-28 19:39 ` Chris (Christopher) Brand
2015-07-28 19:39 ` Chris (Christopher) Brand
2015-07-28 19:39 ` Chris (Christopher) Brand
2015-07-28 19:39 ` Chris (Christopher) Brand
2015-07-29 11:27 ` Julien Grall
2015-07-29 11:27 ` Julien Grall
2015-07-29 11:27 ` Julien Grall
2015-07-29 11:27 ` Julien Grall
2015-07-29 11:27 ` Julien Grall
2015-07-29 11:27 ` Julien Grall
2015-07-28 19:39 ` Chris (Christopher) Brand
2015-07-29 10:13 ` Wei Liu
2015-07-29 10:13 ` Wei Liu
2015-07-29 10:13 ` Wei Liu
2015-07-29 10:13 ` Wei Liu
2015-07-29 10:13 ` Wei Liu
2015-07-29 11:35 ` Julien Grall
2015-07-29 11:35 ` [Xen-devel] " Julien Grall
2015-07-29 11:35 ` Julien Grall
2015-07-29 11:35 ` Julien Grall
2015-07-29 11:35 ` Julien Grall
2015-07-29 11:35 ` Julien Grall
2015-07-29 11:38 ` David Vrabel
2015-07-29 11:38 ` David Vrabel
2015-07-29 11:38 ` David Vrabel
2015-07-29 11:38 ` David Vrabel
2015-07-29 11:38 ` David Vrabel
2015-07-29 11:39 ` Wei Liu
2015-07-29 11:39 ` [Xen-devel] " Wei Liu
2015-07-29 11:39 ` Wei Liu
2015-07-29 11:39 ` Wei Liu
2015-07-29 11:39 ` Wei Liu
2015-07-29 11:39 ` Wei Liu
2015-07-31 11:02 ` Stefano Stabellini
2015-07-31 11:02 ` Stefano Stabellini
2015-07-31 11:02 ` Stefano Stabellini
2015-07-31 11:02 ` Stefano Stabellini
2015-07-31 11:02 ` Stefano Stabellini
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` [PATCH 5/8] xen/tmem: Use page_to_gfn rather than pfn_to_gfn Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` [PATCH 6/8] video/xen-fbfront: Further s/MFN/GFN clean-up Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 17:16 ` David Vrabel
2015-07-28 17:16 ` [Xen-devel] " David Vrabel
2015-07-28 17:16 ` David Vrabel
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` [PATCH 7/8] hvc/xen: " Julien Grall
2015-07-28 17:17 ` David Vrabel
2015-07-28 17:17 ` [Xen-devel] " David Vrabel
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` [PATCH 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 15:02 ` Julien Grall
2015-07-28 17:19 ` David Vrabel
[not found] ` <1438095769-2560-9-git-send-email-julien.grall-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2015-07-28 17:19 ` David Vrabel [this message]
2015-07-28 17:19 ` [Xen-devel] " David Vrabel
2015-07-28 17:19 ` David Vrabel
2015-07-28 21:06 ` [PATCH 0/8] Use correctly the Xen memory terminologies in Linux H. Peter Anvin
2015-07-28 21:06 ` H. Peter Anvin
2015-07-28 21:06 ` H. Peter Anvin
2015-07-28 21:06 ` H. Peter Anvin
2015-07-28 21:06 ` H. Peter Anvin
2015-07-28 21:12 ` Andrew Cooper
2015-07-28 21:12 ` [Xen-devel] " Andrew Cooper
2015-07-28 21:12 ` Andrew Cooper
2015-07-28 21:12 ` Andrew Cooper
2015-07-28 21:12 ` Andrew Cooper
2015-07-28 21:12 ` Andrew Cooper
2015-07-29 11:02 ` Julien Grall
2015-07-29 11:02 ` Julien Grall
2015-07-29 11:02 ` Julien Grall
2015-07-29 11:02 ` Julien Grall
2015-07-29 11:02 ` Julien Grall
2015-07-29 11:02 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B7B98D.3050008@citrix.com \
--to=david.vrabel-sxgqhf6nn4dqt0dzr+alfa@public.gmane.org \
--cc=boris.ostrovsky-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=julien.grall-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=stefano.stabellini-mvvWK6WmYclDPfheJLI6IQ@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.