From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] alloc: only warn once if we run out of log entries
Date: Wed, 29 Jul 2015 15:52:51 +0200 [thread overview]
Message-ID: <55B8DAB3.9070200@redhat.com> (raw)
In-Reply-To: <1437739647-30313-1-git-send-email-drjones@redhat.com>
On 24/07/2015 14:07, Andrew Jones wrote:
> @@ -58,6 +59,7 @@ void phys_alloc_set_minimum_alignment(phys_addr_t align)
> static phys_addr_t phys_alloc_aligned_safe(phys_addr_t size,
> phys_addr_t align, bool safe)
> {
> + static bool not_warned = true;
I wouldn't object to not having "not" in the name of this variable. :)
Otherwise looks okay.
Paolo
> phys_addr_t addr, size_orig = size;
> u64 top_safe = top;
>
next prev parent reply other threads:[~2015-07-29 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 12:07 [kvm-unit-tests PATCH] alloc: only warn once if we run out of log entries Andrew Jones
2015-07-29 13:52 ` Paolo Bonzini [this message]
2015-07-29 14:16 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B8DAB3.9070200@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.