Re: [Qemu-devel] [PATCH 03/12] netfilter: add netfilter_{add|del} commands

[Yang Hongyang <yanghy@cn.fujitsu.com>]

On 07/29/2015 10:15 PM, Thomas Huth wrote:
> On Wednesday, July 29, 2015 12:51:47 PM,
> "Yang Hongyang" <yanghy@cn.fujitsu.com> wrote:
>>
>> add netfilter_{add|del} commands
>> This is mostly the same with netdev_{add|del} commands.
>>
>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>> ---
> ...
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index d3b7932..5326a82 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -1253,6 +1253,36 @@ Remove host network device.
>>   ETEXI
>>
>>       {
>> +        .name       = "netfilter_add",
>> +        .args_type  = "netfilter:O",
>> +        .params     = "[type],id=str,netdev=str[,prop=value][,...]",
>
> I'm not fully sure about the syntax, but writing "[type]" in square
> brackets sounds like this parameter is optional to me. But if
> I've got this right, it is not optional, is it? So maybe use
> "<type>" instead?

Yes, <type> could be better here, it will be updated in the last
patch when we have added a type "buffer"!

>
>   Thomas
> .
>

-- 
Thanks,
Yang.