* [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig
@ 2015-07-28 18:52 ` Ray Jui
0 siblings, 0 replies; 6+ messages in thread
From: Ray Jui @ 2015-07-28 18:52 UTC (permalink / raw)
To: Olof Johansson, Arnd Bergmann, Bjorn Helgaas, Hauke Mehrtens
Cc: linux-kernel, bcm-kernel-feedback-list, linux-arm-kernel, arm,
linux-pci, Ray Jui
The current iProc BCMA front-end driver can only work on ARM32 based
platforms; therefore its config option in Kconfig should be changed to
reflect that. This fixes arm64 allmodconfig build failure when compiling
the the iProc BCMA driver that contains struct pci_sys_data that is
arm32 specific
Signed-off-by: Ray Jui <rjui@broadcom.com>
---
drivers/pci/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index d2c6144..2cc9afe 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -136,7 +136,7 @@ config PCIE_IPROC_PLATFORM
config PCIE_IPROC_BCMA
bool "Broadcom iProc PCIe BCMA bus driver"
- depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
+ depends on ARCH_BCM_IPROC && ARM
select PCIE_IPROC
select BCMA
select PCI_DOMAINS
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig
@ 2015-07-28 18:52 ` Ray Jui
0 siblings, 0 replies; 6+ messages in thread
From: Ray Jui @ 2015-07-28 18:52 UTC (permalink / raw)
To: linux-arm-kernel
The current iProc BCMA front-end driver can only work on ARM32 based
platforms; therefore its config option in Kconfig should be changed to
reflect that. This fixes arm64 allmodconfig build failure when compiling
the the iProc BCMA driver that contains struct pci_sys_data that is
arm32 specific
Signed-off-by: Ray Jui <rjui@broadcom.com>
---
drivers/pci/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index d2c6144..2cc9afe 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -136,7 +136,7 @@ config PCIE_IPROC_PLATFORM
config PCIE_IPROC_BCMA
bool "Broadcom iProc PCIe BCMA bus driver"
- depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
+ depends on ARCH_BCM_IPROC && ARM
select PCIE_IPROC
select BCMA
select PCI_DOMAINS
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig
2015-07-28 18:52 ` Ray Jui
@ 2015-07-29 14:30 ` Arnd Bergmann
-1 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2015-07-29 14:30 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Ray Jui, Olof Johansson, Bjorn Helgaas, Hauke Mehrtens, linux-pci,
linux-kernel, arm, bcm-kernel-feedback-list
On Tuesday 28 July 2015 11:52:13 Ray Jui wrote:
> config PCIE_IPROC_BCMA
> bool "Broadcom iProc PCIe BCMA bus driver"
> - depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
> + depends on ARCH_BCM_IPROC && ARM
> select PCIE_IPROC
> select BCMA
> select PCI_DOMAINS
>
How about this:
depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
That would leave the compile test present for non-iproc
ARM platforms while preventing ARM64 and MIPS builds with
ARCH_BCM_IPROC set.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig
@ 2015-07-29 14:30 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2015-07-29 14:30 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 28 July 2015 11:52:13 Ray Jui wrote:
> config PCIE_IPROC_BCMA
> bool "Broadcom iProc PCIe BCMA bus driver"
> - depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
> + depends on ARCH_BCM_IPROC && ARM
> select PCIE_IPROC
> select BCMA
> select PCI_DOMAINS
>
How about this:
depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
That would leave the compile test present for non-iproc
ARM platforms while preventing ARM64 and MIPS builds with
ARCH_BCM_IPROC set.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig
2015-07-29 14:30 ` Arnd Bergmann
@ 2015-07-29 16:17 ` Ray Jui
-1 siblings, 0 replies; 6+ messages in thread
From: Ray Jui @ 2015-07-29 16:17 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel
Cc: Olof Johansson, Bjorn Helgaas, Hauke Mehrtens, linux-pci,
linux-kernel, arm, bcm-kernel-feedback-list
On 7/29/2015 7:30 AM, Arnd Bergmann wrote:
> On Tuesday 28 July 2015 11:52:13 Ray Jui wrote:
>> config PCIE_IPROC_BCMA
>> bool "Broadcom iProc PCIe BCMA bus driver"
>> - depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>> + depends on ARCH_BCM_IPROC && ARM
>> select PCIE_IPROC
>> select BCMA
>> select PCI_DOMAINS
>>
>
> How about this:
>
> depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
>
> That would leave the compile test present for non-iproc
> ARM platforms while preventing ARM64 and MIPS builds with
> ARCH_BCM_IPROC set.
>
> Arnd
>
That is indeed better. Broader compile test coverage is always good.
I'll submit another patch with the above suggested change.
Thanks,
Ray
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig
@ 2015-07-29 16:17 ` Ray Jui
0 siblings, 0 replies; 6+ messages in thread
From: Ray Jui @ 2015-07-29 16:17 UTC (permalink / raw)
To: linux-arm-kernel
On 7/29/2015 7:30 AM, Arnd Bergmann wrote:
> On Tuesday 28 July 2015 11:52:13 Ray Jui wrote:
>> config PCIE_IPROC_BCMA
>> bool "Broadcom iProc PCIe BCMA bus driver"
>> - depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST)
>> + depends on ARCH_BCM_IPROC && ARM
>> select PCIE_IPROC
>> select BCMA
>> select PCI_DOMAINS
>>
>
> How about this:
>
> depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST)
>
> That would leave the compile test present for non-iproc
> ARM platforms while preventing ARM64 and MIPS builds with
> ARCH_BCM_IPROC set.
>
> Arnd
>
That is indeed better. Broader compile test coverage is always good.
I'll submit another patch with the above suggested change.
Thanks,
Ray
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-29 16:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-28 18:52 [PATCH] PCI: iproc: Fix BCMA dependency in Kconfig Ray Jui
2015-07-28 18:52 ` Ray Jui
2015-07-29 14:30 ` Arnd Bergmann
2015-07-29 14:30 ` Arnd Bergmann
2015-07-29 16:17 ` Ray Jui
2015-07-29 16:17 ` Ray Jui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.