From: Hannes Reinecke <hare@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"James E.J. Bottomley" <JBottomley@odin.com>
Cc: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [SCSI] atp870u: 64 bit bug in probe()
Date: Thu, 30 Jul 2015 06:54:51 +0000 [thread overview]
Message-ID: <55B9CA3B.1030205@suse.de> (raw)
In-Reply-To: <20150729213605.GD21784@mwanda>
On 07/29/2015 11:36 PM, Dan Carpenter wrote:
> On 64 bit CPUs there is a memory corruption bug on probe(). It should
> be a u32 pointer instead of an unsigned long pointer or we write past
> the end of the setupdata[] array.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Someone reported in 2003 that probe has a NULL deref so maybe it's
> related to this memory corruption?
> https://bugzilla.kernel.org/show_bug.cgi?id\x1118
>
> If only we had applied this patch when I originally sent it two years
> ago, then it would only be 10 years too late instead of 12! :P
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"James E.J. Bottomley" <JBottomley@odin.com>
Cc: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [SCSI] atp870u: 64 bit bug in probe()
Date: Thu, 30 Jul 2015 08:54:51 +0200 [thread overview]
Message-ID: <55B9CA3B.1030205@suse.de> (raw)
In-Reply-To: <20150729213605.GD21784@mwanda>
On 07/29/2015 11:36 PM, Dan Carpenter wrote:
> On 64 bit CPUs there is a memory corruption bug on probe(). It should
> be a u32 pointer instead of an unsigned long pointer or we write past
> the end of the setupdata[] array.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Someone reported in 2003 that probe has a NULL deref so maybe it's
> related to this memory corruption?
> https://bugzilla.kernel.org/show_bug.cgi?id=1118
>
> If only we had applied this patch when I originally sent it two years
> ago, then it would only be 10 years too late instead of 12! :P
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-30 6:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 9:50 [patch] [SCSI] atp870u: 64 bit bug in probe() Dan Carpenter
2013-09-04 9:50 ` Dan Carpenter
2015-07-29 21:36 ` Dan Carpenter
2015-07-29 21:36 ` Dan Carpenter
2015-07-30 6:54 ` Hannes Reinecke [this message]
2015-07-30 6:54 ` Hannes Reinecke
2015-12-09 10:24 ` [patch RESEND] atp870u: 64 bit bug in atp885_init() Dan Carpenter
2015-12-09 10:24 ` Dan Carpenter
2015-12-09 11:53 ` One Thousand Gnomes
2015-12-09 11:53 ` One Thousand Gnomes
2015-12-09 12:07 ` Ondrej Zary
2015-12-09 12:07 ` Ondrej Zary
2015-12-09 13:45 ` Dan Carpenter
2015-12-09 13:45 ` Dan Carpenter
2015-12-09 14:14 ` One Thousand Gnomes
2015-12-09 14:14 ` One Thousand Gnomes
2015-12-09 17:48 ` Dan Carpenter
2015-12-09 17:48 ` Dan Carpenter
2015-12-09 18:11 ` Julia Lawall
2015-12-09 18:11 ` Julia Lawall
2015-12-09 18:28 ` Dan Carpenter
2015-12-09 18:28 ` Dan Carpenter
2015-12-09 19:37 ` One Thousand Gnomes
2015-12-09 19:37 ` One Thousand Gnomes
2018-02-15 23:44 ` Martin K. Petersen
2018-02-15 23:44 ` Martin K. Petersen
2018-03-02 2:11 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B9CA3B.1030205@suse.de \
--to=hare@suse.de \
--cc=JBottomley@odin.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.