* [U-Boot] [PATCH] Tegra: P2571: Clean up config file
@ 2015-07-30 21:09 Tom Warren
2015-07-30 21:18 ` Stephen Warren
2015-07-30 21:33 ` Simon Glass
0 siblings, 2 replies; 5+ messages in thread
From: Tom Warren @ 2015-07-30 21:09 UTC (permalink / raw)
To: u-boot
Removed NS16550_COM1 #define, not used since there's no SPL for T210
Also changed the number of USB controllers to 1 as only USBD is used.
Signed-off-by: Tom Warren <twarren@nvidia.com>
---
include/configs/p2571.h | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/include/configs/p2571.h b/include/configs/p2571.h
index 5df7d2f..b22117b 100644
--- a/include/configs/p2571.h
+++ b/include/configs/p2571.h
@@ -22,7 +22,6 @@
/* Board-specific serial config */
#define CONFIG_SERIAL_MULTI
#define CONFIG_TEGRA_ENABLE_UARTA
-#define CONFIG_SYS_NS16550_COM1 NV_PA_APB_UARTA_BASE
/* I2C */
#define CONFIG_SYS_I2C_TEGRA
@@ -51,7 +50,7 @@
/* USB2.0 Host support */
#define CONFIG_USB_EHCI
#define CONFIG_USB_EHCI_TEGRA
-#define CONFIG_USB_MAX_CONTROLLER_COUNT 2
+#define CONFIG_USB_MAX_CONTROLLER_COUNT 1
#define CONFIG_USB_STORAGE
#define CONFIG_CMD_USB
@@ -62,10 +61,6 @@
/* General networking support */
#define CONFIG_CMD_DHCP
-/*
- * TODO(twarren at nvidia.com) - add tegra-common-usb-gadget.h back
- * breaks 64-bit build in ci_udc.c
- */
#include "tegra-common-usb-gadget.h"
#include "tegra-common-post.h"
--
1.8.2.1.610.g562af5b
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Tegra: P2571: Clean up config file
2015-07-30 21:09 [U-Boot] [PATCH] Tegra: P2571: Clean up config file Tom Warren
@ 2015-07-30 21:18 ` Stephen Warren
2015-07-30 21:33 ` Simon Glass
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Warren @ 2015-07-30 21:18 UTC (permalink / raw)
To: u-boot
On 07/30/2015 03:09 PM, Tom Warren wrote:
> Removed NS16550_COM1 #define, not used since there's no SPL for T210
> Also changed the number of USB controllers to 1 as only USBD is used.
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Tegra: P2571: Clean up config file
2015-07-30 21:09 [U-Boot] [PATCH] Tegra: P2571: Clean up config file Tom Warren
2015-07-30 21:18 ` Stephen Warren
@ 2015-07-30 21:33 ` Simon Glass
2015-07-30 22:28 ` Tom Warren
1 sibling, 1 reply; 5+ messages in thread
From: Simon Glass @ 2015-07-30 21:33 UTC (permalink / raw)
To: u-boot
Hi Tom,
On 30 July 2015 at 15:09, Tom Warren <twarren@nvidia.com> wrote:
>
> Removed NS16550_COM1 #define, not used since there's no SPL for T210
> Also changed the number of USB controllers to 1 as only USBD is used.
>
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> ---
> include/configs/p2571.h | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/include/configs/p2571.h b/include/configs/p2571.h
> index 5df7d2f..b22117b 100644
> --- a/include/configs/p2571.h
> +++ b/include/configs/p2571.h
> @@ -22,7 +22,6 @@
> /* Board-specific serial config */
> #define CONFIG_SERIAL_MULTI
> #define CONFIG_TEGRA_ENABLE_UARTA
> -#define CONFIG_SYS_NS16550_COM1 NV_PA_APB_UARTA_BASE
>
> /* I2C */
> #define CONFIG_SYS_I2C_TEGRA
> @@ -51,7 +50,7 @@
> /* USB2.0 Host support */
> #define CONFIG_USB_EHCI
> #define CONFIG_USB_EHCI_TEGRA
> -#define CONFIG_USB_MAX_CONTROLLER_COUNT 2
> +#define CONFIG_USB_MAX_CONTROLLER_COUNT 1
You should be able to drop this now that Tegra uses driver model for USB.
> #define CONFIG_USB_STORAGE
> #define CONFIG_CMD_USB
>
> @@ -62,10 +61,6 @@
> /* General networking support */
> #define CONFIG_CMD_DHCP
>
> -/*
> - * TODO(twarren at nvidia.com) - add tegra-common-usb-gadget.h back
> - * breaks 64-bit build in ci_udc.c
> - */
> #include "tegra-common-usb-gadget.h"
> #include "tegra-common-post.h"
>
> --
> 1.8.2.1.610.g562af5b
>
Regards,
Simon
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Tegra: P2571: Clean up config file
2015-07-30 21:33 ` Simon Glass
@ 2015-07-30 22:28 ` Tom Warren
2015-07-30 23:13 ` Simon Glass
0 siblings, 1 reply; 5+ messages in thread
From: Tom Warren @ 2015-07-30 22:28 UTC (permalink / raw)
To: u-boot
Simon,
> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: Thursday, July 30, 2015 2:33 PM
> To: Tom Warren
> Cc: U-Boot Mailing List; Tom Warren; Stephen Warren
> Subject: Re: [PATCH] Tegra: P2571: Clean up config file
>
> Hi Tom,
>
> On 30 July 2015 at 15:09, Tom Warren <twarren@nvidia.com> wrote:
> >
> > Removed NS16550_COM1 #define, not used since there's no SPL for T210
> > Also changed the number of USB controllers to 1 as only USBD is used.
> >
> > Signed-off-by: Tom Warren <twarren@nvidia.com>
> > ---
> > include/configs/p2571.h | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/include/configs/p2571.h b/include/configs/p2571.h index
> > 5df7d2f..b22117b 100644
> > --- a/include/configs/p2571.h
> > +++ b/include/configs/p2571.h
> > @@ -22,7 +22,6 @@
> > /* Board-specific serial config */
> > #define CONFIG_SERIAL_MULTI
> > #define CONFIG_TEGRA_ENABLE_UARTA
> > -#define CONFIG_SYS_NS16550_COM1 NV_PA_APB_UARTA_BASE
> >
> > /* I2C */
> > #define CONFIG_SYS_I2C_TEGRA
> > @@ -51,7 +50,7 @@
> > /* USB2.0 Host support */
> > #define CONFIG_USB_EHCI
> > #define CONFIG_USB_EHCI_TEGRA
> > -#define CONFIG_USB_MAX_CONTROLLER_COUNT 2
> > +#define CONFIG_USB_MAX_CONTROLLER_COUNT 1
>
> You should be able to drop this now that Tegra uses driver model for USB.
Doesn't seem to work on P2571. If I drop MAX_CONTROLLER_COUNT, it builds, but I get "EHCI failed to shut down host controller" errors on usb start/reset, and I don't see any of my periphs (mouse, USB stick, network dongle). With it in there as I have it above, everything works.
>
> > #define CONFIG_USB_STORAGE
> > #define CONFIG_CMD_USB
> >
> > @@ -62,10 +61,6 @@
> > /* General networking support */
> > #define CONFIG_CMD_DHCP
> >
> > -/*
> > - * TODO(twarren at nvidia.com) - add tegra-common-usb-gadget.h back
> > - * breaks 64-bit build in ci_udc.c
> > - */
> > #include "tegra-common-usb-gadget.h"
> > #include "tegra-common-post.h"
> >
> > --
> > 1.8.2.1.610.g562af5b
> >
>
> Regards,
> Simon
--
nvpublic
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] Tegra: P2571: Clean up config file
2015-07-30 22:28 ` Tom Warren
@ 2015-07-30 23:13 ` Simon Glass
0 siblings, 0 replies; 5+ messages in thread
From: Simon Glass @ 2015-07-30 23:13 UTC (permalink / raw)
To: u-boot
Hi Tom,
On 30 July 2015 at 16:28, Tom Warren <TWarren@nvidia.com> wrote:
> Simon,
>
>> -----Original Message-----
>> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
>> Sent: Thursday, July 30, 2015 2:33 PM
>> To: Tom Warren
>> Cc: U-Boot Mailing List; Tom Warren; Stephen Warren
>> Subject: Re: [PATCH] Tegra: P2571: Clean up config file
>>
>> Hi Tom,
>>
>> On 30 July 2015 at 15:09, Tom Warren <twarren@nvidia.com> wrote:
>> >
>> > Removed NS16550_COM1 #define, not used since there's no SPL for T210
>> > Also changed the number of USB controllers to 1 as only USBD is used.
>> >
>> > Signed-off-by: Tom Warren <twarren@nvidia.com>
>> > ---
>> > include/configs/p2571.h | 7 +------
>> > 1 file changed, 1 insertion(+), 6 deletions(-)
>> >
>> > diff --git a/include/configs/p2571.h b/include/configs/p2571.h index
>> > 5df7d2f..b22117b 100644
>> > --- a/include/configs/p2571.h
>> > +++ b/include/configs/p2571.h
>> > @@ -22,7 +22,6 @@
>> > /* Board-specific serial config */
>> > #define CONFIG_SERIAL_MULTI
>> > #define CONFIG_TEGRA_ENABLE_UARTA
>> > -#define CONFIG_SYS_NS16550_COM1 NV_PA_APB_UARTA_BASE
>> >
>> > /* I2C */
>> > #define CONFIG_SYS_I2C_TEGRA
>> > @@ -51,7 +50,7 @@
>> > /* USB2.0 Host support */
>> > #define CONFIG_USB_EHCI
>> > #define CONFIG_USB_EHCI_TEGRA
>> > -#define CONFIG_USB_MAX_CONTROLLER_COUNT 2
>> > +#define CONFIG_USB_MAX_CONTROLLER_COUNT 1
>>
>> You should be able to drop this now that Tegra uses driver model for USB.
> Doesn't seem to work on P2571. If I drop MAX_CONTROLLER_COUNT, it builds, but I get "EHCI failed to shut down host controller" errors on usb start/reset, and I don't see any of my periphs (mouse, USB stick, network dongle). With it in there as I have it above, everything works.
>
Odd...
Do you have CONFIG_DM_USB defined for this board? (check .config or
u-boot.cfg after a build). Also are you basing on latest mainline?
Hans fixed a few bugs which I applied in the past week.
>>
>> > #define CONFIG_USB_STORAGE
>> > #define CONFIG_CMD_USB
>> >
>> > @@ -62,10 +61,6 @@
>> > /* General networking support */
>> > #define CONFIG_CMD_DHCP
>> >
>> > -/*
>> > - * TODO(twarren at nvidia.com) - add tegra-common-usb-gadget.h back
>> > - * breaks 64-bit build in ci_udc.c
>> > - */
>> > #include "tegra-common-usb-gadget.h"
>> > #include "tegra-common-post.h"
>> >
>> > --
>> > 1.8.2.1.610.g562af5b
>> >
>>
>> Regards,
>> Simon
>
> --
> nvpublic
Regards,
Simon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-30 23:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-30 21:09 [U-Boot] [PATCH] Tegra: P2571: Clean up config file Tom Warren
2015-07-30 21:18 ` Stephen Warren
2015-07-30 21:33 ` Simon Glass
2015-07-30 22:28 ` Tom Warren
2015-07-30 23:13 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.