From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: sun7i: Enable USB DRC on Wexler TAB7200
Date: Fri, 31 Jul 2015 10:52:21 +0200 [thread overview]
Message-ID: <55BB3745.9050200@redhat.com> (raw)
In-Reply-To: <1438277208-20721-1-git-send-email-mamlinav@gmail.com>
Hi,
On 30-07-15 19:26, Aleksei Mamlin wrote:
> Enable the otg/drc usb controller on the Wexler TAB7200 tablet.
>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
Thanks, since this depends on the axp20x-usb-power-supply bits
which are still pending I'll add this to my sunxi-wip tree, and
then send it to Maxime together with a bunch of other otg
enablement patches with the same dependency once those bits
are merged.
> ---
> arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 32 ++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> index 83c6d3f..7ec6071 100644
> --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> @@ -135,6 +135,20 @@
> status = "okay";
> };
>
> +&otg_sram {
> + status = "okay";
> +};
> +
> +&pio {
> + usb0_id_detect_pin: usb0_id_detect_pin at 0 {
> + allwinner,pins = "PH4";
> + allwinner,function = "gpio_in";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
> + };
> +};
> +
> +
The two newlines here should be only one, no need to resend
I'll fix this when I merge it.
Regards,
Hans
> #include "axp209.dtsi"
>
> ®_dcdc2 {
> @@ -162,6 +176,10 @@
> regulator-name = "avcc";
> };
>
> +®_usb0_vbus {
> + status = "okay";
> +};
> +
> ®_usb1_vbus {
> status = "okay";
> };
> @@ -176,7 +194,21 @@
> status = "okay";
> };
>
> +&usb_otg {
> + dr_mode = "otg";
> + status = "okay";
> +};
> +
> +&usb_power_supply {
> + status = "okay";
> +};
> +
> &usbphy {
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb0_id_detect_pin>;
> + usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
> + usb0_vbus_power-supply = <&usb_power_supply>;
> + usb0_vbus-supply = <®_usb0_vbus>;
> usb1_vbus-supply = <®_usb1_vbus>;
> usb2_vbus-supply = <®_usb2_vbus>;
> status = "okay";
>
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: sun7i: Enable USB DRC on Wexler TAB7200
Date: Fri, 31 Jul 2015 10:52:21 +0200 [thread overview]
Message-ID: <55BB3745.9050200@redhat.com> (raw)
In-Reply-To: <1438277208-20721-1-git-send-email-mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi,
On 30-07-15 19:26, Aleksei Mamlin wrote:
> Enable the otg/drc usb controller on the Wexler TAB7200 tablet.
>
> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Thanks, since this depends on the axp20x-usb-power-supply bits
which are still pending I'll add this to my sunxi-wip tree, and
then send it to Maxime together with a bunch of other otg
enablement patches with the same dependency once those bits
are merged.
> ---
> arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 32 ++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> index 83c6d3f..7ec6071 100644
> --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> @@ -135,6 +135,20 @@
> status = "okay";
> };
>
> +&otg_sram {
> + status = "okay";
> +};
> +
> +&pio {
> + usb0_id_detect_pin: usb0_id_detect_pin@0 {
> + allwinner,pins = "PH4";
> + allwinner,function = "gpio_in";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
> + };
> +};
> +
> +
The two newlines here should be only one, no need to resend
I'll fix this when I merge it.
Regards,
Hans
> #include "axp209.dtsi"
>
> ®_dcdc2 {
> @@ -162,6 +176,10 @@
> regulator-name = "avcc";
> };
>
> +®_usb0_vbus {
> + status = "okay";
> +};
> +
> ®_usb1_vbus {
> status = "okay";
> };
> @@ -176,7 +194,21 @@
> status = "okay";
> };
>
> +&usb_otg {
> + dr_mode = "otg";
> + status = "okay";
> +};
> +
> +&usb_power_supply {
> + status = "okay";
> +};
> +
> &usbphy {
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb0_id_detect_pin>;
> + usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
> + usb0_vbus_power-supply = <&usb_power_supply>;
> + usb0_vbus-supply = <®_usb0_vbus>;
> usb1_vbus-supply = <®_usb1_vbus>;
> usb2_vbus-supply = <®_usb2_vbus>;
> status = "okay";
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-31 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 17:26 [PATCH] ARM: dts: sun7i: Enable USB DRC on Wexler TAB7200 Aleksei Mamlin
2015-07-30 17:26 ` Aleksei Mamlin
2015-07-31 8:52 ` Hans de Goede [this message]
2015-07-31 8:52 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BB3745.9050200@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.