Re: [PATCH 2/2] iio: proximity: add support for PulsedLight LIDAR

[Vladimir Barinov <vladimir.barinov@cogentembedded.com>]

On 02.08.2015 01:22, Matt Ranostay wrote:
> On Sat, Aug 1, 2015 at 2:17 PM, Jonathan Cameron
> <jic23@jic23.retrosnub.co.uk> wrote:
>>
>>
>> On 1 August 2015 09:39:11 BST, Vladimir Barinov <vladimir.barinov@cogentembedded.com> wrote:
>>> Hi Matt,
>>>
>>> Find minor comments.
>>>
>>> On 01.08.2015 06:58, Matt Ranostay wrote:
>>>> Add support for the PulsedLight LIDAR rangefinder sensor which allows
>>>> high speed (over 300Hz) distance measurements using Barker Coding
>>> within
>>>> 40 meter range.
>>>>
>>>> Support only tested on the "blue label" rev 2, but may work using
>>> polling
>>>> at low sample frequencies on the original version.
>>>>
>>>> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
>>>> ---
>>>>    drivers/iio/proximity/Kconfig  |  13 ++
>>>>    drivers/iio/proximity/Makefile |   1 +
>>>>    drivers/iio/proximity/lidar.c  | 309
>>> +++++++++++++++++++++++++++++++++++++++++
>>> Add ABI documentation
>>> Documentation/ABI/testing/sysfs-bus-iio-proximity-lidar
>> Why?  Reading on phone so may have missed something but all ABI is standard.
>> Covered by top level docs.
> Only thing that would be documented that IIO_DISTANCE is in meters.
> But seems standard.
I understand.
I was thinking that reading in_distance_raw units needs to be docimented 
(looking on the sample sysfs-bus-iio-proximity-as3935)

Regards,
Vladimir