From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Marek Vašut" <marex@denx.de>
Subject: Re: [PATCH v4 0/2] iio: light: add support for APDS9660 sensor
Date: Sun, 2 Aug 2015 16:45:39 +0100 [thread overview]
Message-ID: <55BE3B23.8010608@kernel.org> (raw)
In-Reply-To: <CAKzfze8tccxiWTcx4DWocdnm4M=W-5fToK-ABELW-JrdKtq-iA@mail.gmail.com>
On 29/07/15 05:28, Matt Ranostay wrote:
> Jonathan,
>
> Does this solve the issues in v3 minus the apds9960_regfield_init() cleanup?
>
>
> Thanks,
>
> Matt
>
Sorry, was on holiday last week. Catching up now.
> On Sun, Jul 19, 2015 at 8:57 PM, Matt Ranostay <mranostay@gmail.com> wrote:
>> This patchset adds support for the APDS9960 ALS + proximity + gesture
>> sensor.
>>
>> Included support for the various adjustable settings and controls:
>> * Falling and rising ALS + proximity thresholds events
>> * Gain controls
>> * ALS time integration
>>
>> Changes from v3:
>> * Added interrupt client mode document reference in DT bindings
>> * Add missing dep for CONFIG_REGMAP_I2C in respective Kconfig
>> * Changed from iio_trigger_poll_chained() to irq_work queue
>> * Changed channel masks to prevent channels that can't be polled from
>> having sysfs entries
>> * Renamed regmap_field declarations with apds9660_* prefix
>> * Added available channel masks and removed unneeded buffer copy in
>> poll function
>> * Remove unneeded default regmap values in apds9960_reg_defaults
>> * Clear interrupts from ALS and proximity sensor seperately to avoid
>> race condition
>> * Changed max threshold values to a macro define, and prevent values
>> less than 0
>> * Avoid needlessly checking the APDS9960_REG_GFLVL value until we read
>> all the FIFO from the count value. Note this can save up to 32
>> superfluous i2c reads per gesture engine entry
>>
>> Matt Ranostay (2):
>> iio: light: DT binding docs for APDS9960 driver
>> iio: light: add APDS9960 ALS + promixity driver
>>
>> .../ABI/testing/sysfs-bus-iio-light-apds9960 | 7 +
>> .../devicetree/bindings/iio/light/apds9960.txt | 22 +
>> drivers/iio/light/Kconfig | 13 +
>> drivers/iio/light/Makefile | 1 +
>> drivers/iio/light/apds9960.c | 1191 ++++++++++++++++++++
>> 5 files changed, 1234 insertions(+)
>> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-light-apds9960
>> create mode 100644 Documentation/devicetree/bindings/iio/light/apds9960.txt
>> create mode 100644 drivers/iio/light/apds9960.c
>>
>> --
>> 1.9.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Matt Ranostay <mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Marek Vašut" <marex-ynQEQJNshbs@public.gmane.org>
Subject: Re: [PATCH v4 0/2] iio: light: add support for APDS9660 sensor
Date: Sun, 2 Aug 2015 16:45:39 +0100 [thread overview]
Message-ID: <55BE3B23.8010608@kernel.org> (raw)
In-Reply-To: <CAKzfze8tccxiWTcx4DWocdnm4M=W-5fToK-ABELW-JrdKtq-iA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 29/07/15 05:28, Matt Ranostay wrote:
> Jonathan,
>
> Does this solve the issues in v3 minus the apds9960_regfield_init() cleanup?
>
>
> Thanks,
>
> Matt
>
Sorry, was on holiday last week. Catching up now.
> On Sun, Jul 19, 2015 at 8:57 PM, Matt Ranostay <mranostay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> This patchset adds support for the APDS9960 ALS + proximity + gesture
>> sensor.
>>
>> Included support for the various adjustable settings and controls:
>> * Falling and rising ALS + proximity thresholds events
>> * Gain controls
>> * ALS time integration
>>
>> Changes from v3:
>> * Added interrupt client mode document reference in DT bindings
>> * Add missing dep for CONFIG_REGMAP_I2C in respective Kconfig
>> * Changed from iio_trigger_poll_chained() to irq_work queue
>> * Changed channel masks to prevent channels that can't be polled from
>> having sysfs entries
>> * Renamed regmap_field declarations with apds9660_* prefix
>> * Added available channel masks and removed unneeded buffer copy in
>> poll function
>> * Remove unneeded default regmap values in apds9960_reg_defaults
>> * Clear interrupts from ALS and proximity sensor seperately to avoid
>> race condition
>> * Changed max threshold values to a macro define, and prevent values
>> less than 0
>> * Avoid needlessly checking the APDS9960_REG_GFLVL value until we read
>> all the FIFO from the count value. Note this can save up to 32
>> superfluous i2c reads per gesture engine entry
>>
>> Matt Ranostay (2):
>> iio: light: DT binding docs for APDS9960 driver
>> iio: light: add APDS9960 ALS + promixity driver
>>
>> .../ABI/testing/sysfs-bus-iio-light-apds9960 | 7 +
>> .../devicetree/bindings/iio/light/apds9960.txt | 22 +
>> drivers/iio/light/Kconfig | 13 +
>> drivers/iio/light/Makefile | 1 +
>> drivers/iio/light/apds9960.c | 1191 ++++++++++++++++++++
>> 5 files changed, 1234 insertions(+)
>> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-light-apds9960
>> create mode 100644 Documentation/devicetree/bindings/iio/light/apds9960.txt
>> create mode 100644 drivers/iio/light/apds9960.c
>>
>> --
>> 1.9.1
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-08-02 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 3:57 [PATCH v4 0/2] iio: light: add support for APDS9660 sensor Matt Ranostay
2015-07-20 3:57 ` Matt Ranostay
2015-07-20 3:57 ` [PATCH v4 1/2] iio: light: DT binding docs for APDS9960 driver Matt Ranostay
2015-07-20 3:57 ` Matt Ranostay
2015-07-20 3:57 ` [PATCH 2/2] iio: light: add APDS9960 ALS + promixity driver Matt Ranostay
2015-07-20 3:57 ` Matt Ranostay
2015-07-29 4:28 ` [PATCH v4 0/2] iio: light: add support for APDS9660 sensor Matt Ranostay
2015-07-29 4:28 ` Matt Ranostay
2015-08-02 15:45 ` Jonathan Cameron [this message]
2015-08-02 15:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BE3B23.8010608@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.