All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Wu <josh.wu@atmel.com>
To: Ludovic Desroches <ludovic.desroches@atmel.com>,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: s.hauer@pengutronix.de, nicolas.ferre@atmel.com,
	linus.walleij@linaro.org
Subject: Re: [RFC PATCH 2/3] ARM: at91/dt: add sama5d2 pinmux
Date: Mon, 3 Aug 2015 14:40:18 +0800	[thread overview]
Message-ID: <55BF0CD2.5030204@atmel.com> (raw)
In-Reply-To: <1438355290-28255-3-git-send-email-ludovic.desroches@atmel.com>

Hi, Ludovic

On 7/31/2015 11:08 PM, Ludovic Desroches wrote:
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
>   arch/arm/boot/dts/sama5d2-pinfunc.h | 760 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 760 insertions(+)
>   create mode 100644 arch/arm/boot/dts/sama5d2-pinfunc.h
>
> diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
> new file mode 100644
> index 0000000..046d1d5
> --- /dev/null
> +++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
>

[snip...]

> +#define PIN_PB24__FLEXCOM3_IO3		PINMUX_PIN(PIN_PB24, 5, 3)
> +#define PIN_PB24__ISI_D10		PINMUX_PIN(PIN_PB24, 6, 3)

As sama5d2 use ISC, so It's better to run  s/ISI_/ISC_/ in this file, 
which is consistent with the datasheet.

Best Regards,
Josh Wu


WARNING: multiple messages have this Message-ID (diff)
From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/3] ARM: at91/dt: add sama5d2 pinmux
Date: Mon, 3 Aug 2015 14:40:18 +0800	[thread overview]
Message-ID: <55BF0CD2.5030204@atmel.com> (raw)
In-Reply-To: <1438355290-28255-3-git-send-email-ludovic.desroches@atmel.com>

Hi, Ludovic

On 7/31/2015 11:08 PM, Ludovic Desroches wrote:
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
>   arch/arm/boot/dts/sama5d2-pinfunc.h | 760 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 760 insertions(+)
>   create mode 100644 arch/arm/boot/dts/sama5d2-pinfunc.h
>
> diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
> new file mode 100644
> index 0000000..046d1d5
> --- /dev/null
> +++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
>

[snip...]

> +#define PIN_PB24__FLEXCOM3_IO3		PINMUX_PIN(PIN_PB24, 5, 3)
> +#define PIN_PB24__ISI_D10		PINMUX_PIN(PIN_PB24, 6, 3)

As sama5d2 use ISC, so It's better to run  s/ISI_/ISC_/ in this file, 
which is consistent with the datasheet.

Best Regards,
Josh Wu

WARNING: multiple messages have this Message-ID (diff)
From: Josh Wu <josh.wu@atmel.com>
To: Ludovic Desroches <ludovic.desroches@atmel.com>,
	<linux-gpio@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Cc: <s.hauer@pengutronix.de>, <nicolas.ferre@atmel.com>,
	<linus.walleij@linaro.org>
Subject: Re: [RFC PATCH 2/3] ARM: at91/dt: add sama5d2 pinmux
Date: Mon, 3 Aug 2015 14:40:18 +0800	[thread overview]
Message-ID: <55BF0CD2.5030204@atmel.com> (raw)
In-Reply-To: <1438355290-28255-3-git-send-email-ludovic.desroches@atmel.com>

Hi, Ludovic

On 7/31/2015 11:08 PM, Ludovic Desroches wrote:
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
>   arch/arm/boot/dts/sama5d2-pinfunc.h | 760 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 760 insertions(+)
>   create mode 100644 arch/arm/boot/dts/sama5d2-pinfunc.h
>
> diff --git a/arch/arm/boot/dts/sama5d2-pinfunc.h b/arch/arm/boot/dts/sama5d2-pinfunc.h
> new file mode 100644
> index 0000000..046d1d5
> --- /dev/null
> +++ b/arch/arm/boot/dts/sama5d2-pinfunc.h
>

[snip...]

> +#define PIN_PB24__FLEXCOM3_IO3		PINMUX_PIN(PIN_PB24, 5, 3)
> +#define PIN_PB24__ISI_D10		PINMUX_PIN(PIN_PB24, 6, 3)

As sama5d2 use ISC, so It's better to run  s/ISI_/ISC_/ in this file, 
which is consistent with the datasheet.

Best Regards,
Josh Wu


  reply	other threads:[~2015-08-03  6:40 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 15:08 [RFC PATCH 0/3] New Atmel PIO4 pinctrl/gpio driver Ludovic Desroches
2015-07-31 15:08 ` Ludovic Desroches
2015-07-31 15:08 ` Ludovic Desroches
2015-07-31 15:08 ` [RFC PATCH 1/3] pinctrl: introduce driver for Atmel PIO4 controller Ludovic Desroches
2015-07-31 15:08   ` Ludovic Desroches
2015-07-31 15:08   ` Ludovic Desroches
2015-07-31 15:08 ` [RFC PATCH 2/3] ARM: at91/dt: add sama5d2 pinmux Ludovic Desroches
2015-07-31 15:08   ` Ludovic Desroches
2015-07-31 15:08   ` Ludovic Desroches
2015-08-03  6:40   ` Josh Wu [this message]
2015-08-03  6:40     ` Josh Wu
2015-08-03  6:40     ` Josh Wu
2015-08-03  6:59     ` Ludovic Desroches
2015-08-03  6:59       ` Ludovic Desroches
2015-08-03  6:59       ` Ludovic Desroches
2015-07-31 15:08 ` [RFC PATCH 3/3] ARM: at91/dt: add pinctrl Ludovic Desroches
2015-07-31 15:08   ` Ludovic Desroches
2015-07-31 15:08   ` Ludovic Desroches
2015-08-05  7:31 ` [RFC PATCH 0/3] New Atmel PIO4 pinctrl/gpio driver Sascha Hauer
2015-08-05  7:31   ` Sascha Hauer
2015-08-10  6:53   ` Ludovic Desroches
2015-08-10  6:53     ` Ludovic Desroches
2015-08-10  6:53     ` Ludovic Desroches
2015-08-20  7:05     ` Sascha Hauer
2015-08-20  7:05       ` Sascha Hauer
2015-08-20 12:44       ` Ludovic Desroches
2015-08-20 12:44         ` Ludovic Desroches
2015-08-20 12:44         ` Ludovic Desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BF0CD2.5030204@atmel.com \
    --to=josh.wu@atmel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@atmel.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.