From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tomer Barletz <barletz@gmail.com>
Cc: tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Check return code from pdc20621_i2c_read()
Date: Mon, 3 Aug 2015 18:42:02 +0300 [thread overview]
Message-ID: <55BF8BCA.40602@cogentembedded.com> (raw)
In-Reply-To: <CAO-S75DznUxvYg9RPcDOaw1H8XK8MuXxFGOARVt-5OtW2_RJnA@mail.gmail.com>
On 08/02/2015 08:55 PM, Tomer Barletz wrote:
>> Please use pr_err() instead. And "0x%d" makes no sense at all, please use "%#x" instead.
> Yeah, not sure what I was drinking before writing this 0x%d thing...
> Regarding the pr_err() - it is not used at all in this file, and
> printk() is used instead.
The problem is these printk() calls cause complaints from
scripts/checkpatch.pl.
> Wouldn't it be better to leave it with
> printk for this change, then have another change that replaces
> printk()s with pr_err()s?
Probably yes...
> --Tomer
MBR, Sergei
next prev parent reply other threads:[~2015-08-03 15:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 10:12 [PATCH] Check return code from pdc20621_i2c_read() Tomer Barletz
2015-08-02 11:09 ` Sergei Shtylyov
[not found] ` <CAO-S75CRyh=FPbeTJMZWiYTvpd_wn57f4eGQgOHW2p16+9ANhQ@mail.gmail.com>
2015-08-02 17:55 ` Tomer Barletz
2015-08-02 18:03 ` Joe Perches
2015-08-02 20:22 ` Joe Perches
2015-08-03 15:42 ` Sergei Shtylyov [this message]
2015-08-03 15:52 ` Sergei Shtylyov
2015-08-03 18:46 ` [PATCH] sata_sx4: " Tomer Barletz
2015-08-03 18:52 ` Sergei Shtylyov
2015-08-03 19:04 ` Tomer Barletz
2015-08-03 19:09 ` Joe Perches
2015-08-03 19:19 ` Sergei Shtylyov
2015-08-03 19:18 ` Tomer Barletz
2015-08-06 16:40 ` Tejun Heo
2015-08-03 6:06 ` [PATCH] " Tomer Barletz
2015-08-03 15:40 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BF8BCA.40602@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=barletz@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.