All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tomer Barletz <barletz@gmail.com>
Cc: tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sata_sx4: Check return code from pdc20621_i2c_read()
Date: Mon, 3 Aug 2015 22:19:10 +0300	[thread overview]
Message-ID: <55BFBEAE.6030707@cogentembedded.com> (raw)
In-Reply-To: <CAO-S75BnJJvNsEN3xFrtO9xO=4=UnwJeL6UHLeMbOaSyjk4Htw@mail.gmail.com>

On 08/03/2015 10:04 PM, Tomer Barletz wrote:

    Please don't top-post.

> I see how it makes sense to add a tab to align with the previous line
> of code, as it will always look similar in all editors, no matter how
> their tab character is set up to be.
> However, adding more tabs will just mess up editors that are not set
> up with 8-space width tabs.

> Is this a bug in checkpatch.pl, or are we saying everyone should have
> their editor set to 8-spaces width tabs?

    The latter. :-)

MBR, Sergei


  parent reply	other threads:[~2015-08-03 19:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-02 10:12 [PATCH] Check return code from pdc20621_i2c_read() Tomer Barletz
2015-08-02 11:09 ` Sergei Shtylyov
     [not found]   ` <CAO-S75CRyh=FPbeTJMZWiYTvpd_wn57f4eGQgOHW2p16+9ANhQ@mail.gmail.com>
2015-08-02 17:55     ` Tomer Barletz
2015-08-02 18:03       ` Joe Perches
2015-08-02 20:22       ` Joe Perches
2015-08-03 15:42       ` Sergei Shtylyov
2015-08-03 15:52         ` Sergei Shtylyov
2015-08-03 18:46           ` [PATCH] sata_sx4: " Tomer Barletz
2015-08-03 18:52             ` Sergei Shtylyov
2015-08-03 19:04               ` Tomer Barletz
2015-08-03 19:09                 ` Joe Perches
2015-08-03 19:19                 ` Sergei Shtylyov [this message]
2015-08-03 19:18               ` Tomer Barletz
2015-08-06 16:40                 ` Tejun Heo
2015-08-03  6:06     ` [PATCH] " Tomer Barletz
2015-08-03 15:40       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BFBEAE.6030707@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=barletz@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.