Re: [PATCH v2 3/3] ARM: dts: dra7: Add scm_conf@1c04 node

[Kishon Vijay Abraham I <kishon@ti.com>]

Hi Roger,

On Monday 27 July 2015 03:57 PM, Roger Quadros wrote:
> This region contains CTRL_CORE_SMA_SW2..9 registers which
> are not specific to any domain and can be reasonably
> accessed via syscon driver.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  arch/arm/boot/dts/dra7.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 913032b..43b5074 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -149,6 +149,13 @@
>  					pinctrl-single,register-width = <32>;
>  					pinctrl-single,function-mask = <0x3fffffff>;
>  				};
> +
> +				scm_conf1: scm_conf@1c04 {
> +					compatible = "syscon";
> +					reg = <0x1c04 0x0020>;
> +					#address-cells = <1>;
> +					#size-cells = <1>;

Why do you need address-cells and size-cells property here? AFAIK it is usually
used to decode childs reg property.

Thanks
Kishon