From: Michael Wood <michael.g.wood@intel.com>
To: "Barros Pena, Belen" <belen.barros.pena@intel.com>,
"toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: [review-request] michaelw/toaster/fix-typeahead-behaviour
Date: Mon, 03 Aug 2015 18:48:57 +0100 [thread overview]
Message-ID: <55BFA989.4040406@intel.com> (raw)
In-Reply-To: <D1E55B78.614C6%belen.barros.pena@intel.com>
Please ignore this review-request
I will submit a V2 as there was a typo in the models.py util function
that Belen discovered. We have also talked about how best to do the
typeahead matching behaviour so that can be done to closer to the design
without a whole lot of extra work.
Thanks,
Michael
On 03/08/15 17:58, Barros Pena, Belen wrote:
>
> On 03/08/2015 17:21, "toaster-bounces@yoctoproject.org on behalf of
> Michael Wood" <toaster-bounces@yoctoproject.org on behalf of
> michael.g.wood@intel.com> wrote:
>
>> This branch brings back the correct typeahead behaviour as a modular
>> widget.
>>
>> - New typeahead widget
>> - Switch to Implementation of widget in frontend
>> - Utility functions in the models so that the querysets which are used
>> for the ToasterTables are the same queries that are used for the
>> typeaheads.
>> - Added/Fixed typeahead widget unit tests
>>
>> see also https://bugzilla.yoctoproject.org/show_bug.cgi?id=7152
> All the typeaheads work, although not as required by the design document
> attached to 7152.
>
> I think we should send this upstream though, and fix 7152 separately.
>
> Thanks!
>
> Belén
>
>> * a465b19 bitbake: toastergui: tests Fix and more comprehensive
>> typeahead unittest
>> * 4c71133 bitbake: toastergui: views Standardise the fields project
>> layer response
>> * 592339b bitbake: toasterui: views Remove unused xhr_typeahead view
>> definition
>> * dc7d764 bitbake: toastergui: libtoaster Throw an exception no url is
>> specified
>> * 94c3f72 bitbake: toastergui: Switch to using the new toaster typeahead
>> widget
>> * ead8702 bitbake: toastergui: Add typeaheads for layers, machines and
>> recipes
>> * 09c6772 bitbake: toastergui: widgets Add a typeahead widget
>> * 9309429 bitbake: toastergui: tables Use util functions for the common
>> querysets
>> * 0ba647b bitbake: toaster: orm Add util functions to return common
>> querysets
>> * 691696f bitbake: toaster: orm Add util function to return the url to
>> layerversion
>>
>>
>>
>>
>> --
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster
prev parent reply other threads:[~2015-08-03 17:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 16:21 [review-request] michaelw/toaster/fix-typeahead-behaviour Michael Wood
2015-08-03 16:58 ` Barros Pena, Belen
2015-08-03 17:48 ` Michael Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BFA989.4040406@intel.com \
--to=michael.g.wood@intel.com \
--cc=belen.barros.pena@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.