From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement
Date: Tue, 4 Aug 2015 13:03:17 +0300 [thread overview]
Message-ID: <55C08DE5.3060106@cogentembedded.com> (raw)
In-Reply-To: <21701034f1472a3d154c77dd8d8be017565885f6.1438678566.git.skarajga@visteon.com>
Hello.
On 8/4/2015 12:12 PM, Karajgaonkar, Saurabh (S.) wrote:
> From: Saurabh Karajgaonkar <skarajga@visteon.com>
> Replace redundant variable use in return statement.
> Signed-off-by: Saurabh Karajgaonkar <skarajga@visteon.com>
> ---
> drivers/usb/misc/ftdi-elan.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
> diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c
> index 8ab1f8f..1545f12 100644
> --- a/drivers/usb/misc/ftdi-elan.c
> +++ b/drivers/usb/misc/ftdi-elan.c
> @@ -2568,11 +2568,8 @@ static int ftdi_elan_close_controller(struct usb_ftdi *ftdi, int fn)
> 0x00);
> if (UxxxStatus)
> return UxxxStatus;
> - UxxxStatus = ftdi_elan_read_config(ftdi, activePCIfn | reg, 0,
> + return ftdi_elan_read_config(ftdi, activePCIfn | reg, 0,
> &pcidata);
Please keep the continuation line aligned by starting it under 'ftdi'.
[...]
> @@ -2695,11 +2692,8 @@ static int ftdi_elan_setupOHCI(struct usb_ftdi *ftdi)
> }
> }
> if (ftdi->function > 0) {
> - UxxxStatus = ftdi_elan_setup_controller(ftdi,
> + return ftdi_elan_setup_controller(ftdi,
> ftdi->function - 1);
Likewise.
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Karajgaonkar, Saurabh (S.)" <skarajga@visteon.com>,
"srinivas.kandagatla@gmail.com" <srinivas.kandagatla@gmail.com>,
"maxime.coquelin@st.com" <maxime.coquelin@st.com>,
"patrice.chotard@st.com" <patrice.chotard@st.com>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
"balbi@ti.com" <balbi@ti.com>,
"johan@kernel.org" <johan@kernel.org>,
"Julia.Lawall@lip6.fr" <Julia.Lawall@lip6.fr>,
"khilman@linaro.org" <khilman@linaro.org>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"pmladek@suse.cz" <pmladek@suse.cz>,
"wsa@the-dreams.de" <wsa@the-dreams.de>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@stlinux.com" <kernel@stlinux.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement
Date: Tue, 4 Aug 2015 13:03:17 +0300 [thread overview]
Message-ID: <55C08DE5.3060106@cogentembedded.com> (raw)
In-Reply-To: <21701034f1472a3d154c77dd8d8be017565885f6.1438678566.git.skarajga@visteon.com>
Hello.
On 8/4/2015 12:12 PM, Karajgaonkar, Saurabh (S.) wrote:
> From: Saurabh Karajgaonkar <skarajga@visteon.com>
> Replace redundant variable use in return statement.
> Signed-off-by: Saurabh Karajgaonkar <skarajga@visteon.com>
> ---
> drivers/usb/misc/ftdi-elan.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
> diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c
> index 8ab1f8f..1545f12 100644
> --- a/drivers/usb/misc/ftdi-elan.c
> +++ b/drivers/usb/misc/ftdi-elan.c
> @@ -2568,11 +2568,8 @@ static int ftdi_elan_close_controller(struct usb_ftdi *ftdi, int fn)
> 0x00);
> if (UxxxStatus)
> return UxxxStatus;
> - UxxxStatus = ftdi_elan_read_config(ftdi, activePCIfn | reg, 0,
> + return ftdi_elan_read_config(ftdi, activePCIfn | reg, 0,
> &pcidata);
Please keep the continuation line aligned by starting it under 'ftdi'.
[...]
> @@ -2695,11 +2692,8 @@ static int ftdi_elan_setupOHCI(struct usb_ftdi *ftdi)
> }
> }
> if (ftdi->function > 0) {
> - UxxxStatus = ftdi_elan_setup_controller(ftdi,
> + return ftdi_elan_setup_controller(ftdi,
> ftdi->function - 1);
Likewise.
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-08-04 10:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 9:07 [PATCH 0/9] usb: Simplify return statements Karajgaonkar, Saurabh (S.)
2015-08-04 9:07 ` Karajgaonkar, Saurabh (S.)
2015-08-04 9:08 ` [PATCH 1/9] usb: phy: phy-mxs-usb: Simplify return statement Karajgaonkar, Saurabh (S.)
2015-08-04 9:08 ` Karajgaonkar, Saurabh (S.)
2015-08-04 9:09 ` [PATCH 2/9] usb: phy: phy-keystone: " Karajgaonkar, Saurabh (S.)
2015-08-04 9:09 ` Karajgaonkar, Saurabh (S.)
2015-08-04 9:09 ` [PATCH 3/9] usb: musb: musb_dsps: " Karajgaonkar, Saurabh (S.)
2015-08-04 9:09 ` Karajgaonkar, Saurabh (S.)
2015-08-04 9:10 ` [PATCH 4/9] usb: host: ehci-st: " Karajgaonkar, Saurabh (S.)
2015-08-04 9:10 ` Karajgaonkar, Saurabh (S.)
2015-08-04 12:23 ` Patrice Chotard
2015-08-04 12:23 ` Patrice Chotard
2015-08-04 9:10 ` [PATCH 5/9] usb: host: oxu210hp-hcd: " Karajgaonkar, Saurabh (S.)
2015-08-04 9:10 ` Karajgaonkar, Saurabh (S.)
2015-08-04 9:11 ` [PATCH 6/9] usb: host: u132-hcd: " Karajgaonkar, Saurabh (S.)
2015-08-04 9:11 ` Karajgaonkar, Saurabh (S.)
2015-08-04 9:11 ` [PATCH 7/9] usb: host: xhci: " Karajgaonkar, Saurabh (S.)
2015-08-04 9:11 ` Karajgaonkar, Saurabh (S.)
2015-08-04 9:11 ` [PATCH 8/9] usb: serial: mxuport: " Karajgaonkar, Saurabh (S.)
2015-08-04 9:11 ` Karajgaonkar, Saurabh (S.)
2015-08-04 9:12 ` [PATCH 9/9] usb: misc: ftdi-elan: " Karajgaonkar, Saurabh (S.)
2015-08-04 9:12 ` Karajgaonkar, Saurabh (S.)
2015-08-04 10:03 ` Sergei Shtylyov [this message]
2015-08-04 10:03 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C08DE5.3060106@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.