Re: [PATCH v7 3/8] ACPI: Decouple ACPI idle and ACPI processor drivers

[Sudeep Holla <sudeep.holla@arm.com>]

On 03/08/15 18:40, Ashwin Chaugule wrote:
> On 20 July 2015 at 10:21, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>>
>> On 09/07/15 19:04, Ashwin Chaugule wrote:
>>>
>>> This patch introduces a new Kconfig symbol, ACPI_PROCESSOR_IDLE,
>>> which is auto selected by architectures which support the ACPI
>>> based C states for CPU Idle management.
>>>
>>> The processor_idle driver in its present form contains declarations
>>> specific to X86 and IA64. Since there are no reasonable defaults
>>> for other architectures e.g. ARM64, the driver is selected only by
>>> the arch/x86/Kconfig.
>>>
>>> This helps in decoupling the ACPI processor_driver from the ACPI
>>> processor_idle driver which is useful for the upcoming alternative
>>> patchwork for controlling CPU Performance (CPPC) and CPU Idle (LPI).
>>>
>>> Signed-off-by: Ashwin Chaugule <ashwin.chaugule@linaro.org>
>>> ---
>>>    drivers/acpi/Kconfig     |  6 +++++-
>>>    drivers/acpi/Makefile    |  3 ++-
>>>    include/acpi/processor.h | 26 ++++++++++++++++++++++++--
>>>    3 files changed, 31 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
>>> index 00748dc..8a60b6e 100644
>>> --- a/drivers/acpi/Kconfig
>>> +++ b/drivers/acpi/Kconfig
>>> @@ -177,9 +177,13 @@ config ACPI_CPU_FREQ_PSS
>>>            monitoring. It is required by several flavors of cpufreq
>>>            performance-state drivers.
>>>
>>> +config ACPI_PROCESSOR_IDLE
>>> +       def_bool y
>>> +       depends on X86 || IA64
>>> +
>>
>>
>> In general, you need to split this series so that initially few patches
>> deal with all the existing Kconfig fix-ups and then introduce
>> PCC/PSS/CPPC related stuffs. That would help me rebase and test _LPI
>> support.
>
> Hm. I tried to maintain bisectability and make it easier for you to
> rebase LPI patchwork too. Let me see if I can revisit now that I'm
> back from vacation. :)
>

How about you just drop any idle related changes so that I will handle
that to keep it simple.

Regards,
Sudeep