All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-input: reset device during remove
Date: Wed, 05 Aug 2015 16:18:20 +0800	[thread overview]
Message-ID: <55C1C6CC.9030108@redhat.com> (raw)
In-Reply-To: <20150805104654-mutt-send-email-mst@redhat.com>



On 08/05/2015 03:56 PM, Michael S. Tsirkin wrote:
> On Wed, Aug 05, 2015 at 03:20:18PM +0800, Jason Wang wrote:
>> > Spec requires a device reset during cleanup, so do it and avoid warn
>> > in virtio core.
>> > 
>> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> OK but now that I look at this driver, that's not enough.
>
> Need to also detach and free unused buffers, otherwise
> we leak memory in evt and sts queues.

Probably only sts. For evt queue, all buffer it used was an array
embedded in virtio_input structure (vi->evts[])

WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, kraxel@redhat.com
Subject: Re: [PATCH] virtio-input: reset device during remove
Date: Wed, 05 Aug 2015 16:18:20 +0800	[thread overview]
Message-ID: <55C1C6CC.9030108@redhat.com> (raw)
In-Reply-To: <20150805104654-mutt-send-email-mst@redhat.com>



On 08/05/2015 03:56 PM, Michael S. Tsirkin wrote:
> On Wed, Aug 05, 2015 at 03:20:18PM +0800, Jason Wang wrote:
>> > Spec requires a device reset during cleanup, so do it and avoid warn
>> > in virtio core.
>> > 
>> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> OK but now that I look at this driver, that's not enough.
>
> Need to also detach and free unused buffers, otherwise
> we leak memory in evt and sts queues.

Probably only sts. For evt queue, all buffer it used was an array
embedded in virtio_input structure (vi->evts[])

  reply	other threads:[~2015-08-05  8:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05  7:20 [PATCH] virtio-input: reset device during remove Jason Wang
2015-08-05  7:56 ` Michael S. Tsirkin
2015-08-05  8:18   ` Jason Wang [this message]
2015-08-05  8:18     ` Jason Wang
2015-08-05  7:56 ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2015-08-05  7:20 Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C1C6CC.9030108@redhat.com \
    --to=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.