From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-v2 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1
Date: Wed, 05 Aug 2015 14:17:53 +0530 [thread overview]
Message-ID: <55C1CDB9.5010106@linaro.org> (raw)
In-Reply-To: <20150723155432.GV3436@x1>
On Thursday 23 July 2015 09:24 PM, Lee Jones wrote:
> On Tue, 21 Jul 2015, Vaibhav Hiremath wrote:
>
>> 88PM860 device supports dual phase mode on BUCK1 output.
>> In normal usecase, BUCK1A and BUCK1B operates independently with 3A
>> capacity. And they both can work as a dual phase providing 6A capacity.
>>
>> This patch updates the regulator driver to read the respective
>> DT property and enable dual-phase mode on BUCK1.
>>
>> Note that, this is init time (one time) initialization.
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>> ---
>> drivers/regulator/88pm800.c | 31 +++++++++++++++++++++++++++++++
>> include/linux/mfd/88pm80x.h | 3 +++
>> 2 files changed, 34 insertions(+)
>
> [...]
>
>> diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
>> index a92d173..05d9bad 100644
>> --- a/include/linux/mfd/88pm80x.h
>> +++ b/include/linux/mfd/88pm80x.h
>> @@ -295,6 +295,9 @@ enum {
>> #define PM860_BUCK4_MISC2 (0x82)
>> #define PM860_BUCK4_FULL_DRV BIT(2)
>>
>> +#define PM860_BUCK1_MISC (0x8E)
>
> Why the over-bracketing?
>
No specific reason, just wanted to be consistent with other definitions
in the file.
Anyway, will remove it in V3.
Thanks,
Vaibhav
WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, broonie@kernel.org,
k.kozlowski@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH-v2 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1
Date: Wed, 05 Aug 2015 14:17:53 +0530 [thread overview]
Message-ID: <55C1CDB9.5010106@linaro.org> (raw)
In-Reply-To: <20150723155432.GV3436@x1>
On Thursday 23 July 2015 09:24 PM, Lee Jones wrote:
> On Tue, 21 Jul 2015, Vaibhav Hiremath wrote:
>
>> 88PM860 device supports dual phase mode on BUCK1 output.
>> In normal usecase, BUCK1A and BUCK1B operates independently with 3A
>> capacity. And they both can work as a dual phase providing 6A capacity.
>>
>> This patch updates the regulator driver to read the respective
>> DT property and enable dual-phase mode on BUCK1.
>>
>> Note that, this is init time (one time) initialization.
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>> ---
>> drivers/regulator/88pm800.c | 31 +++++++++++++++++++++++++++++++
>> include/linux/mfd/88pm80x.h | 3 +++
>> 2 files changed, 34 insertions(+)
>
> [...]
>
>> diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
>> index a92d173..05d9bad 100644
>> --- a/include/linux/mfd/88pm80x.h
>> +++ b/include/linux/mfd/88pm80x.h
>> @@ -295,6 +295,9 @@ enum {
>> #define PM860_BUCK4_MISC2 (0x82)
>> #define PM860_BUCK4_FULL_DRV BIT(2)
>>
>> +#define PM860_BUCK1_MISC (0x8E)
>
> Why the over-bracketing?
>
No specific reason, just wanted to be consistent with other definitions
in the file.
Anyway, will remove it in V3.
Thanks,
Vaibhav
next prev parent reply other threads:[~2015-08-05 8:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 16:23 [PATCH-v2 0/2] regulator: 88pm800: Add dual phase mode support on BUCK1 Vaibhav Hiremath
2015-07-21 16:23 ` Vaibhav Hiremath
2015-07-21 16:23 ` Vaibhav Hiremath
2015-07-21 16:23 ` [PATCH-v2 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable Vaibhav Hiremath
2015-07-21 16:23 ` Vaibhav Hiremath
2015-07-23 15:53 ` Lee Jones
2015-07-23 15:53 ` Lee Jones
2015-07-23 15:53 ` Lee Jones
2015-08-05 8:49 ` Vaibhav Hiremath
2015-08-05 8:49 ` Vaibhav Hiremath
2015-07-21 16:23 ` [PATCH-v2 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1 Vaibhav Hiremath
2015-07-21 16:23 ` Vaibhav Hiremath
2015-07-23 4:51 ` Krzysztof Kozlowski
2015-07-23 4:51 ` Krzysztof Kozlowski
2015-07-23 4:51 ` Krzysztof Kozlowski
2015-08-05 8:45 ` Vaibhav Hiremath
2015-08-05 8:45 ` Vaibhav Hiremath
2015-08-05 8:45 ` Vaibhav Hiremath
2015-08-05 23:58 ` Krzysztof Kozlowski
2015-08-05 23:58 ` Krzysztof Kozlowski
2015-08-06 6:03 ` Vaibhav Hiremath
2015-08-06 6:03 ` Vaibhav Hiremath
2015-08-06 6:03 ` Vaibhav Hiremath
2015-08-06 6:06 ` Krzysztof Kozlowski
2015-08-06 6:06 ` Krzysztof Kozlowski
2015-07-23 15:54 ` Lee Jones
2015-07-23 15:54 ` Lee Jones
2015-08-05 8:47 ` Vaibhav Hiremath [this message]
2015-08-05 8:47 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C1CDB9.5010106@linaro.org \
--to=vaibhav.hiremath@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.