From: julien.grall@citrix.com (Julien Grall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address
Date: Wed, 5 Aug 2015 11:31:09 +0100 [thread overview]
Message-ID: <55C1E5ED.10103@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1508051041060.11337@kaball.uk.xensource.com>
Hi Stefano,
On 05/08/15 10:49, Stefano Stabellini wrote:
>> /* VIRT <-> MACHINE conversion */
>> #define virt_to_mfn(v) (pfn_to_mfn(virt_to_pfn(v)))
>> @@ -96,7 +115,7 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn)
>>
>> bool xen_arch_need_swiotlb(struct device *dev,
>> unsigned long pfn,
>> - unsigned long mfn);
>> + unsigned long dfn);
>> unsigned long xen_get_swiotlb_free_pages(unsigned int order);
>
> You missed a bunch of dfn->bfn renamings.
Sorry, I forgot to double check that before sending the patch. I will
fix it in the next version.
> Aside from those and the commit message error:
>
> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Thank you!
Regards,
--
Julien Grall
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: <xen-devel@lists.xenproject.org>, <ian.campbell@citrix.com>,
<linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<x86@kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address
Date: Wed, 5 Aug 2015 11:31:09 +0100 [thread overview]
Message-ID: <55C1E5ED.10103@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1508051041060.11337@kaball.uk.xensource.com>
Hi Stefano,
On 05/08/15 10:49, Stefano Stabellini wrote:
>> /* VIRT <-> MACHINE conversion */
>> #define virt_to_mfn(v) (pfn_to_mfn(virt_to_pfn(v)))
>> @@ -96,7 +115,7 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn)
>>
>> bool xen_arch_need_swiotlb(struct device *dev,
>> unsigned long pfn,
>> - unsigned long mfn);
>> + unsigned long dfn);
>> unsigned long xen_get_swiotlb_free_pages(unsigned int order);
>
> You missed a bunch of dfn->bfn renamings.
Sorry, I forgot to double check that before sending the patch. I will
fix it in the next version.
> Aside from those and the commit message error:
>
> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Thank you!
Regards,
--
Julien Grall
next prev parent reply other threads:[~2015-08-05 10:31 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 18:12 [PATCH v2 0/8] Use correctly the Xen memory terminologies in Linux Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` [PATCH v2 1/8] arm/xen: Remove helpers which are PV specific Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` [PATCH v2 2/8] xen: Make clear that swiotlb and biomerge are dealing with DMA address Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-05 9:49 ` Stefano Stabellini
2015-08-05 9:49 ` Stefano Stabellini
2015-08-05 10:31 ` Julien Grall [this message]
2015-08-05 10:31 ` Julien Grall
2015-08-05 10:31 ` Julien Grall
2015-08-05 9:49 ` Stefano Stabellini
2015-08-04 18:12 ` [PATCH v2 3/8] arm/xen: implement correctly pfn_to_mfn Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-05 9:52 ` Stefano Stabellini
2015-08-05 9:52 ` Stefano Stabellini
2015-08-05 9:52 ` Stefano Stabellini
2015-08-04 18:12 ` [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 23:16 ` Boris Ostrovsky
2015-08-04 23:16 ` Boris Ostrovsky
2015-08-04 23:16 ` Boris Ostrovsky
2015-08-04 23:16 ` Boris Ostrovsky
2015-08-05 10:07 ` Stefano Stabellini
2015-08-05 10:07 ` Stefano Stabellini
2015-08-05 10:07 ` Stefano Stabellini
2015-08-05 10:07 ` Stefano Stabellini
2015-08-05 10:07 ` Stefano Stabellini
2015-08-05 10:51 ` Julien Grall
2015-08-05 10:51 ` Julien Grall
2015-08-05 10:51 ` Julien Grall
2015-08-05 10:51 ` Julien Grall
2015-08-05 10:51 ` Julien Grall
2015-08-05 12:19 ` Boris Ostrovsky
2015-08-05 12:19 ` Boris Ostrovsky
2015-08-05 12:19 ` Boris Ostrovsky
2015-08-05 12:19 ` Boris Ostrovsky
2015-08-05 12:33 ` [Xen-devel] " Julien Grall
2015-08-05 12:33 ` Julien Grall
2015-08-05 12:33 ` Julien Grall
2015-08-05 12:33 ` Julien Grall
2015-08-05 12:33 ` Julien Grall
2015-08-05 12:44 ` Boris Ostrovsky
2015-08-05 12:44 ` Boris Ostrovsky
2015-08-05 12:44 ` Boris Ostrovsky
2015-08-05 12:44 ` Boris Ostrovsky
2015-08-05 12:44 ` Boris Ostrovsky
2015-08-05 12:33 ` Julien Grall
2015-08-05 12:19 ` Boris Ostrovsky
2015-08-05 10:51 ` Julien Grall
2015-08-04 23:16 ` Boris Ostrovsky
2015-08-05 10:08 ` Stefano Stabellini
2015-08-05 10:08 ` Stefano Stabellini
2015-08-05 10:08 ` Stefano Stabellini
2015-08-05 10:08 ` Stefano Stabellini
2015-08-05 16:52 ` Dmitry Torokhov
2015-08-05 16:52 ` Dmitry Torokhov
2015-08-05 16:52 ` Dmitry Torokhov
2015-08-05 16:52 ` Dmitry Torokhov
2015-08-05 16:52 ` Dmitry Torokhov
2015-08-05 10:08 ` Stefano Stabellini
2015-08-05 17:01 ` Wei Liu
2015-08-05 17:01 ` Wei Liu
2015-08-05 17:01 ` Wei Liu
2015-08-05 17:01 ` Wei Liu
2015-08-05 17:01 ` Wei Liu
2015-08-05 17:01 ` Wei Liu
2015-08-06 11:00 ` [Xen-devel] " Julien Grall
2015-08-06 11:00 ` Julien Grall
2015-08-06 11:00 ` Julien Grall
2015-08-06 11:00 ` Julien Grall
2015-08-06 11:00 ` Julien Grall
2015-08-06 11:06 ` Stefano Stabellini
2015-08-06 11:06 ` Stefano Stabellini
2015-08-06 11:06 ` Stefano Stabellini
2015-08-06 11:06 ` Stefano Stabellini
2015-08-06 11:06 ` Stefano Stabellini
2015-08-06 11:17 ` Julien Grall
2015-08-06 11:17 ` Julien Grall
2015-08-06 11:17 ` Julien Grall
2015-08-06 11:17 ` Julien Grall
2015-08-06 14:20 ` Stefano Stabellini
2015-08-06 14:20 ` Stefano Stabellini
2015-08-06 14:20 ` Stefano Stabellini
2015-08-06 14:20 ` Stefano Stabellini
2015-08-06 14:20 ` Stefano Stabellini
2015-08-06 14:20 ` Stefano Stabellini
2015-08-06 11:17 ` Julien Grall
2015-08-06 11:06 ` Stefano Stabellini
2015-08-06 11:00 ` Julien Grall
2015-08-04 18:12 ` [PATCH v2 5/8] xen/tmem: Use page_to_gfn rather than pfn_to_gfn Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-05 10:01 ` Stefano Stabellini
2015-08-05 10:01 ` Stefano Stabellini
2015-08-04 18:12 ` [PATCH v2 6/8] video/xen-fbfront: Further s/MFN/GFN clean-up Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` [PATCH v2 7/8] hvc/xen: " Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` [PATCH v2 8/8] xen/privcmd: Further s/MFN/GFN/ clean-up Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
2015-08-04 18:12 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C1E5ED.10103@citrix.com \
--to=julien.grall@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.