Re: [PATCH 1/3] efinet: handle get_status() properly

[Josef Bacik <jbacik@fb.com>]

On 08/05/2015 04:39 PM, Josef Bacik wrote:
> On 08/05/2015 04:32 PM, Vladimir 'phcoder' Serbinenko wrote:
>> This patch improperly assumes that GRUB is the only thing in EFI that
>> transmits. Your patch surely fixed your machine but likely breaks some
>> other machines. Could you instead make an explicit check for (void *)1
>> and add a comment on which machine it's necessary?
>>
>
> Yeah this is kind of a crap trade-off I know.  The problem is this is
> just on one box I'm testing with, we've got _a metric shit ton_ of
> boxes, if one of them returns 0x2 suddenly it can't be provisioned.  I
> realize this is racey with other things on UEFI doing stuff, but I don't
> have a better answer.  Maybe a range check for obviously bogus
> addresses?  Or maybe once we get a non-NULL from GetStatus() we call it
> again until we get a NULL from GetStatus()?  Thanks,
>

Could also just add a variable along the lines of 
"net_known_shitty_efi_firmware" and only do this if that variable is 
set, that way it's the users choice to work around this or not.  Thanks,

Josef