Re: [PATCH 1/3] efinet: handle get_status() properly

[Josef Bacik <jbacik@fb.com>]

On 08/05/2015 11:42 PM, Andrei Borzenkov wrote:
> В Wed, 5 Aug 2015 22:32:13 +0200
> "Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com> пишет:
>
>> This patch improperly assumes that GRUB is the only thing in EFI that
>> transmits.
>
> Actually since recently we try to ensure that grub *is* the only user
> of network interface.
>
>>            Your patch surely fixed your machine but likely breaks some
>> other machines. Could you instead make an explicit check for (void *)1 and
>> add a comment on which machine it's necessary?
>
> Yes, this patch should add verbose comment to code explaining a) what
> problem it tries to fix and b) why ignoring EFI specification is
> justified here. Also mention actual hardware/firmware implementation
> where this bug happens for future reference.
>
> Looking at other implementations gPXE opens SNP non-exclusively and
> explicitly checks returned address. That corresponds to what grub
> did in the past. iPXE opens SNP exclusively and assumes anything !=
> NULL means transmit completed (it seems to start off with gPXE model).

Ok I'll add a comment and resend the patch as it is.  Thanks,

Josef