All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Sagi Grimberg <sagig@mellanox.com>, <linux-rdma@vger.kernel.org>,
	<linux-nfs@vger.kernel.org>, <target-devel@vger.kernel.org>
Subject: Re: [PATCH for-4.3 06/15] xprtrdma, svcrdma: Convert to ib_alloc_mr
Date: Thu, 6 Aug 2015 10:22:23 -0400	[thread overview]
Message-ID: <55C36D9F.1040705@Netapp.com> (raw)
In-Reply-To: <1438241568-3685-7-git-send-email-sagig@mellanox.com>

This looks good to me:

	Signed-off-by:  Anna Schumaker <Anna.Schumaker@Netapp.com>

Thanks,
Anna

On 07/30/2015 03:32 AM, Sagi Grimberg wrote:
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
> ---
>  net/sunrpc/xprtrdma/frwr_ops.c           | 6 +++---
>  net/sunrpc/xprtrdma/svc_rdma_transport.c | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xprtrdma/frwr_ops.c
> index 63f282e..d6653f5 100644
> --- a/net/sunrpc/xprtrdma/frwr_ops.c
> +++ b/net/sunrpc/xprtrdma/frwr_ops.c
> @@ -117,7 +117,7 @@ __frwr_recovery_worker(struct work_struct *work)
>  	if (ib_dereg_mr(r->r.frmr.fr_mr))
>  		goto out_fail;
>  
> -	r->r.frmr.fr_mr = ib_alloc_fast_reg_mr(pd, depth);
> +	r->r.frmr.fr_mr = ib_alloc_mr(pd, IB_MR_TYPE_MEM_REG, depth);
>  	if (IS_ERR(r->r.frmr.fr_mr))
>  		goto out_fail;
>  
> @@ -148,7 +148,7 @@ __frwr_init(struct rpcrdma_mw *r, struct ib_pd *pd, struct ib_device *device,
>  	struct rpcrdma_frmr *f = &r->r.frmr;
>  	int rc;
>  
> -	f->fr_mr = ib_alloc_fast_reg_mr(pd, depth);
> +	f->fr_mr = ib_alloc_mr(pd, IB_MR_TYPE_MEM_REG, depth);
>  	if (IS_ERR(f->fr_mr))
>  		goto out_mr_err;
>  	f->fr_pgl = ib_alloc_fast_reg_page_list(device, depth);
> @@ -158,7 +158,7 @@ __frwr_init(struct rpcrdma_mw *r, struct ib_pd *pd, struct ib_device *device,
>  
>  out_mr_err:
>  	rc = PTR_ERR(f->fr_mr);
> -	dprintk("RPC:       %s: ib_alloc_fast_reg_mr status %i\n",
> +	dprintk("RPC:       %s: ib_alloc_mr status %i\n",
>  		__func__, rc);
>  	return rc;
>  
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> index 6b36279..adcf904 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -738,7 +738,7 @@ static struct svc_rdma_fastreg_mr *rdma_alloc_frmr(struct svcxprt_rdma *xprt)
>  	if (!frmr)
>  		goto err;
>  
> -	mr = ib_alloc_fast_reg_mr(xprt->sc_pd, RPCSVC_MAXPAGES);
> +	mr = ib_alloc_mr(xprt->sc_pd, IB_MR_TYPE_MEM_REG, RPCSVC_MAXPAGES);
>  	if (IS_ERR(mr))
>  		goto err_free_frmr;
>  
> 


WARNING: multiple messages have this Message-ID (diff)
From: Anna Schumaker <Anna.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
To: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH for-4.3 06/15] xprtrdma, svcrdma: Convert to ib_alloc_mr
Date: Thu, 6 Aug 2015 10:22:23 -0400	[thread overview]
Message-ID: <55C36D9F.1040705@Netapp.com> (raw)
In-Reply-To: <1438241568-3685-7-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

This looks good to me:

	Signed-off-by:  Anna Schumaker <Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>

Thanks,
Anna

On 07/30/2015 03:32 AM, Sagi Grimberg wrote:
> Signed-off-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
>  net/sunrpc/xprtrdma/frwr_ops.c           | 6 +++---
>  net/sunrpc/xprtrdma/svc_rdma_transport.c | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/net/sunrpc/xprtrdma/frwr_ops.c b/net/sunrpc/xprtrdma/frwr_ops.c
> index 63f282e..d6653f5 100644
> --- a/net/sunrpc/xprtrdma/frwr_ops.c
> +++ b/net/sunrpc/xprtrdma/frwr_ops.c
> @@ -117,7 +117,7 @@ __frwr_recovery_worker(struct work_struct *work)
>  	if (ib_dereg_mr(r->r.frmr.fr_mr))
>  		goto out_fail;
>  
> -	r->r.frmr.fr_mr = ib_alloc_fast_reg_mr(pd, depth);
> +	r->r.frmr.fr_mr = ib_alloc_mr(pd, IB_MR_TYPE_MEM_REG, depth);
>  	if (IS_ERR(r->r.frmr.fr_mr))
>  		goto out_fail;
>  
> @@ -148,7 +148,7 @@ __frwr_init(struct rpcrdma_mw *r, struct ib_pd *pd, struct ib_device *device,
>  	struct rpcrdma_frmr *f = &r->r.frmr;
>  	int rc;
>  
> -	f->fr_mr = ib_alloc_fast_reg_mr(pd, depth);
> +	f->fr_mr = ib_alloc_mr(pd, IB_MR_TYPE_MEM_REG, depth);
>  	if (IS_ERR(f->fr_mr))
>  		goto out_mr_err;
>  	f->fr_pgl = ib_alloc_fast_reg_page_list(device, depth);
> @@ -158,7 +158,7 @@ __frwr_init(struct rpcrdma_mw *r, struct ib_pd *pd, struct ib_device *device,
>  
>  out_mr_err:
>  	rc = PTR_ERR(f->fr_mr);
> -	dprintk("RPC:       %s: ib_alloc_fast_reg_mr status %i\n",
> +	dprintk("RPC:       %s: ib_alloc_mr status %i\n",
>  		__func__, rc);
>  	return rc;
>  
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> index 6b36279..adcf904 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -738,7 +738,7 @@ static struct svc_rdma_fastreg_mr *rdma_alloc_frmr(struct svcxprt_rdma *xprt)
>  	if (!frmr)
>  		goto err;
>  
> -	mr = ib_alloc_fast_reg_mr(xprt->sc_pd, RPCSVC_MAXPAGES);
> +	mr = ib_alloc_mr(xprt->sc_pd, IB_MR_TYPE_MEM_REG, RPCSVC_MAXPAGES);
>  	if (IS_ERR(mr))
>  		goto err_free_frmr;
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-08-06 14:23 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30  7:32 [PATCH for-4.3 00/15] Modify MR allocation API Sagi Grimberg
2015-07-30  7:32 ` Sagi Grimberg
2015-07-30  7:32 ` [PATCH for-4.3 01/15] IB/core: Get rid of redundant verb ib_destroy_mr Sagi Grimberg
2015-07-30  7:32   ` Sagi Grimberg
2015-07-30  7:32 ` [PATCH for-4.3 02/15] IB: Modify ib_create_mr API Sagi Grimberg
2015-07-30 14:50   ` Steve Wise
2015-07-30 14:50     ` Steve Wise
2015-07-30  7:32 ` [PATCH for-4.3 03/15] IB/iser: Convert to ib_alloc_mr Sagi Grimberg
2015-07-30  7:32   ` Sagi Grimberg
2015-07-30  7:32 ` [PATCH for-4.3 04/15] iser-target: " Sagi Grimberg
2015-07-30  7:32 ` [PATCH for-4.3 05/15] IB/srp: " Sagi Grimberg
2015-07-31 22:41   ` Bart Van Assche
2015-07-31 22:41     ` Bart Van Assche
2015-07-30  7:32 ` [PATCH for-4.3 06/15] xprtrdma, svcrdma: " Sagi Grimberg
2015-07-30  7:32   ` Sagi Grimberg
2015-08-06 14:22   ` Anna Schumaker [this message]
2015-08-06 14:22     ` Anna Schumaker
2015-07-30  7:32 ` [PATCH for-4.3 07/15] RDS: " Sagi Grimberg
2015-07-30  7:32 ` [PATCH for-4.3 08/15] mlx5: Drop mlx5_ib_alloc_fast_reg_mr Sagi Grimberg
2015-07-30  7:32   ` Sagi Grimberg
2015-07-30  7:32 ` [PATCH for-4.3 09/15] mlx4: Support ib_alloc_mr verb Sagi Grimberg
2015-07-30  7:32 ` [PATCH for-4.3 10/15] ocrdma: " Sagi Grimberg
2015-07-30  7:32 ` [PATCH for-4.3 11/15] iw_cxgb4: " Sagi Grimberg
2015-08-07 15:06   ` Steve Wise
2015-08-07 15:06     ` Steve Wise
2015-08-07 15:13     ` Christoph Hellwig
2015-08-07 15:13       ` Christoph Hellwig
2015-08-07 16:19       ` Steve Wise
2015-08-07 16:19         ` Steve Wise
2015-08-07 16:26         ` Steve Wise
2015-08-07 16:26         ` 'Christoph Hellwig'
2015-08-07 16:26           ` 'Christoph Hellwig'
2015-08-07 16:29           ` Steve Wise
2015-08-07 16:29             ` Steve Wise
2015-08-07 16:31             ` 'Christoph Hellwig'
2015-08-07 16:31               ` 'Christoph Hellwig'
2015-07-30  7:32 ` [PATCH for-4.3 12/15] cxgb3: " Sagi Grimberg
2015-07-30  7:32 ` [PATCH for-4.3 13/15] nes: " Sagi Grimberg
2015-07-30  7:32 ` [PATCH for-4.3 14/15] qib: " Sagi Grimberg
2015-07-30  7:32   ` Sagi Grimberg
2015-07-31 11:41   ` Marciniszyn, Mike
2015-07-31 11:41     ` Marciniszyn, Mike
2015-07-31 12:52     ` Doug Ledford
2015-07-31 12:52       ` Doug Ledford
2015-08-07 14:47   ` Marciniszyn, Mike
2015-07-30  7:32 ` [PATCH for-4.3 15/15] IB/core: Drop ib_alloc_fast_reg_mr Sagi Grimberg
2015-07-30 13:53 ` [PATCH for-4.3 00/15] Modify MR allocation API Christoph Hellwig
2015-07-30 13:53   ` Christoph Hellwig
2015-07-30 14:56 ` Steve Wise
2015-07-30 16:42   ` Doug Ledford
2015-07-30 16:42     ` Doug Ledford
2015-07-30 17:22 ` Jason Gunthorpe
2015-07-30 17:22   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C36D9F.1040705@Netapp.com \
    --to=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sagig@mellanox.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.