All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@linux.intel.com>
To: Dave Hansen <dave@sr71.net>, Ingo Molnar <mingo@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Anvin <hpa@zytor.com>, Denys Vlasenko <dvlasenk@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
	bp@alien8.de, Peter Zijlstra <a.p.zijlstra@chello.nl>,
	fenghua.yu@intel.com, x86@kernel.org
Subject: Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation
Date: Thu, 06 Aug 2015 09:03:22 -0700	[thread overview]
Message-ID: <55C3854A.3000401@linux.intel.com> (raw)
In-Reply-To: <55C3758A.50005@sr71.net>

Here's a correction about what we do today, and it's an important point.
 The code I was ripping out in the patch was *really* just for the
XSAVES/compacted case, does *NOT* do anything today since we've disabled
XSAVES.

So perhaps the title here should be:

	[PATCH] x86, fpu: correct XSAVES xstate size calculation

/* Option 1, what we have today */

	if (!cpu_has_xsaves) {
		cpuid(0xD0, 0, &total_blob_size, ...);
		return;
	}
	/*
	 * This breaks if offset[i]+size[i] != offset[i+1]
	 * or if alignment is in play.  Silly hardware breaks
	 * this today.
	 */
	for (i = 0; i < nr_xstates; i++) {
		if (!enabled_xstate(i))
			continue;
		total_blob_size += xstate_sizes[i];
	}


  reply	other threads:[~2015-08-06 16:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 17:21 [PATCH] x86, fpu: correct XSAVE xstate size calculation Dave Hansen
2015-08-05 10:32 ` Ingo Molnar
2015-08-05 14:34   ` Dave Hansen
2015-08-06  7:15     ` Ingo Molnar
     [not found]       ` <CA+55aFxzOj-Ee=DN-_3CMeDeYVsmvmmgoxd3hp4MpRSp+og7AQ@mail.gmail.com>
2015-08-06  8:27         ` Ingo Molnar
2015-08-06  8:29           ` Ingo Molnar
2015-08-06 14:56           ` Dave Hansen
2015-08-06 16:03             ` Dave Hansen [this message]
2015-08-08  9:15             ` Ingo Molnar
2015-08-06 17:19       ` Dave Hansen
2015-08-08  9:06         ` Ingo Molnar
2015-08-10 21:14           ` Dave Hansen
2015-08-22 13:21             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C3854A.3000401@linux.intel.com \
    --to=dave.hansen@linux.intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=bp@alien8.de \
    --cc=dave@sr71.net \
    --cc=dvlasenk@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.