All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@sr71.net>
To: Ingo Molnar <mingo@kernel.org>
Cc: dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
	bp@alien8.de, fenghua.yu@intel.com, hpa@zytor.com,
	x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Lutomirski <luto@kernel.org>,
	Denys Vlasenko <dvlasenk@redhat.com>
Subject: Re: [PATCH] x86, fpu: correct XSAVE xstate size calculation
Date: Mon, 10 Aug 2015 14:14:59 -0700	[thread overview]
Message-ID: <55C91453.5060509@sr71.net> (raw)
In-Reply-To: <20150808090615.GA32641@gmail.com>

On 08/08/2015 02:06 AM, Ingo Molnar wrote:
>>> What sense does it make to have a blob we don't know the exact layout of? How will 
>>> > > debuggers or user-space in general be able to print (and change) the register 
>>> > > values if they don't know the layout?
>> > 
>> > Ingo, we know the layout.  We know where every component is.  We know
>> > how big each component is.  This patch does not change the fact that we
>> > calculate and store that.
> The patch you submitted blindly trusts the CPU, and I'm uneasy about that for 
> multiple reasons. We can and should do better than that, while still flexibly 
> making use of all CPU capabilities that are offered.

Yes, it blindly trusts the CPU.  This is precisely* what the *existing*
code has done since commit dc1e35c6e95 got merged in 2008.  Do you have
some specific concern with the compact format that makes you want to
stop blindly trusting the CPU after 7 years?

I know what you want now (I've coded up half of it already), but I've
not got the foggiest idea why other than pure paranoia.

  reply	other threads:[~2015-08-10 21:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 17:21 [PATCH] x86, fpu: correct XSAVE xstate size calculation Dave Hansen
2015-08-05 10:32 ` Ingo Molnar
2015-08-05 14:34   ` Dave Hansen
2015-08-06  7:15     ` Ingo Molnar
     [not found]       ` <CA+55aFxzOj-Ee=DN-_3CMeDeYVsmvmmgoxd3hp4MpRSp+og7AQ@mail.gmail.com>
2015-08-06  8:27         ` Ingo Molnar
2015-08-06  8:29           ` Ingo Molnar
2015-08-06 14:56           ` Dave Hansen
2015-08-06 16:03             ` Dave Hansen
2015-08-08  9:15             ` Ingo Molnar
2015-08-06 17:19       ` Dave Hansen
2015-08-08  9:06         ` Ingo Molnar
2015-08-10 21:14           ` Dave Hansen [this message]
2015-08-22 13:21             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C91453.5060509@sr71.net \
    --to=dave@sr71.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dvlasenk@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.