From: sagig@dev.mellanox.co.il (Sagi Grimberg)
Subject: [PATCHv4] blk: Replace SG_GAPGS with new queue limits mask
Date: Thu, 6 Aug 2015 20:36:58 +0300 [thread overview]
Message-ID: <55C39B3A.5030201@dev.mellanox.co.il> (raw)
In-Reply-To: <1438716733-566-1-git-send-email-keith.busch@intel.com>
> +/*
> + * Check if adding a bio_vec after bprv with offset would create a gap in
> + * the SG list. Most drivers don't care about this, but some do.
> + */
> +static inline bool bvec_gap_to_prev(struct request_queue *q,
> + struct bio_vec *bprv, unsigned int offset)
> +{
> + if (!queue_virt_boundary(q))
> + return false;
> + return offset ||
> + ((bprv->bv_offset + bprv->bv_len) & queue_virt_boundary(q));
I'm wandering if it deserves an unlikely() statement given it really
depends on the application workload...
Thoughts?
next prev parent reply other threads:[~2015-08-06 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 19:32 [PATCHv4] blk: Replace SG_GAPGS with new queue limits mask Keith Busch
2015-08-05 1:45 ` Martin K. Petersen
2015-08-06 13:50 ` Christoph Hellwig
2015-08-19 19:12 ` Busch, Keith
2015-08-19 21:26 ` Jens Axboe
2015-08-06 17:36 ` Sagi Grimberg [this message]
2015-08-07 6:34 ` Christoph Hellwig
2015-09-01 14:01 ` Sagi Grimberg
2015-09-01 16:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C39B3A.5030201@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.