From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCHv4] blk: Replace SG_GAPGS with new queue limits mask
Date: Tue, 04 Aug 2015 21:45:54 -0400 [thread overview]
Message-ID: <yq1oaimik31.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1438716733-566-1-git-send-email-keith.busch@intel.com> (Keith Busch's message of "Tue, 4 Aug 2015 13:32:13 -0600")
>>>>> "Keith" == Keith Busch <keith.busch at intel.com> writes:
Keith> The SG_GAPS queue flag caused checks for bio vector alignment
Keith> against PAGE_SIZE, but the device may have different
Keith> constraints. This patch adds a queue limits so a driver with such
Keith> constraints can set to allow requests that would have been
Keith> unnecessarily split. The new gaps check takes the request_queue
Keith> as a parameter to simplify the logic around invoking this
Keith> function.
Keith> This new limit makes the queue flag redundant, so removing it and
Keith> all usage. Device-mappers will inherit the correct settings
Keith> through blk_stack_limits().
This looks good to me except for the typo in the Subject: line.
Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2015-08-05 1:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 19:32 [PATCHv4] blk: Replace SG_GAPGS with new queue limits mask Keith Busch
2015-08-05 1:45 ` Martin K. Petersen [this message]
2015-08-06 13:50 ` Christoph Hellwig
2015-08-19 19:12 ` Busch, Keith
2015-08-19 21:26 ` Jens Axboe
2015-08-06 17:36 ` Sagi Grimberg
2015-08-07 6:34 ` Christoph Hellwig
2015-09-01 14:01 ` Sagi Grimberg
2015-09-01 16:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1oaimik31.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.