* [PATCH v2] ata: ahci_brcmstb: Fix misuse of IS_ENABLED
@ 2015-08-06 4:28 ` Axel Lin
0 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2015-08-06 4:28 UTC (permalink / raw)
To: Tejun Heo
Cc: Brian Norris, Gregory Fong, Florian Fainelli, linux-ide,
linux-arm-kernel
While IS_ENABLED() is perfectly fine for CONFIG_* symbols, it is not
for other symbols such as __BIG_ENDIAN that is provided directly by
the compiler.
Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
v2:
Based on Florian's comment:
Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
drivers/ata/ahci_brcmstb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/ahci_brcmstb.c b/drivers/ata/ahci_brcmstb.c
index 42b6cf4..14b7305 100644
--- a/drivers/ata/ahci_brcmstb.c
+++ b/drivers/ata/ahci_brcmstb.c
@@ -92,7 +92,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)
* Other architectures (e.g., ARM) either do not support big endian, or
* else leave I/O in little endian mode.
*/
- if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(__BIG_ENDIAN))
+ if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
return __raw_readl(addr);
else
return readl_relaxed(addr);
@@ -101,7 +101,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)
static inline void brcm_sata_writereg(u32 val, void __iomem *addr)
{
/* See brcm_sata_readreg() comments */
- if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(__BIG_ENDIAN))
+ if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
__raw_writel(val, addr);
else
writel_relaxed(val, addr);
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2] ata: ahci_brcmstb: Fix misuse of IS_ENABLED
@ 2015-08-06 4:28 ` Axel Lin
0 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2015-08-06 4:28 UTC (permalink / raw)
To: linux-arm-kernel
While IS_ENABLED() is perfectly fine for CONFIG_* symbols, it is not
for other symbols such as __BIG_ENDIAN that is provided directly by
the compiler.
Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
v2:
Based on Florian's comment:
Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
drivers/ata/ahci_brcmstb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/ahci_brcmstb.c b/drivers/ata/ahci_brcmstb.c
index 42b6cf4..14b7305 100644
--- a/drivers/ata/ahci_brcmstb.c
+++ b/drivers/ata/ahci_brcmstb.c
@@ -92,7 +92,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)
* Other architectures (e.g., ARM) either do not support big endian, or
* else leave I/O in little endian mode.
*/
- if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(__BIG_ENDIAN))
+ if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
return __raw_readl(addr);
else
return readl_relaxed(addr);
@@ -101,7 +101,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)
static inline void brcm_sata_writereg(u32 val, void __iomem *addr)
{
/* See brcm_sata_readreg() comments */
- if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(__BIG_ENDIAN))
+ if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
__raw_writel(val, addr);
else
writel_relaxed(val, addr);
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] ata: ahci_brcmstb: Fix misuse of IS_ENABLED
2015-08-06 4:28 ` Axel Lin
@ 2015-08-06 18:10 ` Florian Fainelli
-1 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2015-08-06 18:10 UTC (permalink / raw)
To: Axel Lin, Tejun Heo
Cc: Brian Norris, Gregory Fong, linux-ide, linux-arm-kernel
On 05/08/15 21:28, Axel Lin wrote:
> While IS_ENABLED() is perfectly fine for CONFIG_* symbols, it is not
> for other symbols such as __BIG_ENDIAN that is provided directly by
> the compiler.
>
> Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> v2:
> Based on Florian's comment:
> Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
>
> drivers/ata/ahci_brcmstb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/ahci_brcmstb.c b/drivers/ata/ahci_brcmstb.c
> index 42b6cf4..14b7305 100644
> --- a/drivers/ata/ahci_brcmstb.c
> +++ b/drivers/ata/ahci_brcmstb.c
> @@ -92,7 +92,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)
> * Other architectures (e.g., ARM) either do not support big endian, or
> * else leave I/O in little endian mode.
> */
> - if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(__BIG_ENDIAN))
> + if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
> return __raw_readl(addr);
> else
> return readl_relaxed(addr);
> @@ -101,7 +101,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)
> static inline void brcm_sata_writereg(u32 val, void __iomem *addr)
> {
> /* See brcm_sata_readreg() comments */
> - if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(__BIG_ENDIAN))
> + if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
> __raw_writel(val, addr);
> else
> writel_relaxed(val, addr);
>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] ata: ahci_brcmstb: Fix misuse of IS_ENABLED
@ 2015-08-06 18:10 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2015-08-06 18:10 UTC (permalink / raw)
To: linux-arm-kernel
On 05/08/15 21:28, Axel Lin wrote:
> While IS_ENABLED() is perfectly fine for CONFIG_* symbols, it is not
> for other symbols such as __BIG_ENDIAN that is provided directly by
> the compiler.
>
> Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> v2:
> Based on Florian's comment:
> Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
>
> drivers/ata/ahci_brcmstb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/ahci_brcmstb.c b/drivers/ata/ahci_brcmstb.c
> index 42b6cf4..14b7305 100644
> --- a/drivers/ata/ahci_brcmstb.c
> +++ b/drivers/ata/ahci_brcmstb.c
> @@ -92,7 +92,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)
> * Other architectures (e.g., ARM) either do not support big endian, or
> * else leave I/O in little endian mode.
> */
> - if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(__BIG_ENDIAN))
> + if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
> return __raw_readl(addr);
> else
> return readl_relaxed(addr);
> @@ -101,7 +101,7 @@ static inline u32 brcm_sata_readreg(void __iomem *addr)
> static inline void brcm_sata_writereg(u32 val, void __iomem *addr)
> {
> /* See brcm_sata_readreg() comments */
> - if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(__BIG_ENDIAN))
> + if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
> __raw_writel(val, addr);
> else
> writel_relaxed(val, addr);
>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ata: ahci_brcmstb: Fix misuse of IS_ENABLED
2015-08-06 4:28 ` Axel Lin
@ 2015-08-06 18:32 ` Tejun Heo
-1 siblings, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2015-08-06 18:32 UTC (permalink / raw)
To: Axel Lin
Cc: Brian Norris, Gregory Fong, Florian Fainelli, linux-ide,
linux-arm-kernel
On Thu, Aug 06, 2015 at 12:28:18PM +0800, Axel Lin wrote:
> While IS_ENABLED() is perfectly fine for CONFIG_* symbols, it is not
> for other symbols such as __BIG_ENDIAN that is provided directly by
> the compiler.
>
> Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied to libata/for-4.2-fixes w/ stable cc'd.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ata: ahci_brcmstb: Fix misuse of IS_ENABLED
@ 2015-08-06 18:32 ` Tejun Heo
0 siblings, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2015-08-06 18:32 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 06, 2015 at 12:28:18PM +0800, Axel Lin wrote:
> While IS_ENABLED() is perfectly fine for CONFIG_* symbols, it is not
> for other symbols such as __BIG_ENDIAN that is provided directly by
> the compiler.
>
> Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied to libata/for-4.2-fixes w/ stable cc'd.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-08-06 18:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-06 4:28 [PATCH v2] ata: ahci_brcmstb: Fix misuse of IS_ENABLED Axel Lin
2015-08-06 4:28 ` Axel Lin
2015-08-06 18:10 ` Florian Fainelli
2015-08-06 18:10 ` Florian Fainelli
2015-08-06 18:32 ` Tejun Heo
2015-08-06 18:32 ` Tejun Heo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.