[PATCH 1/2] i2c: designware: Remove space between variable and its value in debug print

[PATCH 1/2] i2c: designware: Remove space between variable and its value in debug print

[Jarkko Nikula]

Remove extra space from "enabled= 0x" to make debug print a bit more dense
and to be in sync with "stat=0x". While at it, use "%#x" for printing "0x"
prefixed hexadecimal values.

Signed-off-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/i2c/busses/i2c-designware-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c
index 6f19a33773fe..7310051d4a50 100644
--- a/drivers/i2c/busses/i2c-designware-core.c
+++ b/drivers/i2c/busses/i2c-designware-core.c
@@ -777,7 +777,7 @@ irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
 
 	enabled = dw_readl(dev, DW_IC_ENABLE);
 	stat = dw_readl(dev, DW_IC_RAW_INTR_STAT);
-	dev_dbg(dev->dev, "%s:  %s enabled= 0x%x stat=0x%x\n", __func__,
+	dev_dbg(dev->dev, "%s:  %s enabled=%#x stat=%#x\n", __func__,
 		dev->adapter.name, enabled, stat);
 	if (!enabled || !(stat & ~DW_IC_INTR_ACTIVITY))
 		return IRQ_NONE;
-- 
2.4.6

[PATCH 2/2] i2c: designware: Remove adapter name from debug print in i2c_dw_isr()

[Jarkko Nikula]

Printing adapter name is irrelevant from this debug print and makes output
needlessly long. Having already device and functions names printed here is
enough for debugging.

Signed-off-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/i2c/busses/i2c-designware-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c
index 7310051d4a50..cc98b2a75591 100644
--- a/drivers/i2c/busses/i2c-designware-core.c
+++ b/drivers/i2c/busses/i2c-designware-core.c
@@ -777,8 +777,8 @@ irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
 
 	enabled = dw_readl(dev, DW_IC_ENABLE);
 	stat = dw_readl(dev, DW_IC_RAW_INTR_STAT);
-	dev_dbg(dev->dev, "%s:  %s enabled=%#x stat=%#x\n", __func__,
-		dev->adapter.name, enabled, stat);
+	dev_dbg(dev->dev, "%s: enabled=%#x stat=%#x\n", __func__,
+		enabled, stat);
 	if (!enabled || !(stat & ~DW_IC_INTR_ACTIVITY))
 		return IRQ_NONE;
 
-- 
2.4.6

Re: [PATCH 1/2] i2c: designware: Remove space between variable and its value in debug print

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 112 bytes --]

> +	dev_dbg(dev->dev, "%s:  %s enabled=%#x stat=%#x\n", __func__,

What about the double space between the %s?


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 2/2] i2c: designware: Remove adapter name from debug print in i2c_dw_isr()

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

On Fri, Aug 07, 2015 at 01:43:28PM +0300, Jarkko Nikula wrote:
> Printing adapter name is irrelevant from this debug print and makes output
> needlessly long. Having already device and functions names printed here is
> enough for debugging.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

So much about the double space :) I think I'll squash those two.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 2/2] i2c: designware: Remove adapter name from debug print in i2c_dw_isr()

[Jarkko Nikula]

On 07.08.2015 14:10, Wolfram Sang wrote:
> On Fri, Aug 07, 2015 at 01:43:28PM +0300, Jarkko Nikula wrote:
>> Printing adapter name is irrelevant from this debug print and makes output
>> needlessly long. Having already device and functions names printed here is
>> enough for debugging.
>>
>> Signed-off-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>
> So much about the double space :) I think I'll squash those two.
>
Fine to me. Actually long "Synopsys DesignWare I2C adapter" printed 
bothered me most.

-- 
Jarkko