All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: kbuild test robot <fengguang.wu@intel.com>,
	Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
Cc: kbuild-all@01.org, lm-sensors@lm-sensors.org,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"wim@iguana.be" <wim@iguana.be>
Subject: Re: [PATCH hwmon] watchdog: lpc18xx_wdt_get_timeleft() can be static
Date: Fri, 07 Aug 2015 10:28:40 -0700	[thread overview]
Message-ID: <55C4EAC8.3090005@roeck-us.net> (raw)
In-Reply-To: <20150807170350.GA92637@athens>

On 08/07/2015 10:03 AM, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Wrong subsystem (should be watchdog), but still makes sense on top
of the offending patch. I'll add it to my pull request for Wim.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   lpc18xx_wdt.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/lpc18xx_wdt.c b/drivers/watchdog/lpc18xx_wdt.c
> index 00ff5bd..ab7b8b1 100644
> --- a/drivers/watchdog/lpc18xx_wdt.c
> +++ b/drivers/watchdog/lpc18xx_wdt.c
> @@ -123,7 +123,7 @@ static int lpc18xx_wdt_set_timeout(struct watchdog_device *wdt_dev,
>   	return 0;
>   }
>
> -unsigned int lpc18xx_wdt_get_timeleft(struct watchdog_device *wdt_dev)
> +static unsigned int lpc18xx_wdt_get_timeleft(struct watchdog_device *wdt_dev)
>   {
>   	struct lpc18xx_wdt_dev *lpc18xx_wdt = watchdog_get_drvdata(wdt_dev);
>   	unsigned int val;
>


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: kbuild test robot <fengguang.wu@intel.com>,
	Ariel D'Alessandro <ariel@vanguardiasur.com.ar>
Cc: kbuild-all@01.org, lm-sensors@lm-sensors.org,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"wim@iguana.be" <wim@iguana.be>
Subject: Re: [lm-sensors] [PATCH hwmon] watchdog: lpc18xx_wdt_get_timeleft() can be static
Date: Fri, 07 Aug 2015 17:28:40 +0000	[thread overview]
Message-ID: <55C4EAC8.3090005@roeck-us.net> (raw)
In-Reply-To: <20150807170350.GA92637@athens>

On 08/07/2015 10:03 AM, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Wrong subsystem (should be watchdog), but still makes sense on top
of the offending patch. I'll add it to my pull request for Wim.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   lpc18xx_wdt.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/lpc18xx_wdt.c b/drivers/watchdog/lpc18xx_wdt.c
> index 00ff5bd..ab7b8b1 100644
> --- a/drivers/watchdog/lpc18xx_wdt.c
> +++ b/drivers/watchdog/lpc18xx_wdt.c
> @@ -123,7 +123,7 @@ static int lpc18xx_wdt_set_timeout(struct watchdog_device *wdt_dev,
>   	return 0;
>   }
>
> -unsigned int lpc18xx_wdt_get_timeleft(struct watchdog_device *wdt_dev)
> +static unsigned int lpc18xx_wdt_get_timeleft(struct watchdog_device *wdt_dev)
>   {
>   	struct lpc18xx_wdt_dev *lpc18xx_wdt = watchdog_get_drvdata(wdt_dev);
>   	unsigned int val;
>


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2015-08-07 17:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07 17:03 [lm-sensors] [hwmon:watchdog-next 11/19] drivers/watchdog/lpc18xx_wdt.c:126:14: sparse: symbol kbuild test robot
2015-08-07 17:03 ` [lm-sensors] [PATCH hwmon] watchdog: lpc18xx_wdt_get_timeleft() can be static kbuild test robot
2015-08-07 17:28   ` Guenter Roeck [this message]
2015-08-07 17:28     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C4EAC8.3090005@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=ariel@vanguardiasur.com.ar \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.